From: Wolfram Sang <wsa@kernel.org>
To: "Wu, Wentong" <wentong.wu@intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"mka@chromium.org" <mka@chromium.org>,
"oneukum@suse.com" <oneukum@suse.com>,
"lee@kernel.org" <lee@kernel.org>,
"kfting@nuvoton.com" <kfting@nuvoton.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"maz@kernel.org" <maz@kernel.org>,
"brgl@bgdev.pl" <brgl@bgdev.pl>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"andi.shyti@linux.intel.com" <andi.shyti@linux.intel.com>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"bartosz.golaszewski@linaro.org" <bartosz.golaszewski@linaro.org>,
"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
"Wang, Zhifeng" <zhifeng.wang@intel.com>
Subject: Re: [PATCH v19 2/4] i2c: Add support for Intel LJCA USB I2C driver
Date: Fri, 29 Sep 2023 22:10:48 +0200 [thread overview]
Message-ID: <ZRcvSI/pklsw6+mf@kunai> (raw)
In-Reply-To: <DM6PR11MB4316B740D57D4E9EFE4D5B608DC0A@DM6PR11MB4316.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
> And with i2cdetect -q busnum, I see error on driver side which enable
> I2C_FUNC_SMBUS_EMUL and not disable I2C_FUNC_SMBUS_QUICK, I think
> it means we don't support zero-length transfer if I understand correctly.
At least, not currently. Sometimes the driver just needs updates,
sometimes the HW simply cannot do it. If it is a software issue, we can
fix it incrementally.
> static u32 ljca_i2c_func(struct i2c_adapter *adap)
> {
> return I2C_FUNC_I2C | (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK);
> }
Yes.
> static const struct i2c_adapter_quirks ljca_i2c_quirks = {
> .flags = I2C_AQ_NO_ZERO_LEN,
> .max_read_len = LJCA_I2C_MAX_XFER_SIZE,
> .max_write_len = LJCA_I2C_MAX_XFER_SIZE,
> };
Yes.
I think the I2C driver is good then.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-09-29 20:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 18:53 [PATCH v19 0/4] Add Intel LJCA device driver Wentong Wu
2023-09-16 18:53 ` [PATCH v19 1/4] usb: Add support for Intel LJCA device Wentong Wu
2023-09-28 14:36 ` Greg KH
2023-09-29 11:31 ` Wu, Wentong
2023-10-02 11:30 ` Greg KH
2023-10-03 2:51 ` Wu, Wentong
2023-10-06 13:07 ` Wu, Wentong
2023-09-16 18:53 ` [PATCH v19 2/4] i2c: Add support for Intel LJCA USB I2C driver Wentong Wu
2023-09-29 7:51 ` Wolfram Sang
2023-09-29 16:11 ` Wu, Wentong
2023-09-29 20:10 ` Wolfram Sang [this message]
2023-09-16 18:53 ` [PATCH v19 3/4] spi: Add support for Intel LJCA USB SPI driver Wentong Wu
2023-09-16 18:53 ` [PATCH v19 4/4] gpio: update Intel LJCA USB GPIO driver Wentong Wu
2023-09-28 14:17 ` Greg KH
2023-09-29 11:33 ` Wu, Wentong
2023-09-17 10:37 ` [PATCH v19 0/4] Add Intel LJCA device driver Marc Zyngier
2023-09-17 10:42 ` Greg KH
2023-09-17 11:26 ` Hans de Goede
2023-09-28 10:18 ` Oliver Neukum
2023-09-28 12:20 ` Hans de Goede
2023-09-28 12:24 ` Greg KH
2023-09-28 12:43 ` Mark Brown
2023-09-28 12:28 ` Andi Shyti
2023-09-28 13:56 ` Bartosz Golaszewski
2023-09-18 3:08 ` Wu, Wentong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRcvSI/pklsw6+mf@kunai \
--to=wsa@kernel.org \
--cc=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kfting@nuvoton.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mka@chromium.org \
--cc=oneukum@suse.com \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@intel.com \
--cc=wentong.wu@intel.com \
--cc=zhifeng.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).