From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28CA8E75436 for ; Tue, 3 Oct 2023 09:08:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231439AbjJCJI1 (ORCPT ); Tue, 3 Oct 2023 05:08:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231416AbjJCJI0 (ORCPT ); Tue, 3 Oct 2023 05:08:26 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA4979E; Tue, 3 Oct 2023 02:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696324103; x=1727860103; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GNdDkE0295DLsorKWTDOi5Sj8aKZsui3/WlnS5ZyMJI=; b=gm5LQ/zwyWcEFCLRw43vdFbiC2aS2rchGoXYZm+K17QNcmErB/2F4vk9 2KDw6pCqr6fiHssjUPG61WNveyrWzlEPqv0DQ42i+EU/k9YBq/3XPZ+8c YEKOuV4adiIoXWF7VfwilhXRWkn8II1oqwsTPcQWVx6UARQJjT3vHw6YI GDyEoWWxMlGmpRSbqlsw1WDuCsiPW0Gpys0Es69EnbBnMapDQU+fh6/Gn Qco8X8BcFagXQNpvQq6peoQHY6ckzU9tbFtiN4kIOkJK72+sLNncFOEW4 EH2iWhB7b4Imr8a5sGpp/Ghf8L+l5A+IQ14JYOi53eKRUwPOFe96J8yxT g==; X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="367876985" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="367876985" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 02:08:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="816615399" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="816615399" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 02:08:21 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC1) (envelope-from ) id 1qnbO6-00000002RQC-1J8S; Tue, 03 Oct 2023 12:08:18 +0300 Date: Tue, 3 Oct 2023 12:08:18 +0300 From: Andy Shevchenko To: Raag Jadav Cc: linus.walleij@linaro.org, mika.westerberg@linux.intel.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v1] pinctrl: intel: refine intel_config_set_pull() function Message-ID: References: <20231003081824.28810-1-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231003081824.28810-1-raag.jadav@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Oct 03, 2023 at 01:48:24PM +0530, Raag Jadav wrote: > Improve intel_config_set_pull() implementation in Intel pinctrl driver by: > > - Reducing scope of spinlock by moving unneeded operations out of it. > - Utilizing temporary variables for common operations. > - Limiting IO operations to positive cases. Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko