From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04965C4332F for ; Tue, 31 Oct 2023 13:59:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344714AbjJaN7e (ORCPT ); Tue, 31 Oct 2023 09:59:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344693AbjJaN7d (ORCPT ); Tue, 31 Oct 2023 09:59:33 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8591E6; Tue, 31 Oct 2023 06:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698760770; x=1730296770; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GHC9JJLjxYAwUCBjiPkG7gQfKyEtrkzL46wpQ3Px//4=; b=m8g7Hb7moAa0j2nmVVbfTAk+TCE1g8lmaJInSUC+7iQLijnF1uyds+wE 46i+QyxQBHa65GLbJsW66PeuI70S+QKs1kQdsf/YDsYerIQ8BF6r4GBPv SQYjrc3EYYsQZZJ7AmOZMKO3shWp87iXBjQaJTiMNQnIPRCMbqvw/NRsv SUgpOU2pxq34uJeKIUQWF7mJGuk+08NJd4Fmkr5G2T5w6YaklRuvQFSZ1 X3J1KRI2KsxoHhzOBZ59ljLdIE7EAyXI0YVxF+/I/md1dZJnzSQjYh+eo buSg3kysdaiDZ1WY0B+QROIsTINK3EkL/RiF+xr1tVE6Y8rNpb1pD6Nq/ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="378680000" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="378680000" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 06:59:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="795586029" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="795586029" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 06:59:28 -0700 Date: Tue, 31 Oct 2023 15:59:25 +0200 From: Raag Jadav To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Andy Shevchenko , Linus Walleij Subject: Re: [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias Message-ID: References: <20231030141404.3242102-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Oct 30, 2023 at 11:35:42PM +0200, Raag Jadav wrote: > On Mon, Oct 30, 2023 at 04:14:04PM +0200, Andy Shevchenko wrote: > > Family 7 (I2C) supports special bias value, i.e. 910 Ohm. > > > > Enable it for configuring pin. > > > > Signed-off-by: Andy Shevchenko > > --- > > drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c > > index 40dd60c9e526..007bca1cf224 100644 > > --- a/drivers/pinctrl/intel/pinctrl-tangier.c > > +++ b/drivers/pinctrl/intel/pinctrl-tangier.c > > @@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin, > > case 2000: > > term = BUFCFG_PUPD_VAL_2K; > > break; > > + case 910: > > + term = BUFCFG_PUPD_VAL_910; > > + break; > > default: > > return -EINVAL; > > } > > @@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin, > > case 2000: > > term = BUFCFG_PUPD_VAL_2K; > > break; > > + case 910: > > + term = BUFCFG_PUPD_VAL_910; > > + break; > > default: > > return -EINVAL; > > } > > Ah, I failed to notice this was already present in the getter. > > Looks good, Reviewed-by: Raag Jadav