[PATCH v1 0/3] gpio: mmio: Make driver agnostic

[PATCH v1 0/3] gpio: mmio: Make driver agnostic

[Andy Shevchenko]

Driver uses so far some OF APIs when generic fwnode ones can be used.
Replace these APIs accordingly. Note, this will help to clean up OF
headers even more.

Andy Shevchenko (3):
  device property: Implement device_is_big_endian()
  gpio: mmio: Make use of device properties
  gpio: mmio: Clean up headers

 drivers/gpio/gpio-mmio.c | 53 +++++++++++++++-------------------------
 include/linux/property.h | 26 ++++++++++++++++++++
 2 files changed, 46 insertions(+), 33 deletions(-)

-- 
2.40.0.1.gaa8946217a0b

[PATCH v1 1/3] device property: Implement device_is_big_endian()

[Andy Shevchenko]

Some users want to use the struct device pointer to see if the
device is big endian in terms of Open Firmware specifications,
i.e. if it has a "big-endian" property, or if the kernel was
compiled for BE *and* the device has a "native-endian" property.

Provide inline helper for the users.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/property.h | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/include/linux/property.h b/include/linux/property.h
index 2b8f07fc68a9..d1400a477b0a 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -80,12 +80,38 @@ int fwnode_property_match_string(const struct fwnode_handle *fwnode,
 
 bool fwnode_device_is_available(const struct fwnode_handle *fwnode);
 
+static inline bool fwnode_device_is_big_endian(const struct fwnode_handle *fwnode)
+{
+	if (fwnode_property_present(fwnode, "big-endian"))
+		return true;
+	if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) &&
+	    fwnode_property_present(fwnode, "native-endian"))
+		return true;
+	return false;
+}
+
 static inline
 bool fwnode_device_is_compatible(const struct fwnode_handle *fwnode, const char *compat)
 {
 	return fwnode_property_match_string(fwnode, "compatible", compat) >= 0;
 }
 
+/**
+ * device_is_big_endian - check if a device has BE registers
+ * @dev: Pointer to the struct device
+ *
+ * Returns: true if the device has a "big-endian" property, or if the kernel
+ * was compiled for BE *and* the device has a "native-endian" property.
+ * Returns false otherwise.
+ *
+ * Callers would nominally use ioread32be/iowrite32be if
+ * device_is_big_endian() == true, or readl/writel otherwise.
+ */
+static inline bool device_is_big_endian(const struct device *dev)
+{
+	return fwnode_device_is_big_endian(dev_fwnode(dev));
+}
+
 /**
  * device_is_compatible - match 'compatible' property of the device with a given string
  * @dev: Pointer to the struct device
-- 
2.40.0.1.gaa8946217a0b

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Greg Kroah-Hartman]

On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> Some users want to use the struct device pointer to see if the
> device is big endian in terms of Open Firmware specifications,
> i.e. if it has a "big-endian" property, or if the kernel was
> compiled for BE *and* the device has a "native-endian" property.
> 
> Provide inline helper for the users.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  include/linux/property.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Andy Shevchenko]

On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > Some users want to use the struct device pointer to see if the
> > device is big endian in terms of Open Firmware specifications,
> > i.e. if it has a "big-endian" property, or if the kernel was
> > compiled for BE *and* the device has a "native-endian" property.
> > 
> > Provide inline helper for the users.
> 
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thank you, Greg.

Bart, would it be still possible to take this into next?
I would like to have at least this patch applied (with the first user)
to allow conversion of others (I have some more users of new API).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Andy Shevchenko]

On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > > Some users want to use the struct device pointer to see if the
> > > device is big endian in terms of Open Firmware specifications,
> > > i.e. if it has a "big-endian" property, or if the kernel was
> > > compiled for BE *and* the device has a "native-endian" property.
> > > 
> > > Provide inline helper for the users.
> > 
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Thank you, Greg.
> 
> Bart, would it be still possible to take this into next?
> I would like to have at least this patch applied (with the first user)
> to allow conversion of others (I have some more users of new API).

Okay, seems we missed v6.7 with this, can you then prepare an immutable
branch / tag with this, so other maintainers can pull in case it's needed?
(I have something against tty already and perhaps something else, let's
 see.)

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Greg Kroah-Hartman]

On Thu, Nov 02, 2023 at 05:33:40PM +0200, Andy Shevchenko wrote:
> On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > > > Some users want to use the struct device pointer to see if the
> > > > device is big endian in terms of Open Firmware specifications,
> > > > i.e. if it has a "big-endian" property, or if the kernel was
> > > > compiled for BE *and* the device has a "native-endian" property.
> > > > 
> > > > Provide inline helper for the users.
> > > 
> > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > Thank you, Greg.
> > 
> > Bart, would it be still possible to take this into next?
> > I would like to have at least this patch applied (with the first user)
> > to allow conversion of others (I have some more users of new API).
> 
> Okay, seems we missed v6.7 with this, can you then prepare an immutable
> branch / tag with this, so other maintainers can pull in case it's needed?
> (I have something against tty already and perhaps something else, let's
>  see.)

After -rc1 is out, I'll look into it, can't do anything until then,
sorry...

greg k-h

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Andy Shevchenko]

On Thu, Nov 02, 2023 at 04:58:53PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 02, 2023 at 05:33:40PM +0200, Andy Shevchenko wrote:
> > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > > > > Some users want to use the struct device pointer to see if the
> > > > > device is big endian in terms of Open Firmware specifications,
> > > > > i.e. if it has a "big-endian" property, or if the kernel was
> > > > > compiled for BE *and* the device has a "native-endian" property.
> > > > > 
> > > > > Provide inline helper for the users.
> > > > 
> > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > 
> > > Thank you, Greg.
> > > 
> > > Bart, would it be still possible to take this into next?
> > > I would like to have at least this patch applied (with the first user)
> > > to allow conversion of others (I have some more users of new API).
> > 
> > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > branch / tag with this, so other maintainers can pull in case it's needed?
> > (I have something against tty already and perhaps something else, let's
> >  see.)
> 
> After -rc1 is out, I'll look into it, can't do anything until then,
> sorry...

No problem, this is actually a great news!


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Bartosz Golaszewski]

On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > > > Some users want to use the struct device pointer to see if the
> > > > device is big endian in terms of Open Firmware specifications,
> > > > i.e. if it has a "big-endian" property, or if the kernel was
> > > > compiled for BE *and* the device has a "native-endian" property.
> > > >
> > > > Provide inline helper for the users.
> > >
> > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Thank you, Greg.
> >
> > Bart, would it be still possible to take this into next?
> > I would like to have at least this patch applied (with the first user)
> > to allow conversion of others (I have some more users of new API).
>
> Okay, seems we missed v6.7 with this, can you then prepare an immutable
> branch / tag with this, so other maintainers can pull in case it's needed?
> (I have something against tty already and perhaps something else, let's
>  see.)
>

It arrived too late in the cycle, I needed to send my PR earlier this
time as I was OoO this week.

Bart

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Bartosz Golaszewski]

On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > > > > Some users want to use the struct device pointer to see if the
> > > > > device is big endian in terms of Open Firmware specifications,
> > > > > i.e. if it has a "big-endian" property, or if the kernel was
> > > > > compiled for BE *and* the device has a "native-endian" property.
> > > > >
> > > > > Provide inline helper for the users.
> > > >
> > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > Thank you, Greg.
> > >
> > > Bart, would it be still possible to take this into next?
> > > I would like to have at least this patch applied (with the first user)
> > > to allow conversion of others (I have some more users of new API).
> >
> > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > branch / tag with this, so other maintainers can pull in case it's needed?
> > (I have something against tty already and perhaps something else, let's
> >  see.)
> >
>
> It arrived too late in the cycle, I needed to send my PR earlier this
> time as I was OoO this week.
>
> Bart

Greg, will you take this patch through your tree and provide me with
an immutable tag for this cycle?

Bart

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Greg Kroah-Hartman]

On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > > > > > Some users want to use the struct device pointer to see if the
> > > > > > device is big endian in terms of Open Firmware specifications,
> > > > > > i.e. if it has a "big-endian" property, or if the kernel was
> > > > > > compiled for BE *and* the device has a "native-endian" property.
> > > > > >
> > > > > > Provide inline helper for the users.
> > > > >
> > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > >
> > > > Thank you, Greg.
> > > >
> > > > Bart, would it be still possible to take this into next?
> > > > I would like to have at least this patch applied (with the first user)
> > > > to allow conversion of others (I have some more users of new API).
> > >
> > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > (I have something against tty already and perhaps something else, let's
> > >  see.)
> > >
> >
> > It arrived too late in the cycle, I needed to send my PR earlier this
> > time as I was OoO this week.
> >
> > Bart
> 
> Greg, will you take this patch through your tree and provide me with
> an immutable tag for this cycle?

Sure, let me catch up with patches after I return from Plumbers next
week.

greg k-h

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Andy Shevchenko]

On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > > > > > > Some users want to use the struct device pointer to see if the
> > > > > > > device is big endian in terms of Open Firmware specifications,
> > > > > > > i.e. if it has a "big-endian" property, or if the kernel was
> > > > > > > compiled for BE *and* the device has a "native-endian" property.
> > > > > > >
> > > > > > > Provide inline helper for the users.
> > > > > >
> > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > >
> > > > > Thank you, Greg.
> > > > >
> > > > > Bart, would it be still possible to take this into next?
> > > > > I would like to have at least this patch applied (with the first user)
> > > > > to allow conversion of others (I have some more users of new API).
> > > >
> > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > (I have something against tty already and perhaps something else, let's
> > > >  see.)
> > >
> > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > time as I was OoO this week.
> >
> > Greg, will you take this patch through your tree and provide me with
> > an immutable tag for this cycle?
> 
> Sure, let me catch up with patches after I return from Plumbers next
> week.

Hope Plumbers went well!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Greg Kroah-Hartman]

On Thu, Dec 07, 2023 at 04:19:22PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> > On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > > > > > > > Some users want to use the struct device pointer to see if the
> > > > > > > > device is big endian in terms of Open Firmware specifications,
> > > > > > > > i.e. if it has a "big-endian" property, or if the kernel was
> > > > > > > > compiled for BE *and* the device has a "native-endian" property.
> > > > > > > >
> > > > > > > > Provide inline helper for the users.
> > > > > > >
> > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > >
> > > > > > Thank you, Greg.
> > > > > >
> > > > > > Bart, would it be still possible to take this into next?
> > > > > > I would like to have at least this patch applied (with the first user)
> > > > > > to allow conversion of others (I have some more users of new API).
> > > > >
> > > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > > (I have something against tty already and perhaps something else, let's
> > > > >  see.)
> > > >
> > > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > > time as I was OoO this week.
> > >
> > > Greg, will you take this patch through your tree and provide me with
> > > an immutable tag for this cycle?
> > 
> > Sure, let me catch up with patches after I return from Plumbers next
> > week.
> 
> Hope Plumbers went well!

Sorry for the delay, immutable tag can be found at:
	git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_is_big_endian-6.8-rc1
for anyone to pull from now.

thanks,

greg k-h

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Andy Shevchenko]

On Fri, Dec 15, 2023 at 03:49:38PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Dec 07, 2023 at 04:19:22PM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> > > On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > > > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:

...

> > > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > > >
> > > > > > > Thank you, Greg.
> > > > > > >
> > > > > > > Bart, would it be still possible to take this into next?
> > > > > > > I would like to have at least this patch applied (with the first user)
> > > > > > > to allow conversion of others (I have some more users of new API).
> > > > > >
> > > > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > > > (I have something against tty already and perhaps something else, let's
> > > > > >  see.)
> > > > >
> > > > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > > > time as I was OoO this week.
> > > >
> > > > Greg, will you take this patch through your tree and provide me with
> > > > an immutable tag for this cycle?
> > > 
> > > Sure, let me catch up with patches after I return from Plumbers next
> > > week.
> > 
> > Hope Plumbers went well!
> 
> Sorry for the delay, immutable tag can be found at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_is_big_endian-6.8-rc1
> for anyone to pull from now.

No problem and thank you!

Bart, can you pull that? Or should I to my tree and then push with other
GPIO patches?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Bartosz Golaszewski]

On Fri, Dec 15, 2023 at 4:11 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Fri, Dec 15, 2023 at 03:49:38PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Dec 07, 2023 at 04:19:22PM +0200, Andy Shevchenko wrote:
> > > On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> > > > On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > > > > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
>
> ...
>
> > > > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > > > >
> > > > > > > > Thank you, Greg.
> > > > > > > >
> > > > > > > > Bart, would it be still possible to take this into next?
> > > > > > > > I would like to have at least this patch applied (with the first user)
> > > > > > > > to allow conversion of others (I have some more users of new API).
> > > > > > >
> > > > > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > > > > (I have something against tty already and perhaps something else, let's
> > > > > > >  see.)
> > > > > >
> > > > > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > > > > time as I was OoO this week.
> > > > >
> > > > > Greg, will you take this patch through your tree and provide me with
> > > > > an immutable tag for this cycle?
> > > >
> > > > Sure, let me catch up with patches after I return from Plumbers next
> > > > week.
> > >
> > > Hope Plumbers went well!
> >
> > Sorry for the delay, immutable tag can be found at:
> >       git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_is_big_endian-6.8-rc1
> > for anyone to pull from now.
>
> No problem and thank you!
>
> Bart, can you pull that? Or should I to my tree and then push with other
> GPIO patches?
>

Ugh, this is rebased on top of 6.7-rc3...

My tree is based on rc1, if I pull it, then it'll be a mess.

Andy: How badly do you want it in v6.8? Can this wait until after the
merge window?

Bart

> --
> With Best Regards,
> Andy Shevchenko
>
>

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Andy Shevchenko]

On Mon, Dec 18, 2023 at 11:35:04AM +0100, Bartosz Golaszewski wrote:
> On Fri, Dec 15, 2023 at 4:11 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Dec 15, 2023 at 03:49:38PM +0100, Greg Kroah-Hartman wrote:
> > > On Thu, Dec 07, 2023 at 04:19:22PM +0200, Andy Shevchenko wrote:
> > > > On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> > > > > On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > > > > > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > > > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:

...

> > > > > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > > > > >
> > > > > > > > > Thank you, Greg.
> > > > > > > > >
> > > > > > > > > Bart, would it be still possible to take this into next?
> > > > > > > > > I would like to have at least this patch applied (with the first user)
> > > > > > > > > to allow conversion of others (I have some more users of new API).
> > > > > > > >
> > > > > > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > > > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > > > > > (I have something against tty already and perhaps something else, let's
> > > > > > > >  see.)
> > > > > > >
> > > > > > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > > > > > time as I was OoO this week.
> > > > > >
> > > > > > Greg, will you take this patch through your tree and provide me with
> > > > > > an immutable tag for this cycle?
> > > > >
> > > > > Sure, let me catch up with patches after I return from Plumbers next
> > > > > week.
> > > >
> > > > Hope Plumbers went well!
> > >
> > > Sorry for the delay, immutable tag can be found at:
> > >       git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_is_big_endian-6.8-rc1
> > > for anyone to pull from now.
> >
> > No problem and thank you!
> >
> > Bart, can you pull that? Or should I to my tree and then push with other
> > GPIO patches?
> 
> Ugh, this is rebased on top of 6.7-rc3...
> 
> My tree is based on rc1, if I pull it, then it'll be a mess.

But v6.7-rc3 is something that is already in the upstream.
I don't see how it can be more "mess" with this. Whatever...

> Andy: How badly do you want it in v6.8? Can this wait until after the
> merge window?

I waited for a cycle already with this...

OTOH GPIO part is not anyhow critical from the semantic point of view.
Since the main patch is in Greg's tree I'll survive with GPIO stuff
going next cycle.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Bartosz Golaszewski]

On Mon, Dec 18, 2023 at 11:56 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Dec 18, 2023 at 11:35:04AM +0100, Bartosz Golaszewski wrote:
> > On Fri, Dec 15, 2023 at 4:11 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Fri, Dec 15, 2023 at 03:49:38PM +0100, Greg Kroah-Hartman wrote:
> > > > On Thu, Dec 07, 2023 at 04:19:22PM +0200, Andy Shevchenko wrote:
> > > > > On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> > > > > > On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > > > > > > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > > > > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > > > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
>
> ...
>
> > > > > > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > > > > > >
> > > > > > > > > > Thank you, Greg.
> > > > > > > > > >
> > > > > > > > > > Bart, would it be still possible to take this into next?
> > > > > > > > > > I would like to have at least this patch applied (with the first user)
> > > > > > > > > > to allow conversion of others (I have some more users of new API).
> > > > > > > > >
> > > > > > > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > > > > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > > > > > > (I have something against tty already and perhaps something else, let's
> > > > > > > > >  see.)
> > > > > > > >
> > > > > > > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > > > > > > time as I was OoO this week.
> > > > > > >
> > > > > > > Greg, will you take this patch through your tree and provide me with
> > > > > > > an immutable tag for this cycle?
> > > > > >
> > > > > > Sure, let me catch up with patches after I return from Plumbers next
> > > > > > week.
> > > > >
> > > > > Hope Plumbers went well!
> > > >
> > > > Sorry for the delay, immutable tag can be found at:
> > > >       git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_is_big_endian-6.8-rc1
> > > > for anyone to pull from now.
> > >
> > > No problem and thank you!
> > >
> > > Bart, can you pull that? Or should I to my tree and then push with other
> > > GPIO patches?
> >
> > Ugh, this is rebased on top of 6.7-rc3...
> >
> > My tree is based on rc1, if I pull it, then it'll be a mess.
>
> But v6.7-rc3 is something that is already in the upstream.
> I don't see how it can be more "mess" with this. Whatever...
>

My for-next branch is based on v6.7-rc1 (as it should IIUC) and if I
now pull Greg's tag, I will be sending rc1-rc3 stuff to Linus Torvalds
in addition to the GPIO changes for v6.8. I bet he will not appreciate
it.

Greg: Is it too late to have this rebased on top of v6.7-rc1 instead?

Bartosz

> > Andy: How badly do you want it in v6.8? Can this wait until after the
> > merge window?
>
> I waited for a cycle already with this...
>
> OTOH GPIO part is not anyhow critical from the semantic point of view.
> Since the main patch is in Greg's tree I'll survive with GPIO stuff
> going next cycle.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Greg Kroah-Hartman]

On Mon, Dec 18, 2023 at 12:05:54PM +0100, Bartosz Golaszewski wrote:
> On Mon, Dec 18, 2023 at 11:56 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Mon, Dec 18, 2023 at 11:35:04AM +0100, Bartosz Golaszewski wrote:
> > > On Fri, Dec 15, 2023 at 4:11 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Fri, Dec 15, 2023 at 03:49:38PM +0100, Greg Kroah-Hartman wrote:
> > > > > On Thu, Dec 07, 2023 at 04:19:22PM +0200, Andy Shevchenko wrote:
> > > > > > On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> > > > > > > On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > > > > > > > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > > > > > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > > > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > > > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > > > > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > > > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> >
> > ...
> >
> > > > > > > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > > > > > > >
> > > > > > > > > > > Thank you, Greg.
> > > > > > > > > > >
> > > > > > > > > > > Bart, would it be still possible to take this into next?
> > > > > > > > > > > I would like to have at least this patch applied (with the first user)
> > > > > > > > > > > to allow conversion of others (I have some more users of new API).
> > > > > > > > > >
> > > > > > > > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > > > > > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > > > > > > > (I have something against tty already and perhaps something else, let's
> > > > > > > > > >  see.)
> > > > > > > > >
> > > > > > > > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > > > > > > > time as I was OoO this week.
> > > > > > > >
> > > > > > > > Greg, will you take this patch through your tree and provide me with
> > > > > > > > an immutable tag for this cycle?
> > > > > > >
> > > > > > > Sure, let me catch up with patches after I return from Plumbers next
> > > > > > > week.
> > > > > >
> > > > > > Hope Plumbers went well!
> > > > >
> > > > > Sorry for the delay, immutable tag can be found at:
> > > > >       git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_is_big_endian-6.8-rc1
> > > > > for anyone to pull from now.
> > > >
> > > > No problem and thank you!
> > > >
> > > > Bart, can you pull that? Or should I to my tree and then push with other
> > > > GPIO patches?
> > >
> > > Ugh, this is rebased on top of 6.7-rc3...
> > >
> > > My tree is based on rc1, if I pull it, then it'll be a mess.
> >
> > But v6.7-rc3 is something that is already in the upstream.
> > I don't see how it can be more "mess" with this. Whatever...
> >
> 
> My for-next branch is based on v6.7-rc1 (as it should IIUC) and if I
> now pull Greg's tag, I will be sending rc1-rc3 stuff to Linus Torvalds
> in addition to the GPIO changes for v6.8. I bet he will not appreciate
> it.

No, you will not be sending him -rc1-rc3 stuff at all, that's not how
git works.

Try it yourself and see.  Git does a "what's the changesets that are
in this pull request and not already in mine" when determining this.
You can see it when doing a 'git request-pull', it will only show you
the diff of what will be sent.

Also look at the 'git merge-base' output, it will show the point where
things will start to be sent, and that will not have all of the -rc1
through -rc3 changes in it.

> Greg: Is it too late to have this rebased on top of v6.7-rc1 instead?

Sorry, but yes.  But don't worry, again, git can handle all of this
easily!  Try it locally and see.  Don't fear the 'fast-forward' :)

thanks,

greg k-h

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Bartosz Golaszewski]

On Mon, Dec 18, 2023 at 12:18 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Dec 18, 2023 at 12:05:54PM +0100, Bartosz Golaszewski wrote:
> > On Mon, Dec 18, 2023 at 11:56 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > On Mon, Dec 18, 2023 at 11:35:04AM +0100, Bartosz Golaszewski wrote:
> > > > On Fri, Dec 15, 2023 at 4:11 PM Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > On Fri, Dec 15, 2023 at 03:49:38PM +0100, Greg Kroah-Hartman wrote:
> > > > > > On Thu, Dec 07, 2023 at 04:19:22PM +0200, Andy Shevchenko wrote:
> > > > > > > On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> > > > > > > > On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > > > > > > > > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > > > > > > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > > > > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > > > > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > > > > > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > > > > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > >
> > > ...
> > >
> > > > > > > > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > > > > > > > >
> > > > > > > > > > > > Thank you, Greg.
> > > > > > > > > > > >
> > > > > > > > > > > > Bart, would it be still possible to take this into next?
> > > > > > > > > > > > I would like to have at least this patch applied (with the first user)
> > > > > > > > > > > > to allow conversion of others (I have some more users of new API).
> > > > > > > > > > >
> > > > > > > > > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > > > > > > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > > > > > > > > (I have something against tty already and perhaps something else, let's
> > > > > > > > > > >  see.)
> > > > > > > > > >
> > > > > > > > > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > > > > > > > > time as I was OoO this week.
> > > > > > > > >
> > > > > > > > > Greg, will you take this patch through your tree and provide me with
> > > > > > > > > an immutable tag for this cycle?
> > > > > > > >
> > > > > > > > Sure, let me catch up with patches after I return from Plumbers next
> > > > > > > > week.
> > > > > > >
> > > > > > > Hope Plumbers went well!
> > > > > >
> > > > > > Sorry for the delay, immutable tag can be found at:
> > > > > >       git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_is_big_endian-6.8-rc1
> > > > > > for anyone to pull from now.
> > > > >
> > > > > No problem and thank you!
> > > > >
> > > > > Bart, can you pull that? Or should I to my tree and then push with other
> > > > > GPIO patches?
> > > >
> > > > Ugh, this is rebased on top of 6.7-rc3...
> > > >
> > > > My tree is based on rc1, if I pull it, then it'll be a mess.
> > >
> > > But v6.7-rc3 is something that is already in the upstream.
> > > I don't see how it can be more "mess" with this. Whatever...
> > >
> >
> > My for-next branch is based on v6.7-rc1 (as it should IIUC) and if I
> > now pull Greg's tag, I will be sending rc1-rc3 stuff to Linus Torvalds
> > in addition to the GPIO changes for v6.8. I bet he will not appreciate
> > it.
>
> No, you will not be sending him -rc1-rc3 stuff at all, that's not how
> git works.
>
> Try it yourself and see.  Git does a "what's the changesets that are
> in this pull request and not already in mine" when determining this.
> You can see it when doing a 'git request-pull', it will only show you
> the diff of what will be sent.
>
> Also look at the 'git merge-base' output, it will show the point where
> things will start to be sent, and that will not have all of the -rc1
> through -rc3 changes in it.
>
> > Greg: Is it too late to have this rebased on top of v6.7-rc1 instead?
>
> Sorry, but yes.  But don't worry, again, git can handle all of this
> easily!  Try it locally and see.  Don't fear the 'fast-forward' :)
>

Sorry for the noise. I did try it locally and noticed that a bunch of
commits that were merged before rc3 moved "before it" in git log and
figured this is what the PR would look like. However the PR is correct
and I should have generated it before sending the email.

Thanks for a lesson in git.
Bartosz

> thanks,
>
> greg k-h
>

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Andy Shevchenko]

On Mon, Dec 18, 2023 at 01:38:18PM +0100, Bartosz Golaszewski wrote:
> On Mon, Dec 18, 2023 at 12:18 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Mon, Dec 18, 2023 at 12:05:54PM +0100, Bartosz Golaszewski wrote:
> > > On Mon, Dec 18, 2023 at 11:56 AM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Mon, Dec 18, 2023 at 11:35:04AM +0100, Bartosz Golaszewski wrote:
> > > > > On Fri, Dec 15, 2023 at 4:11 PM Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:

...

> > > > > Ugh, this is rebased on top of 6.7-rc3...
> > > > >
> > > > > My tree is based on rc1, if I pull it, then it'll be a mess.
> > > >
> > > > But v6.7-rc3 is something that is already in the upstream.
> > > > I don't see how it can be more "mess" with this. Whatever...
> > >
> > > My for-next branch is based on v6.7-rc1 (as it should IIUC) and if I
> > > now pull Greg's tag, I will be sending rc1-rc3 stuff to Linus Torvalds
> > > in addition to the GPIO changes for v6.8. I bet he will not appreciate
> > > it.
> >
> > No, you will not be sending him -rc1-rc3 stuff at all, that's not how
> > git works.
> >
> > Try it yourself and see.  Git does a "what's the changesets that are
> > in this pull request and not already in mine" when determining this.
> > You can see it when doing a 'git request-pull', it will only show you
> > the diff of what will be sent.
> >
> > Also look at the 'git merge-base' output, it will show the point where
> > things will start to be sent, and that will not have all of the -rc1
> > through -rc3 changes in it.
> >
> > > Greg: Is it too late to have this rebased on top of v6.7-rc1 instead?
> >
> > Sorry, but yes.  But don't worry, again, git can handle all of this
> > easily!  Try it locally and see.  Don't fear the 'fast-forward' :)
> 
> Sorry for the noise. I did try it locally and noticed that a bunch of
> commits that were merged before rc3 moved "before it" in git log and
> figured this is what the PR would look like. However the PR is correct
> and I should have generated it before sending the email.

Right.

What Linus can rant on is when one rebases his stuff on newer rcX,
the merges on contrary are pretty much okay as long as they are
justified.

> Thanks for a lesson in git.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Greg Kroah-Hartman]

On Mon, Dec 18, 2023 at 11:35:04AM +0100, Bartosz Golaszewski wrote:
> On Fri, Dec 15, 2023 at 4:11 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Fri, Dec 15, 2023 at 03:49:38PM +0100, Greg Kroah-Hartman wrote:
> > > On Thu, Dec 07, 2023 at 04:19:22PM +0200, Andy Shevchenko wrote:
> > > > On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> > > > > On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > > > > > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > > > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> >
> > ...
> >
> > > > > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > > > > >
> > > > > > > > > Thank you, Greg.
> > > > > > > > >
> > > > > > > > > Bart, would it be still possible to take this into next?
> > > > > > > > > I would like to have at least this patch applied (with the first user)
> > > > > > > > > to allow conversion of others (I have some more users of new API).
> > > > > > > >
> > > > > > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > > > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > > > > > (I have something against tty already and perhaps something else, let's
> > > > > > > >  see.)
> > > > > > >
> > > > > > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > > > > > time as I was OoO this week.
> > > > > >
> > > > > > Greg, will you take this patch through your tree and provide me with
> > > > > > an immutable tag for this cycle?
> > > > >
> > > > > Sure, let me catch up with patches after I return from Plumbers next
> > > > > week.
> > > >
> > > > Hope Plumbers went well!
> > >
> > > Sorry for the delay, immutable tag can be found at:
> > >       git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_is_big_endian-6.8-rc1
> > > for anyone to pull from now.
> >
> > No problem and thank you!
> >
> > Bart, can you pull that? Or should I to my tree and then push with other
> > GPIO patches?
> >
> 
> Ugh, this is rebased on top of 6.7-rc3...
> 
> My tree is based on rc1, if I pull it, then it'll be a mess.

What would make it a "mess"?  It's all upstream already, taking a merge
from a point further in time will work just fine, git is nice :)

thanks,

greg k-h

[PATCH v1 2/3] gpio: mmio: Make use of device properties

[Andy Shevchenko]

Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-mmio.c | 25 +++++++------------------
 1 file changed, 7 insertions(+), 18 deletions(-)

diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
index 3ff0ea1e351c..66308b165a0d 100644
--- a/drivers/gpio/gpio-mmio.c
+++ b/drivers/gpio/gpio-mmio.c
@@ -58,7 +58,6 @@ o        `                     ~~~~\___/~~~~    ` controller in FPGA is ,.`
 #include <linux/platform_device.h>
 #include <linux/property.h>
 #include <linux/mod_devicetable.h>
-#include <linux/of.h>
 
 #include "gpiolib.h"
 
@@ -688,7 +687,6 @@ static void __iomem *bgpio_map(struct platform_device *pdev,
 	return devm_ioremap_resource(&pdev->dev, r);
 }
 
-#ifdef CONFIG_OF
 static const struct of_device_id bgpio_of_match[] = {
 	{ .compatible = "brcm,bcm6345-gpio" },
 	{ .compatible = "wd,mbl-gpio" },
@@ -697,36 +695,27 @@ static const struct of_device_id bgpio_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, bgpio_of_match);
 
-static struct bgpio_pdata *bgpio_parse_dt(struct platform_device *pdev,
-					  unsigned long *flags)
+static struct bgpio_pdata *bgpio_parse_fw(struct device *dev, unsigned long *flags)
 {
 	struct bgpio_pdata *pdata;
 
-	if (!pdev->dev.of_node)
+	if (!dev_fwnode(dev))
 		return NULL;
 
-	pdata = devm_kzalloc(&pdev->dev, sizeof(struct bgpio_pdata),
-			     GFP_KERNEL);
+	pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
 	if (!pdata)
 		return ERR_PTR(-ENOMEM);
 
 	pdata->base = -1;
 
-	if (of_device_is_big_endian(pdev->dev.of_node))
+	if (device_is_big_endian(dev))
 		*flags |= BGPIOF_BIG_ENDIAN_BYTE_ORDER;
 
-	if (of_property_read_bool(pdev->dev.of_node, "no-output"))
+	if (device_property_read_bool(dev, "no-output"))
 		*flags |= BGPIOF_NO_OUTPUT;
 
 	return pdata;
 }
-#else
-static struct bgpio_pdata *bgpio_parse_dt(struct platform_device *pdev,
-					  unsigned long *flags)
-{
-	return NULL;
-}
-#endif /* CONFIG_OF */
 
 static int bgpio_pdev_probe(struct platform_device *pdev)
 {
@@ -743,7 +732,7 @@ static int bgpio_pdev_probe(struct platform_device *pdev)
 	struct gpio_chip *gc;
 	struct bgpio_pdata *pdata;
 
-	pdata = bgpio_parse_dt(pdev, &flags);
+	pdata = bgpio_parse_fw(dev, &flags);
 	if (IS_ERR(pdata))
 		return PTR_ERR(pdata);
 
@@ -814,7 +803,7 @@ MODULE_DEVICE_TABLE(platform, bgpio_id_table);
 static struct platform_driver bgpio_driver = {
 	.driver = {
 		.name = "basic-mmio-gpio",
-		.of_match_table = of_match_ptr(bgpio_of_match),
+		.of_match_table = bgpio_of_match,
 	},
 	.id_table = bgpio_id_table,
 	.probe = bgpio_pdev_probe,
-- 
2.40.0.1.gaa8946217a0b

[PATCH v1 3/3] gpio: mmio: Clean up headers

[Andy Shevchenko]

There is a few things done:
- include only the headers we are direct user of
- add missing headers
- group generic headers and subsystem headers
- sort each group alphabetically

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-mmio.c | 28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)

diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
index 66308b165a0d..71e1af7c2184 100644
--- a/drivers/gpio/gpio-mmio.c
+++ b/drivers/gpio/gpio-mmio.c
@@ -40,24 +40,22 @@ o        `                     ~~~~\___/~~~~    ` controller in FPGA is ,.`
  *               `.......````.```
  */
 
-#include <linux/init.h>
-#include <linux/err.h>
-#include <linux/bug.h>
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/spinlock.h>
-#include <linux/compiler.h>
-#include <linux/types.h>
-#include <linux/errno.h>
-#include <linux/log2.h>
-#include <linux/ioport.h>
-#include <linux/io.h>
-#include <linux/gpio/driver.h>
-#include <linux/slab.h>
 #include <linux/bitops.h>
+#include <linux/compiler.h>
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/io.h>
+#include <linux/ioport.h>
+#include <linux/log2.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/property.h>
-#include <linux/mod_devicetable.h>
+#include <linux/slab.h>
+#include <linux/spinlock.h>
+#include <linux/types.h>
+
+#include <linux/gpio/driver.h>
 
 #include "gpiolib.h"
 
-- 
2.40.0.1.gaa8946217a0b

Re: [PATCH v1 0/3] gpio: mmio: Make driver agnostic

[Linus Walleij]

On Wed, Oct 25, 2023 at 8:50 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Driver uses so far some OF APIs when generic fwnode ones can be used.
> Replace these APIs accordingly. Note, this will help to clean up OF
> headers even more.

Clean, elegant and does exactly what we want.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH v1 0/3] gpio: mmio: Make driver agnostic

[Bartosz Golaszewski]

On Wed, Oct 25, 2023 at 8:50 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Driver uses so far some OF APIs when generic fwnode ones can be used.
> Replace these APIs accordingly. Note, this will help to clean up OF
> headers even more.
>
> Andy Shevchenko (3):
>   device property: Implement device_is_big_endian()
>   gpio: mmio: Make use of device properties
>   gpio: mmio: Clean up headers
>
>  drivers/gpio/gpio-mmio.c | 53 +++++++++++++++-------------------------
>  include/linux/property.h | 26 ++++++++++++++++++++
>  2 files changed, 46 insertions(+), 33 deletions(-)
>
> --
> 2.40.0.1.gaa8946217a0b
>

Applied patches 2 and 3.

Bart

Re: [PATCH v1 0/3] gpio: mmio: Make driver agnostic

[Andy Shevchenko]

On Mon, Dec 18, 2023 at 03:35:28PM +0200, Andy Shevchenko wrote:
> On Mon, Dec 18, 2023 at 01:43:40PM +0100, Bartosz Golaszewski wrote:

...

> Thank you! I guess you forgot to add --sign-off to the `git merge ...`

Sorry, it's --signoff.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 0/3] gpio: mmio: Make driver agnostic

[Bartosz Golaszewski]

On Mon, Dec 18, 2023 at 2:36 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Dec 18, 2023 at 03:35:28PM +0200, Andy Shevchenko wrote:
> > On Mon, Dec 18, 2023 at 01:43:40PM +0100, Bartosz Golaszewski wrote:
>
> ...
>
> > Thank you! I guess you forgot to add --sign-off to the `git merge ...`
>
> Sorry, it's --signoff.
>

I never sign-off on merges though, is it mandatory? Probably not as
there are no warnings from next like for regular commits about missing
sign-offs.

Bart

> --
> With Best Regards,
> Andy Shevchenko
>
>

Re: [PATCH v1 0/3] gpio: mmio: Make driver agnostic

[Andy Shevchenko]

On Mon, Dec 18, 2023 at 02:37:48PM +0100, Bartosz Golaszewski wrote:
> On Mon, Dec 18, 2023 at 2:36 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Dec 18, 2023 at 03:35:28PM +0200, Andy Shevchenko wrote:
> > > On Mon, Dec 18, 2023 at 01:43:40PM +0100, Bartosz Golaszewski wrote:

...

> > > Thank you! I guess you forgot to add --sign-off to the `git merge ...`
> >
> > Sorry, it's --signoff.
> 
> I never sign-off on merges though, is it mandatory? Probably not as
> there are no warnings from next like for regular commits about missing
> sign-offs.

No idea. I do it as it is harmless, and makes commit more robust.

For me it's fine, but I leave for me to exclaim later "Yay, had told ya!" :-)

-- 
With Best Regards,
Andy Shevchenko