* [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias
@ 2023-10-30 14:14 Andy Shevchenko
2023-10-30 21:35 ` Raag Jadav
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andy Shevchenko @ 2023-10-30 14:14 UTC (permalink / raw)
To: Andy Shevchenko, Raag Jadav, linux-gpio, linux-kernel
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij
Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
Enable it for configuring pin.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c
index 40dd60c9e526..007bca1cf224 100644
--- a/drivers/pinctrl/intel/pinctrl-tangier.c
+++ b/drivers/pinctrl/intel/pinctrl-tangier.c
@@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
case 2000:
term = BUFCFG_PUPD_VAL_2K;
break;
+ case 910:
+ term = BUFCFG_PUPD_VAL_910;
+ break;
default:
return -EINVAL;
}
@@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
case 2000:
term = BUFCFG_PUPD_VAL_2K;
break;
+ case 910:
+ term = BUFCFG_PUPD_VAL_910;
+ break;
default:
return -EINVAL;
}
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias
2023-10-30 14:14 [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias Andy Shevchenko
@ 2023-10-30 21:35 ` Raag Jadav
2023-10-31 13:59 ` Raag Jadav
2023-11-01 6:33 ` Mika Westerberg
2023-11-02 7:31 ` Linus Walleij
2 siblings, 1 reply; 6+ messages in thread
From: Raag Jadav @ 2023-10-30 21:35 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-kernel, Mika Westerberg, Andy Shevchenko,
Linus Walleij
On Mon, Oct 30, 2023 at 04:14:04PM +0200, Andy Shevchenko wrote:
> Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
>
> Enable it for configuring pin.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c
> index 40dd60c9e526..007bca1cf224 100644
> --- a/drivers/pinctrl/intel/pinctrl-tangier.c
> +++ b/drivers/pinctrl/intel/pinctrl-tangier.c
> @@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
> case 2000:
> term = BUFCFG_PUPD_VAL_2K;
> break;
> + case 910:
> + term = BUFCFG_PUPD_VAL_910;
> + break;
> default:
> return -EINVAL;
> }
> @@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
> case 2000:
> term = BUFCFG_PUPD_VAL_2K;
> break;
> + case 910:
> + term = BUFCFG_PUPD_VAL_910;
> + break;
> default:
> return -EINVAL;
> }
Ah, I failed to notice this was already preset in the getter.
Looks good,
Raag
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias
2023-10-30 21:35 ` Raag Jadav
@ 2023-10-31 13:59 ` Raag Jadav
0 siblings, 0 replies; 6+ messages in thread
From: Raag Jadav @ 2023-10-31 13:59 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-kernel, Mika Westerberg, Andy Shevchenko,
Linus Walleij
On Mon, Oct 30, 2023 at 11:35:42PM +0200, Raag Jadav wrote:
> On Mon, Oct 30, 2023 at 04:14:04PM +0200, Andy Shevchenko wrote:
> > Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
> >
> > Enable it for configuring pin.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c
> > index 40dd60c9e526..007bca1cf224 100644
> > --- a/drivers/pinctrl/intel/pinctrl-tangier.c
> > +++ b/drivers/pinctrl/intel/pinctrl-tangier.c
> > @@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
> > case 2000:
> > term = BUFCFG_PUPD_VAL_2K;
> > break;
> > + case 910:
> > + term = BUFCFG_PUPD_VAL_910;
> > + break;
> > default:
> > return -EINVAL;
> > }
> > @@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
> > case 2000:
> > term = BUFCFG_PUPD_VAL_2K;
> > break;
> > + case 910:
> > + term = BUFCFG_PUPD_VAL_910;
> > + break;
> > default:
> > return -EINVAL;
> > }
>
> Ah, I failed to notice this was already present in the getter.
>
> Looks good,
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias
2023-10-30 14:14 [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias Andy Shevchenko
2023-10-30 21:35 ` Raag Jadav
@ 2023-11-01 6:33 ` Mika Westerberg
2023-11-02 7:31 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Mika Westerberg @ 2023-11-01 6:33 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Raag Jadav, linux-gpio, linux-kernel, Andy Shevchenko,
Linus Walleij
On Mon, Oct 30, 2023 at 04:14:04PM +0200, Andy Shevchenko wrote:
> Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
>
> Enable it for configuring pin.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias
2023-10-30 14:14 [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias Andy Shevchenko
2023-10-30 21:35 ` Raag Jadav
2023-11-01 6:33 ` Mika Westerberg
@ 2023-11-02 7:31 ` Linus Walleij
2023-11-13 11:51 ` Andy Shevchenko
2 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2023-11-02 7:31 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Raag Jadav, linux-gpio, linux-kernel, Mika Westerberg,
Andy Shevchenko
On Mon, Oct 30, 2023 at 3:14 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
>
> Enable it for configuring pin.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Neat,
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias
2023-11-02 7:31 ` Linus Walleij
@ 2023-11-13 11:51 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2023-11-13 11:51 UTC (permalink / raw)
To: Linus Walleij; +Cc: Raag Jadav, linux-gpio, linux-kernel, Mika Westerberg
On Thu, Nov 02, 2023 at 08:31:22AM +0100, Linus Walleij wrote:
> On Mon, Oct 30, 2023 at 3:14 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
> >
> > Enable it for configuring pin.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Neat,
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-13 11:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-30 14:14 [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias Andy Shevchenko
2023-10-30 21:35 ` Raag Jadav
2023-10-31 13:59 ` Raag Jadav
2023-11-01 6:33 ` Mika Westerberg
2023-11-02 7:31 ` Linus Walleij
2023-11-13 11:51 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).