From: Andy Shevchenko <andy@kernel.org>
To: Andrew Davis <afd@ti.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: as3722: Use devm_gpiochip_add_data() to simplify remove path
Date: Fri, 17 Nov 2023 23:16:12 +0200 [thread overview]
Message-ID: <ZVfYHByiEmNzRtfl@smile.fi.intel.com> (raw)
In-Reply-To: <20231116223045.274211-1-afd@ti.com>
On Thu, Nov 16, 2023 at 04:30:45PM -0600, Andrew Davis wrote:
> Use devm version of gpiochip add function to handle removal for us.
Seems reasonable. Consider also to convert to dev_err_probe()
(in a separate change).
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-17 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 22:30 [PATCH] pinctrl: as3722: Use devm_gpiochip_add_data() to simplify remove path Andrew Davis
2023-11-17 21:16 ` Andy Shevchenko [this message]
2023-11-20 14:01 ` Andy Shevchenko
2023-11-24 9:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVfYHByiEmNzRtfl@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=afd@ti.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).