From: Andy Shevchenko <andy@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Tzuyi Chang <tychang@realtek.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs.
Date: Fri, 24 Nov 2023 13:31:29 +0200 [thread overview]
Message-ID: <ZWCJkddstjpXTtQx@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdZTFWnH1iwLCeJy02OXJAgTSSVTomzDNEQ3ebWocwkgPA@mail.gmail.com>
On Fri, Nov 24, 2023 at 10:38:42AM +0100, Linus Walleij wrote:
> On Thu, Nov 16, 2023 at 12:14 PM Tzuyi Chang <tychang@realtek.com> wrote:
>
> > This driver enables configuration of GPIO direction, GPIO values, GPIO
> > debounce settings and handles GPIO interrupts.
> >
> > Signed-off-by: Tzuyi Chang <tychang@realtek.com>
>
> Apart from the missing kerneldoc that the autobuilder is complaining about
> this looks good to me. If you fix the kerneldoc:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I think I might have comments in the future.
I haven't looked at the series due to noticing LKP complains.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-24 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 11:14 [PATCH v2 0/2] Add gpio driver support for Realtek DHC SoCs Tzuyi Chang
2023-11-16 11:14 ` [PATCH v2 1/2] dt-bindings: gpio: realtek: Add realtek,rtd-gpio Tzuyi Chang
2023-11-16 12:01 ` Krzysztof Kozlowski
2023-11-21 7:07 ` TY_Chang[張子逸]
2023-11-16 11:14 ` [PATCH v2 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs Tzuyi Chang
2023-11-16 22:56 ` kernel test robot
2023-11-24 9:38 ` Linus Walleij
2023-11-24 11:31 ` Andy Shevchenko [this message]
2023-12-01 1:50 ` TY_Chang[張子逸]
2023-12-01 1:44 ` TY_Chang[張子逸]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWCJkddstjpXTtQx@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tychang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).