From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 01/10] gpiolib: provide gpiochip_dup_line_label()
Date: Thu, 30 Nov 2023 18:27:14 +0200 [thread overview]
Message-ID: <ZWi34tkzNsvkCQqi@smile.fi.intel.com> (raw)
In-Reply-To: <20231130134630.18198-2-brgl@bgdev.pl>
On Thu, Nov 30, 2023 at 02:46:21PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> gpiochip_is_requested() not only has a misleading name but it returns
> a pointer to a string that is freed when the descriptor is released.
>
> Provide a new helper meant to replace it, which returns a copy of the
> label string instead.
...
> + * Must not be called from atomic context.
Put the respective lockdep annotation.
...
> + char *cpy;
So, why not naming it fully, i.e. "copy"?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-30 16:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 13:46 [PATCH v2 00/10] gpio/pinctrl: replace gpiochip_is_requested() with a safer interface Bartosz Golaszewski
2023-11-30 13:46 ` [PATCH v2 01/10] gpiolib: provide gpiochip_dup_line_label() Bartosz Golaszewski
2023-11-30 16:27 ` Andy Shevchenko [this message]
2023-11-30 17:48 ` Bartosz Golaszewski
2023-11-30 18:00 ` Andy Shevchenko
2023-11-30 19:40 ` Bartosz Golaszewski
2023-12-01 10:54 ` Bartosz Golaszewski
2023-11-30 13:46 ` [PATCH v2 02/10] gpio: wm831x: use gpiochip_dup_line_label() Bartosz Golaszewski
2023-11-30 13:46 ` [PATCH v2 03/10] gpio: wm8994: " Bartosz Golaszewski
2023-11-30 16:29 ` Andy Shevchenko
2023-11-30 13:46 ` [PATCH v2 04/10] gpio: stmpe: " Bartosz Golaszewski
2023-11-30 13:46 ` [PATCH v2 05/10] pinctrl: abx500: " Bartosz Golaszewski
2023-11-30 13:46 ` [PATCH v2 06/10] pinctrl: nomadik: " Bartosz Golaszewski
2023-11-30 13:46 ` [PATCH v2 07/10] pinctrl: baytrail: " Bartosz Golaszewski
2023-11-30 16:36 ` Andy Shevchenko
2023-11-30 17:39 ` Bartosz Golaszewski
2023-11-30 13:46 ` [PATCH v2 08/10] pinctrl: sppctl: " Bartosz Golaszewski
2023-11-30 16:37 ` Andy Shevchenko
2023-11-30 17:43 ` Bartosz Golaszewski
2023-11-30 13:46 ` [PATCH v2 09/10] gpiolib: use gpiochip_dup_line_label() in for_each helpers Bartosz Golaszewski
2023-11-30 16:40 ` Andy Shevchenko
2023-11-30 17:42 ` Bartosz Golaszewski
2023-11-30 17:54 ` Andy Shevchenko
2023-11-30 13:46 ` [PATCH v2 10/10] gpiolib: remove gpiochip_is_requested() Bartosz Golaszewski
2023-11-30 16:46 ` Andy Shevchenko
2023-11-30 17:46 ` Bartosz Golaszewski
2023-11-30 18:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWi34tkzNsvkCQqi@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).