From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kkp5xwOt" Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF9C0115; Thu, 14 Dec 2023 06:47:39 -0800 (PST) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5c701bd9a3cso2405347a12.0; Thu, 14 Dec 2023 06:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702565259; x=1703170059; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sof1gkerYbku5v+b3jW5lmXu1VdUZ0QZgBhWQoXBGdc=; b=Kkp5xwOtxrYv10OSa5shZ21cAy928zSXM36Qw1ckljhPbPIGgnp5VIFhO04gf2ms49 lwMhceJJEhjJesldb717PFdsOWpIMPPdTP7pPN1e0AQj8hdzZhfejl6BJw+pHQ1fV8nW 13ERwX6ypl3x5UW42Tbdq2eZWa3nw2oNHW8zBBg/OMSDwdllQnuFQKUPWFZNtt7M1TnV NMlqxndxrnPYARe8XBCIo8SyCeHvyoRSPvYKpScYRvAIa07Tlg5ZK4nBwh41h/4G9f8i GwqfJdrwW8tYQHbSEuT735zHRaac1nhDvLPzqnWmcEwxtfDhG+VuJfhc2dSGSPqQBrBd IZFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702565259; x=1703170059; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sof1gkerYbku5v+b3jW5lmXu1VdUZ0QZgBhWQoXBGdc=; b=me0jY1fgPwEfhYun08c2BU6iKeZuX/N5dkk8aeba+BMS3DuFLzI7zUgCoxrrVAxEMs 7V0IcNcHpzmQqA6r4ch2r+XiVP2EdLUOIgCrHsTu9PYxDpgMW2bYstIT0NDkwyxOUehL fDxeVd3+KXGcyiKtawOOcWDDYZxISlfPAo9PBPFK13i0y3w/gSTJ8WnhjKS8GcKMjoXV rWfKYgjUwhlAxp/6ADwahrxMEVxj5mqvKN+hjF+kFYMVvuwXTqdeJF0WLseMAevy5E/i vpkrWOg/XKt65rhTLvynb7OKE8eaEVujBFf6QvN47k1oDVF0Dy+Pe45MnVxVfenFZ/KL sMgA== X-Gm-Message-State: AOJu0YxQ3ira8sxeg1kp3tS8dfNj4pkwbcN1cwbpWvkekVzMuVc9QeBj 061n226x2G/cl7+b8RxpPaBvE3GHAcE= X-Google-Smtp-Source: AGHT+IHawo4hfwDtk3k2HkdR8iPUFBOsPm5v1cld8SI6HPoRP6qWJjkIxc29qlJ3dhzd2ztBxSDNcA== X-Received: by 2002:a05:6a20:1445:b0:18c:14e2:ad8c with SMTP id a5-20020a056a20144500b0018c14e2ad8cmr4954016pzi.25.1702565259046; Thu, 14 Dec 2023 06:47:39 -0800 (PST) Received: from rigel (60-241-235-125.tpgi.com.au. [60.241.235.125]) by smtp.gmail.com with ESMTPSA id d18-20020aa78692000000b006bdd7cbcf98sm11901912pfo.182.2023.12.14.06.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 06:47:38 -0800 (PST) Date: Thu, 14 Dec 2023 22:47:34 +0800 From: Kent Gibson To: Andy Shevchenko Cc: Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linus.walleij@linaro.org Subject: Re: [PATCH 1/4] gpiolib: cdev: relocate debounce_period_us from struct gpio_desc Message-ID: References: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 14, 2023 at 04:35:09PM +0200, Andy Shevchenko wrote: > On Thu, Dec 14, 2023 at 10:40:26AM +0100, Bartosz Golaszewski wrote: > > ... > > > > Opinions? > > > > Yeah, don't make it a kernel doc. It's a private structure, no need to > > expose documentation for it in docs. Just use a regular comment - say > > what it is and why it's here. > > I agree with Bart, make it plain comment if needed. > It is a plain comment in v2. Cheers, Kent.