From: Kent Gibson <warthog618@gmail.com>
To: Andy Shevchenko <andy@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
brgl@bgdev.pl, linus.walleij@linaro.org
Subject: Re: [PATCH v3 3/5] gpiolib: cdev: reduce locking in gpio_desc_to_lineinfo()
Date: Sat, 16 Dec 2023 07:27:20 +0800 [thread overview]
Message-ID: <ZXzg2DkAPPQV8vft@rigel> (raw)
In-Reply-To: <ZXyAh2hfhb3l5ogO@smile.fi.intel.com>
On Fri, Dec 15, 2023 at 06:36:23PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 15, 2023 at 10:38:03AM +0800, Kent Gibson wrote:
> > Reduce the time holding the gpio_lock by snapshotting the desc flags,
> > rather than testing them individually while holding the lock.
> >
> > Accept that the calculation of the used field is inherently racy, and
> > only check the availability of the line from pinctrl if other checks
> > pass, so avoiding the check for lines that are otherwise in use.
>
> Just wondering if you are using --histogram (diff algo) when preparing
> the patches...
>
Was just using the default myers.
Only changes patch 4, which it does make slightly more readable, so
will use it for v4.
Cheers,
Kent.
next prev parent reply other threads:[~2023-12-15 23:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 2:38 [PATCH v3 0/5] gpiolib: cdev: relocate debounce_period_us Kent Gibson
2023-12-15 2:38 ` [PATCH v3 1/5] gpiolib: cdev: relocate debounce_period_us from struct gpio_desc Kent Gibson
2023-12-15 16:35 ` Andy Shevchenko
2023-12-15 23:33 ` Kent Gibson
2023-12-15 2:38 ` [PATCH v3 2/5] gpiolib: remove " Kent Gibson
2023-12-15 2:38 ` [PATCH v3 3/5] gpiolib: cdev: reduce locking in gpio_desc_to_lineinfo() Kent Gibson
2023-12-15 16:36 ` Andy Shevchenko
2023-12-15 23:27 ` Kent Gibson [this message]
2023-12-15 2:38 ` [PATCH v3 4/5] gpiolib: cdev: fully adopt guard() and scoped_guard() Kent Gibson
2023-12-15 2:38 ` [PATCH v3 5/5] gpiolib: cdev: improve documentation of get/set values Kent Gibson
2023-12-15 16:43 ` [PATCH v3 0/5] gpiolib: cdev: relocate debounce_period_us Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXzg2DkAPPQV8vft@rigel \
--to=warthog618@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).