From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: xiongxin <xiongxin@kylinos.cn>,
hoan@os.amperecomputing.com, linus.walleij@linaro.org,
brgl@bgdev.pl, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@kernel.org,
Riwen Lu <luriwen@kylinos.cn>
Subject: Re: [PATCH v3] gpio: dwapb: mask/unmask IRQ when disable/enale it
Date: Tue, 19 Dec 2023 16:44:21 +0200 [thread overview]
Message-ID: <ZYGsRXJUcrLKEzUn@smile.fi.intel.com> (raw)
In-Reply-To: <euhbczna4hk5sacb23i2xwqh2jewlek7cfceprfslpsiijhwk3@3d6vtybmgag5>
On Tue, Dec 19, 2023 at 05:31:38PM +0300, Serge Semin wrote:
> On Tue, Dec 19, 2023 at 04:17:16PM +0200, Andy Shevchenko wrote:
> > On Tue, Dec 19, 2023 at 11:14 AM Serge Semin <fancer.lancer@gmail.com> wrote:
> > > On Tue, Dec 19, 2023 at 09:37:51AM +0800, xiongxin wrote:
> >
> > ...
> >
> > > Also note all the tags you've already got must be preserved on the
> > > next patch revisions. One more time:
> >
> > > Acked-by: Serge Semin <fancer.lancer@gmail.com>
> >
> > I recommend using `b4` for that.
> >
> > it harvests tags from the email thread, so no need to care about
> > possible misses.
>
> AFAICS it doesn't pick up the tags from the previous revisions at
> least if the new patch wasn't submitted as in-reply-to the prev one.
???
> Just tested it on v3. b4 found my new ab-tag only and no yours rb-tag.
> Did you mean something other than I thought you did?
Grabbing thread from lore.kernel.org/all/mdogxxro42ymeaykrgqpld2kqbppopbywcm76osskuf3df72sl@5jalt26vzcv4/t.mbox.gz
Analyzing 4 messages in the thread
Checking attestation on all messages, may take a moment...
---
[PATCH v2] gpio: dwapb: mask/unmask IRQ when disable/enale it
+ Reviewed-by: Andy Shevchenko <andy@kernel.org>
+ Acked-by: Serge Semin <fancer.lancer@gmail.com> (✓ DKIM/gmail.com)
The flow you need to follow is that
git checkout $BASE # gpio/for-next in this case
b4 am ... # as above
git am ...
...address comments...
git commit -a -s --amend
git format-patch ... -1 HEAD~0
git send-email ...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-19 14:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 1:37 [PATCH v3] gpio: dwapb: mask/unmask IRQ when disable/enale it xiongxin
2023-12-19 9:14 ` Serge Semin
2023-12-19 14:17 ` Andy Shevchenko
2023-12-19 14:31 ` Serge Semin
2023-12-19 14:44 ` Andy Shevchenko [this message]
2023-12-19 14:50 ` Andy Shevchenko
2023-12-19 14:52 ` Serge Semin
2023-12-19 18:56 ` Konstantin Ryabitsev
2023-12-19 21:58 ` Serge Semin
2023-12-19 22:10 ` Konstantin Ryabitsev
2023-12-19 22:16 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYGsRXJUcrLKEzUn@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=fancer.lancer@gmail.com \
--cc=hoan@os.amperecomputing.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luriwen@kylinos.cn \
--cc=stable@kernel.org \
--cc=xiongxin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox