From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] gpiolib: cdev: Split line_get_debounce_period() and use
Date: Fri, 22 Dec 2023 22:14:59 +0800 [thread overview]
Message-ID: <ZYWZ4yhqzTF8rShe@rigel> (raw)
In-Reply-To: <CACMJSeu-bS+MpP8HCcD74w0j6vFt821bpgth5LHpqq-fHnEe1w@mail.gmail.com>
On Fri, Dec 22, 2023 at 03:09:54PM +0100, Bartosz Golaszewski wrote:
> On Fri, 22 Dec 2023 at 15:08, Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Fri, Dec 22, 2023 at 02:37:43PM +0100, Bartosz Golaszewski wrote:
> > > On Fri, Dec 22, 2023 at 1:56 PM Kent Gibson <warthog618@gmail.com> wrote:
> > > >
> >
> > > > > > And you could've included me in the Cc so I didn't just find it by
> > > > > > accident.
> > > > >
> > > > > Maybe it's time to add you to the MAINTAINERS for this file as a designated
> > > > > reviewer?
> > > > >
> > > >
> > > > You are patching my recent change that you yourself reviewed only days
> > > > ago. I would think that you would Cc me whether I were a maintainer or
> > > > not as I'm very likely to have relevant feedback.
> > >
> > > On that note: do you see yourself as a full GPIO reviewer or do you
> > > prefer I split out the uAPI part into a separate section in
> > > MAINTAINERS and nominate you as its maintainer?
> > >
> >
> > Not sure I'm comfortable with either.
> >
> > Definitely not full GPIO. I don't feel sufficiently familiar with GPIO
> > and the related subsystems to qualify.
> >
> > Splitting out cdev and the uAPI makes more sense to me, but in my mind at
> > least even that requires a level of commitment higher than the rather
> > spotty attention I've been providing recently.
> > I'm more inclined to leave it as is.
> >
>
> I can still split the uAPI files into their own section, make Linus
> and myself maintainers and make you a reviewer, how about that?
>
That is closer to the reality, so that would work for me.
Cheers,
Kent.
next prev parent reply other threads:[~2023-12-22 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 17:55 [PATCH v1 1/1] gpiolib: cdev: Split line_get_debounce_period() and use Andy Shevchenko
2023-12-22 1:12 ` Kent Gibson
2023-12-22 8:58 ` Bartosz Golaszewski
2023-12-22 12:40 ` Andy Shevchenko
2023-12-22 12:58 ` Kent Gibson
2023-12-22 12:39 ` Andy Shevchenko
2023-12-22 12:56 ` Kent Gibson
2023-12-22 13:37 ` Bartosz Golaszewski
2023-12-22 14:08 ` Kent Gibson
2023-12-22 14:09 ` Bartosz Golaszewski
2023-12-22 14:14 ` Kent Gibson [this message]
2023-12-22 17:49 ` Linus Walleij
2023-12-23 2:08 ` Kent Gibson
2023-12-28 0:26 ` Linus Walleij
2023-12-28 0:49 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYWZ4yhqzTF8rShe@rigel \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).