From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9043929B780 for ; Tue, 15 Apr 2025 15:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744731607; cv=none; b=SSBMOcIcATA9lIBcR54NfL+c3ywPlNO3wapEA2Wq/ofDNa2F/Sp55ATlrDM+60IfvvJYJKiWwOuPHRaQ5OjS3OACB6Jxpq9v6rKKg/9xI+gDdHAIC1S6h1j5ffroqx3HAW4GO5fWyiN+1X2ckkc2L6e7UBjoOU4E5jk4WaCtQls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744731607; c=relaxed/simple; bh=VSA6hdeaoADvOUXacUyO/p5DGOSeT1IneqbdsN7HL3c=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b6xgbKrdPdajDD/TXoVq+T//g5U+bFTArihl6LjHJ059OV/iILColpcr3Fp6KHDxBqeBvgGKrL5X/vkuZ9MCOA3Avyie6/hTxGErxE+NGMKtBtfKdGZpxq0x5W2Fs0VoQoAZ48w5stAHVq9ybbvdERWYVelNKIr+IsoesWfrKCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KGVOhW4g; arc=none smtp.client-ip=209.85.218.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KGVOhW4g" Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-ac28e66c0e1so864564066b.0 for ; Tue, 15 Apr 2025 08:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744731604; x=1745336404; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=pHLj/Q/sOaFpLIs3FEe17J8/SRfhLs+hrL+m95dT2SQ=; b=KGVOhW4gy7ht+DxhjLj2UeKGe6fbRozU+4RxOQmbbGgMF+50b5PPXJ0vF0Jxuz93BQ gHXOspWXV4BUMbtsDFQ7RWn/aYkqcU1112GatH1RXLa0sjOAlaJhYNf6m1QsaO8HLNR/ WmiSziEQZeEDn6Ky9uXnBj7P+aQhymtD34Q55zjzBDEeSNyf8DRTQcxkdaAUE/cw6tR9 fQja2UNhAY46CvqbdErOIkXv0y/t3vc1KFfTQHPyTHO5Kbzxn+SXKw3gyhNKklTdMqBB 1sekWRJahzkzx5hURe2Y+6O9To00StBgskmAv2iFID6tBpuu0YGo4PT3wDby5AAD9i0g ZAvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744731604; x=1745336404; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pHLj/Q/sOaFpLIs3FEe17J8/SRfhLs+hrL+m95dT2SQ=; b=gWW+1HfiCj8RdNUCI2uX3cgWhgNiO3eGbePz8E1jqnZ7UWkbZndpEEK6A+c/rtltPh mmdm9l6ZVyqj3y/mE5v99oiHR6bBYCU7g5rUjitGXOos682mqslidUivV7ocawn0OR73 aqAN9SBwkDE6/Y76bgJhqFHipoWM6/UR5YUtsbGSqq/RJbEYZWpIjtz4i0NtnKg1ovpM BWJRCIP1zClLjI0aP0X8uXqZap0v9vtViKsQjs5blZOBqyEI5Q1x9VPtd6cCKac856qS jIGo+UkVjezdQS/krytWBnLghGVRFr0elF/YDn72vl2vQD0eQEv+kaMcL+6aX9pBjrDT q4SA== X-Forwarded-Encrypted: i=1; AJvYcCXIry36mg08hcz96u3qDVDwLM0oOA6w33/aqfSwQ8NLRApL3iPz733evCMQXgQWWqMVGe+tTIa4l0NV@vger.kernel.org X-Gm-Message-State: AOJu0YygoIa0yCzUbfC3gZ6ykK++7Q+EINV3Wv5e1zXVFwC1YyxSBPyG DljKNRnLn9zceoKxfBLADK/kyrLwMJX4X4OwH6GQpRf9SBWLn21Tt3p0dOXlfKQ= X-Gm-Gg: ASbGnctwoSI57QXGjUUmeBWhbXdSJTHNbK/b/NmGX2arzNKzw0GZZ/yXQxxQxwu5H+A CKbyfwmvAi8HRuI29lpk6vT5ussQJwSTImcK+COfAup8EmaaQqsf2a2d6go6k1SWpAFvQsmn93n OyTexGjjmZ++PP/XuI1PjdrU/2VnvNb7EBGZQucl9B9cZEhUKbVkqfMUuK2KlX96YMglfi67cKq u2PaXpy53wWZwrgbdhSgvHO4opEqkYfURAXvOK6e1IpM5wXUjRgw0rO8U25tRiMzOAP5IP5+9tK t1dgoHGDu7GPoLx6fStL+5AS0oETP+SeIeCj5IqmaJtfFJvyCNJLaHZFzNx+rp+Kdu1iigtOPnS vvipQpg== X-Google-Smtp-Source: AGHT+IH7EkpxnEGrVDPA/wXcjxUS3uvn0zUd7xAOXnljoK+P5iXt632rg6oTgD9CrBhQ3HtW1Xsnmg== X-Received: by 2002:a17:907:3f11:b0:ac2:7a6d:c927 with SMTP id a640c23a62f3a-acad36c7212mr1222248466b.50.1744731603735; Tue, 15 Apr 2025 08:40:03 -0700 (PDT) Received: from localhost (93-44-188-26.ip98.fastwebnet.it. [93.44.188.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1be8fcdsm1099687566b.46.2025.04.15.08.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 08:40:03 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 15 Apr 2025 17:41:26 +0200 To: Greg Kroah-Hartman Cc: Herve Codina , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , Phil Elwell , Dave Stevenson , kernel-list@raspberrypi.com Subject: Re: [PATCH v8 08/13] misc: rp1: RaspberryPi RP1 misc driver Message-ID: References: <3fbc487bc0e4b855ffbee8ed62cfb6bf3b0592e8.1742418429.git.andrea.porta@suse.com> <2025041557-masculine-abrasive-c372@gregkh> <20250415165505.0c05bc61@bootlin.com> <2025041531-dubiously-duchess-276a@gregkh> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2025041531-dubiously-duchess-276a@gregkh> Hi Greg, On 17:14 Tue 15 Apr , Greg Kroah-Hartman wrote: > On Tue, Apr 15, 2025 at 04:55:05PM +0200, Herve Codina wrote: > > Hi Greg, > > > > On Tue, 15 Apr 2025 16:06:43 +0200 > > Greg Kroah-Hartman wrote: > > > > > On Wed, Mar 19, 2025 at 10:52:29PM +0100, Andrea della Porta wrote: > > > > The RaspberryPi RP1 is a PCI multi function device containing > > > > peripherals ranging from Ethernet to USB controller, I2C, SPI > > > > and others. > > > > > > So shouldn't this be using the auxbus code? That's designed to "split > > > up" PCI devices such that you can share them this way. > > > > > > Or did that get rejected somewhere previously? > > > > > > > It doesn't use auxbus probably for the exact same reason that the > > one given for the LAN966x PCI device driver [0] and [1]. > > > > Avoid all boiler plate needed with auxbus whereas drivers already exist > > as platform drivers. Internal devices are handled by those platform drivers. > > Those devi just need to be described as platform devices and device-tree is > > fully relevant for that description. > > > > [0] https://lore.kernel.org/all/CAL_Jsq+1r3SSaXupdNAcXO-4rcV-_3_hwh0XJaBsB9fuX5nBCQ@mail.gmail.com/ > > [1] https://lore.kernel.org/all/Y9kuxrL3XaCG+blk@kroah.com/ > > I really hate creating platform devices below a PCI device, so I'll keep > complaining about this every time people try to do it. I agree with you, but as Herve has already pointed out this would mean incurring in significant work to adapt drivers for all the peripherals (there are quite a few), while with this approach they would be left untouched. Many thanks, Andrea > > thanks, > > greg k-h