From: Andy Shevchenko <andy@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Peter Tyser <ptyser@xes-inc.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 04/12] gpio: exar: use new line value setter callbacks
Date: Mon, 7 Apr 2025 11:51:38 +0300 [thread overview]
Message-ID: <Z_OSGmIk4AH5xtdp@smile.fi.intel.com> (raw)
In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-4-78399683ca38@linaro.org>
On Mon, Apr 07, 2025 at 09:13:13AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
...
> -static void exar_set_value(struct gpio_chip *chip, unsigned int offset,
> - int value)
> +static int exar_set_value(struct gpio_chip *chip, unsigned int offset,
> + int value)
It can be located on one line (81 characters).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-07 8:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:13 [PATCH 00/12] gpio: convert more GPIO chips to using new value setters Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 01/12] gpio: dln2: use new line value setter callbacks Bartosz Golaszewski
2025-04-07 8:50 ` Andy Shevchenko
2025-04-07 7:13 ` [PATCH 02/12] gpio: eic-sprd: " Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 03/12] gpio: em: " Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 04/12] gpio: exar: " Bartosz Golaszewski
2025-04-07 8:51 ` Andy Shevchenko [this message]
2025-04-07 7:13 ` [PATCH 05/12] gpio: allow building port-mapped GPIO drivers with COMPILE_TEST=y Bartosz Golaszewski
2025-04-07 9:00 ` Andy Shevchenko
2025-04-15 8:30 ` Linus Walleij
2025-04-17 11:57 ` Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 06/12] gpio: f7188: use new line value setter callbacks Bartosz Golaszewski
2025-04-07 9:02 ` Andy Shevchenko
2025-04-07 7:13 ` [PATCH 07/12] gpio: graniterapids: " Bartosz Golaszewski
2025-04-07 9:02 ` Andy Shevchenko
2025-04-07 7:13 ` [PATCH 08/12] gpio: gw-pld: " Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 09/12] gpio: htc-egpio: enable building with COMPILE_TEST=y Bartosz Golaszewski
2025-04-15 8:33 ` Linus Walleij
2025-04-07 7:13 ` [PATCH 10/12] gpio: htc-egpio: use new line value setter callbacks Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 11/12] gpio: ich: enable building with COMPILE_TEST=y Bartosz Golaszewski
2025-04-07 8:54 ` Andy Shevchenko
2025-04-15 8:30 ` Linus Walleij
2025-04-07 7:13 ` [PATCH 12/12] gpio: ich: use new line value setter callbacks Bartosz Golaszewski
2025-04-07 8:54 ` Andy Shevchenko
2025-04-16 15:56 ` [PATCH 00/12] gpio: convert more GPIO chips to using new value setters Bartosz Golaszewski
2025-04-16 18:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_OSGmIk4AH5xtdp@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ptyser@xes-inc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).