From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arturas Moskvinas <arturas.moskvinas@gmail.com>
Cc: linus.walleij@linaro.org, biju.das.jz@bp.renesas.com,
akaessens@gmail.com, thomas.preston@codethink.co.uk,
preid@electromag.com.au, u.kleine-koenig@pengutronix.de,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: mcp23s08: Check only GPIOs which have interrupts enabled
Date: Thu, 1 Feb 2024 16:30:30 +0200 [thread overview]
Message-ID: <ZburBq7ZJhK_X_t0@smile.fi.intel.com> (raw)
In-Reply-To: <20240201141406.32484-2-arturas.moskvinas@gmail.com>
On Thu, Feb 01, 2024 at 04:14:07PM +0200, Arturas Moskvinas wrote:
> GPINTEN register contains information about GPIOs with enabled
> interrupts no need to check other GPIOs for changes.
>
> Signed-off-by: Arturas Moskvinas <arturas.moskvinas@gmail.com>
> ---
You forgot to add a changelog here, but no need to resend, just you can respond
to the email since it's not a big issue in this case.
...
> + if (mcp_read(mcp, MCP_GPINTEN, &gpinten))
> + goto unlock;
Do all hw variants have this register available?
Esp. I2C part, wouldn't it be problematic (exception with NACK on the bus)?
...
The rest LGTM, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-01 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 14:14 [PATCH v2] pinctrl: mcp23s08: Check only GPIOs which have interrupts enabled Arturas Moskvinas
2024-02-01 14:30 ` Andy Shevchenko [this message]
2024-02-02 10:40 ` Arturas Moskvinas
2024-02-08 13:46 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2024-02-05 13:56 Andy Shevchenko
2024-02-07 10:50 ` Arturas Moskvinas
2024-02-07 14:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZburBq7ZJhK_X_t0@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akaessens@gmail.com \
--cc=arturas.moskvinas@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=preid@electromag.com.au \
--cc=thomas.preston@codethink.co.uk \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).