From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68FCB22EED; Mon, 5 Feb 2024 13:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707141475; cv=none; b=H033hRgWIZvQbagPULw0kf4eOGzTYB8hkjgB6ro5x3sj7KNJ7+Ak5GK0XkRQ2bQBGBZMv/ZTvQpf+VDanxLit7gdrjo5JG6lW+NYOG6zkj6TMZR+XLX81i2QSEmgGGl6t/oPcluyONRoYqPo4Nffw0lS5/Wa0hIf7Ud5MNzvoxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707141475; c=relaxed/simple; bh=ZM3+zW05SrsrlyVmd5gMKWjkps4zlzbvlNsuTpZ3HaA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cM2H/TYP+m7TAIyGVCT7+xFLqgTfrb6gDlIzPwoFZlXRgjB7WUNy8x7EF/X/vhuIiTd4tBkVaWbuBB9zJPJsplHTYVSk5JVqhGYhTmmj4A5JcHybIAH/KLErM0n6XiWeObQe3pLRdf0tkxpWwcj8IYtQsipjX0Efryxy3ljNkZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Nlky1Mnz; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Nlky1Mnz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707141473; x=1738677473; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ZM3+zW05SrsrlyVmd5gMKWjkps4zlzbvlNsuTpZ3HaA=; b=Nlky1Mnz2i2qpyZNYri3V8r8tmmE11ux5QSnTWfAJFTWxr7AtPYVJSu/ dFCgcwej7QFLBEYJt8XR5xVXtxQfA+cLojB6qscnnqrDvwjzoXpFHOkB3 qDqb8h8FYYDFN7/qZ6yhE9QfTIBAhr1bxwE3o9KgSy1LFHa/f3AkZU8KL xWahGQQCMFXjVb5Zb6svaBo/tFDqJNh1QDymiHRpn1rOmGKMwoBrxLIoM UVq4qbW1R7+xzQ+cTpOiWODc99QbRPUk/S5ky+Ox0jmWMsxNRlcC00d1+ GNanDjXl+69ucVAw7lZ8zW2bng8xmZxojRJkivRSzSasUdLKjy9DiDFZV g==; X-IronPort-AV: E=McAfee;i="6600,9927,10974"; a="432250" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="432250" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:57:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10974"; a="909301405" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="909301405" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:57:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rWzTm-000000025yW-19ng; Mon, 05 Feb 2024 15:57:46 +0200 Date: Mon, 5 Feb 2024 15:57:45 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Kent Gibson , Alex Elder , Geert Uytterhoeven , "Paul E . McKenney" , Wolfram Sang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v2 06/23] gpio: add SRCU infrastructure to struct gpio_desc Message-ID: References: <20240205093418.39755-1-brgl@bgdev.pl> <20240205093418.39755-7-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 05, 2024 at 02:54:08PM +0100, Bartosz Golaszewski wrote: > On Mon, Feb 5, 2024 at 2:48 PM Andy Shevchenko > wrote: > > On Mon, Feb 05, 2024 at 10:34:01AM +0100, Bartosz Golaszewski wrote: ... > > > + for (j = 0; j < i; j++) > > > + cleanup_srcu_struct(&desc->srcu); > > > > What does this loop mean? > > I open-coded it because I want to store the value of i to go back and > destroy the SRCU structs on failure. Where/how is j being used? > > > + goto err_remove_of_chip; > > > + } -- With Best Regards, Andy Shevchenko