From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Bartosz Golaszewski" <brgl@bgdev.pl>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] gpio: nomadik: Back out some managed resources
Date: Wed, 6 Mar 2024 18:17:42 +0200 [thread overview]
Message-ID: <ZeiXJjJ0zZUX1UuE@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdZCXE6VBa3f7asSNYF7Esn5nHnxf0QJfibT7TcfSE52FQ@mail.gmail.com>
On Wed, Mar 06, 2024 at 01:51:09PM +0100, Linus Walleij wrote:
> On Wed, Mar 6, 2024 at 12:20 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
...
> Fixed them both when applying! Thanks!
There is still an issue with error path. The problem is that the populate is
called too early and even though the failure of let's say gpiochip_add_data()
(as it seems the only one that really needed the restoration) will NOT reverse
the all allocated gpio_pdev/gpio_dev related resources.
Hence what I see is
1) move populate as down as possible in probe();
2) create unpopulate counterpart;
3) call it in probe().
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-03-06 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 22:09 [PATCH v2] gpio: nomadik: Back out some managed resources Linus Walleij
2024-03-06 11:19 ` Andy Shevchenko
2024-03-06 12:51 ` Linus Walleij
2024-03-06 15:13 ` Théo Lebrun
2024-03-06 19:46 ` Linus Walleij
2024-03-06 16:17 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeiXJjJ0zZUX1UuE@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=theo.lebrun@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).