linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: airoha: en7581: Add gpio controller nodes
@ 2024-05-01 14:25 Lorenzo Bianconi
  2024-05-05 12:22 ` Bartosz Golaszewski
  0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Bianconi @ 2024-05-01 14:25 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, nbd, john, devicetree,
	dd, catalin.marinas, will, upstream, lorenzo.bianconi83,
	angelogioacchino.delregno, linus.walleij, brgl, linux-gpio

Introduce the Airoha EN7581 gpio nodes in Airoha EN7581 dtsi

Tested-by: Rajeev Kumar <Rajeev.Kumar@airoha.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
This patch is based on the following pending patch:
https://patchwork.kernel.org/project/spi-devel-general/patch/189790802f3ba1a80c4ab5e064b2425e5a360098.1714571980.git.lorenzo@kernel.org/
---
 arch/arm64/boot/dts/airoha/en7581.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/boot/dts/airoha/en7581.dtsi
index 98c2a86086e1..5d0d76cecfe0 100644
--- a/arch/arm64/boot/dts/airoha/en7581.dtsi
+++ b/arch/arm64/boot/dts/airoha/en7581.dtsi
@@ -178,5 +178,25 @@ spi_nand: nand@0 {
 				spi-rx-bus-width = <2>;
 			};
 		};
+
+		gpio0: gpio@1fbf0200 {
+			compatible = "airoha,en7523-gpio";
+			reg = <0 0x1fbf0204 0 0x4>,
+			      <0 0x1fbf0200 0 0x4>,
+			      <0 0x1fbf0220 0 0x4>,
+			      <0 0x1fbf0214 0 0x4>;
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
+
+		gpio1: gpio@1fbf0270 {
+			compatible = "airoha,en7523-gpio";
+			reg = <0 0x1fbf0270 0 0x4>,
+			      <0 0x1fbf0260 0 0x4>,
+			      <0 0x1fbf0264 0 0x4>,
+			      <0 0x1fbf0278 0 0x4>;
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
 	};
 };
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: airoha: en7581: Add gpio controller nodes
  2024-05-01 14:25 [PATCH] arm64: dts: airoha: en7581: Add gpio controller nodes Lorenzo Bianconi
@ 2024-05-05 12:22 ` Bartosz Golaszewski
  2024-05-07 10:05   ` Lorenzo Bianconi
  0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2024-05-05 12:22 UTC (permalink / raw)
  To: Lorenzo Bianconi
  Cc: linux-arm-kernel, robh+dt, krzysztof.kozlowski+dt, conor+dt, nbd,
	john, devicetree, dd, catalin.marinas, will, upstream,
	lorenzo.bianconi83, angelogioacchino.delregno, linus.walleij,
	linux-gpio

On Wed, May 1, 2024 at 4:26 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>
> Introduce the Airoha EN7581 gpio nodes in Airoha EN7581 dtsi
>
> Tested-by: Rajeev Kumar <Rajeev.Kumar@airoha.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> This patch is based on the following pending patch:
> https://patchwork.kernel.org/project/spi-devel-general/patch/189790802f3ba1a80c4ab5e064b2425e5a360098.1714571980.git.lorenzo@kernel.org/
> ---
>  arch/arm64/boot/dts/airoha/en7581.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/boot/dts/airoha/en7581.dtsi
> index 98c2a86086e1..5d0d76cecfe0 100644
> --- a/arch/arm64/boot/dts/airoha/en7581.dtsi
> +++ b/arch/arm64/boot/dts/airoha/en7581.dtsi
> @@ -178,5 +178,25 @@ spi_nand: nand@0 {
>                                 spi-rx-bus-width = <2>;
>                         };
>                 };
> +
> +               gpio0: gpio@1fbf0200 {

These labels are not used anywhere.

Bart

> +                       compatible = "airoha,en7523-gpio";
> +                       reg = <0 0x1fbf0204 0 0x4>,
> +                             <0 0x1fbf0200 0 0x4>,
> +                             <0 0x1fbf0220 0 0x4>,
> +                             <0 0x1fbf0214 0 0x4>;
> +                       gpio-controller;
> +                       #gpio-cells = <2>;
> +               };
> +
> +               gpio1: gpio@1fbf0270 {
> +                       compatible = "airoha,en7523-gpio";
> +                       reg = <0 0x1fbf0270 0 0x4>,
> +                             <0 0x1fbf0260 0 0x4>,
> +                             <0 0x1fbf0264 0 0x4>,
> +                             <0 0x1fbf0278 0 0x4>;
> +                       gpio-controller;
> +                       #gpio-cells = <2>;
> +               };
>         };
>  };
> --
> 2.44.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: airoha: en7581: Add gpio controller nodes
  2024-05-05 12:22 ` Bartosz Golaszewski
@ 2024-05-07 10:05   ` Lorenzo Bianconi
  0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2024-05-07 10:05 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: linux-arm-kernel, robh+dt, krzysztof.kozlowski+dt, conor+dt, nbd,
	john, devicetree, dd, catalin.marinas, will, upstream,
	lorenzo.bianconi83, angelogioacchino.delregno, linus.walleij,
	linux-gpio

[-- Attachment #1: Type: text/plain, Size: 2148 bytes --]

> On Wed, May 1, 2024 at 4:26 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >
> > Introduce the Airoha EN7581 gpio nodes in Airoha EN7581 dtsi
> >
> > Tested-by: Rajeev Kumar <Rajeev.Kumar@airoha.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > This patch is based on the following pending patch:
> > https://patchwork.kernel.org/project/spi-devel-general/patch/189790802f3ba1a80c4ab5e064b2425e5a360098.1714571980.git.lorenzo@kernel.org/
> > ---
> >  arch/arm64/boot/dts/airoha/en7581.dtsi | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/boot/dts/airoha/en7581.dtsi
> > index 98c2a86086e1..5d0d76cecfe0 100644
> > --- a/arch/arm64/boot/dts/airoha/en7581.dtsi
> > +++ b/arch/arm64/boot/dts/airoha/en7581.dtsi
> > @@ -178,5 +178,25 @@ spi_nand: nand@0 {
> >                                 spi-rx-bus-width = <2>;
> >                         };
> >                 };
> > +
> > +               gpio0: gpio@1fbf0200 {
> 
> These labels are not used anywhere.
> 
> Bart

ack. Let's drop this patch for the moment, I am planning to the work gpio
support.

Regards,
Lorenzo

> 
> > +                       compatible = "airoha,en7523-gpio";
> > +                       reg = <0 0x1fbf0204 0 0x4>,
> > +                             <0 0x1fbf0200 0 0x4>,
> > +                             <0 0x1fbf0220 0 0x4>,
> > +                             <0 0x1fbf0214 0 0x4>;
> > +                       gpio-controller;
> > +                       #gpio-cells = <2>;
> > +               };
> > +
> > +               gpio1: gpio@1fbf0270 {
> > +                       compatible = "airoha,en7523-gpio";
> > +                       reg = <0 0x1fbf0270 0 0x4>,
> > +                             <0 0x1fbf0260 0 0x4>,
> > +                             <0 0x1fbf0264 0 0x4>,
> > +                             <0 0x1fbf0278 0 0x4>;
> > +                       gpio-controller;
> > +                       #gpio-cells = <2>;
> > +               };
> >         };
> >  };
> > --
> > 2.44.0
> >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-05-07 10:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-01 14:25 [PATCH] arm64: dts: airoha: en7581: Add gpio controller nodes Lorenzo Bianconi
2024-05-05 12:22 ` Bartosz Golaszewski
2024-05-07 10:05   ` Lorenzo Bianconi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).