From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: renesas: rzn1: Use for_each_child_of_node_scoped()
Date: Thu, 30 May 2024 12:26:56 +0300 [thread overview]
Message-ID: <ZlhGYFM6iVlGjZk-@surfacebook.localdomain> (raw)
In-Reply-To: <c0a28f466c42d5d59c7fadfa1fd05fd512d43b6f.1717060708.git.geert+renesas@glider.be>
Thu, May 30, 2024 at 11:19:29AM +0200, Geert Uytterhoeven kirjoitti:
> Use the scoped variant of for_each_child_of_node() to simplify the code.
I do not see the point of this patch. This makes code actually more
complicated, and I'm not sure the code generation is the same and not worse.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-30 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 9:19 [PATCH] pinctrl: renesas: rzn1: Use for_each_child_of_node_scoped() Geert Uytterhoeven
2024-05-30 9:26 ` Andy Shevchenko [this message]
2024-05-30 11:52 ` Geert Uytterhoeven
2024-05-30 13:36 ` Andy Shevchenko
2024-05-31 8:01 ` Dan Carpenter
2024-05-31 8:19 ` Andy Shevchenko
2024-05-31 9:18 ` Dan Carpenter
2024-06-07 12:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlhGYFM6iVlGjZk-@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox