Re: [PATCH 04/11] of: address: Preserve the flags portion on 1:1 dma-ranges mapping

Andrea della Porta
2024-09-04T08:32:56Z

Hi Rob,

On 13:46 Tue 03 Sep , Rob Herring wrote:
> On Tue, Sep 3, 2024 at 11:15 AM Andrea della Porta
> <andrea.porta@suse.com> wrote:
> >
> > Hi Rob,
> >
> > On 14:37 Fri 30 Aug , Rob Herring wrote:
> > > On Thu, Aug 29, 2024 at 11:26 AM Andrea della Porta
> > > <andrea.porta@suse.com> wrote:
> > > >
> > > > Hi Rob,
> > > >
> >
> > ...
> >
> > >
> > > I think simple-bus where you have it is fine. It is really 1 level up
> > > that needs to be specified. Basically something that's referenced from
> > > the specific PCI device's schema (e.g. the RP1 schema (which you are
> > > missing)).
> > >
> > > That schema needs to roughly look like this:
> > >
> > > properties:
> > > "#address-cells":
> > > const: 3
> > > "#size-cells":
> > > const: 2
> > > ranges:
> > > minItems: 1
> > > maxItems: 6
> > > items:
> > > additionalItems: true
> > > items:
> > > - maximum: 5 # The BAR number
> > > - const: 0
> > > - const: 0
> > > - # TODO: valid PCI memory flags
> > >
> > > patternProperties:
> > > "^bar-bus@[0-5]$":
> > > type: object
> > > additionalProperties: true
> > > properties:
> > > compatible:
> > > const: simple-bus
> > > ranges: true
> > >
> >
> > Hmmm.. not sure how this is going to work. The PCI device (RP1) will
> > havei, at runtime, a compatible like this:
> >
> > compatible = "pci1de4,1\0pciclass,0200000\0pciclass,0200";
> >
> > that is basically generated automatically by the OF framework. So, in the
> > schema you proposed above, I can put something like:
> >
> > properties:
> > compatible:
> > contains:
> > pattern: '^pci1de4,1'
>
> No, it should be like this:
>
> compatible:
> items:
> - const: pci1de4,1
> - const: pciclass,0200000
> - const: pciclass,0200
>
> or
>
> compatible:
> addtionalItems: true
> maxItems: 3
> items:
> - const: pci1de4,1
>

Ack.

>
> Alternatively, we could instead only generate 'pciclass' compatibles
> for bridge nodes. The reason being that being an ethernet controller
> doesn't really tell us anything. There's no standard interface
> associated with that class.

I'd avoid this one, since the class is not representative in this case. RP1
is an MFD and not an Ethernet controller. Also, it would prevent other similar
PCI devices with differnt class from using this schema.

>
> > or maybe I could omit the compatible entirely, like in:
>
> No.
>
> > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/pci/pci-iommu.yaml
>
> That's not a device node, but just part of pci-host-bridge.yaml.
>
> > that seems to refer to generic compatible values.
> > In both cases though, I don't see how these binding could work with
> > make dt_binding_check, since there's no compatible known at compile
> > time (for the first approach), or no compatible at all (the second
> > approach).
> > Is it intended only as a loose documentation?
>
> No, schemas define exactly what a binding can and can't contain. But
> they are divided into device schemas and common schemas. The latter
> are incomplete and are included by the former. Generally, "compatible"
> goes in device schemas.

Ack.

>
> > Or are you proposing that for a future new bus (hence with a new, specific,
> > compatible) that could be described by the schema above?
>
> The above schema would be the common schema included by a RP1 schema,
> LAN966x schema, or any other device doing the same thing.

Many thanks, I believe I've got it now :)

Cheers,
Andrea

> Rob