From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Yan Zhen <yanzhen@vivo.com>
Cc: <rf@opensource.cirrus.com>, <linus.walleij@linaro.org>,
<linux-sound@vger.kernel.org>, <patches@opensource.cirrus.com>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<opensource.kernel@vivo.com>
Subject: Re: [PATCH v2] pinctrl: Simplify with dev_err_probe()
Date: Fri, 30 Aug 2024 09:14:48 +0100 [thread overview]
Message-ID: <ZtF/eGlQXPjaeBRa@opensource.cirrus.com> (raw)
In-Reply-To: <20240829044835.2047794-1-yanzhen@vivo.com>
On Thu, Aug 29, 2024 at 12:48:35PM +0800, Yan Zhen wrote:
> Switch to use dev_err_probe() to simplify the error path and
> unify a message template.
>
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
>
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
>
>
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
> ---
Subject line really should be pinctrl: madera:, but otherwise:
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2024-08-30 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 4:48 [PATCH v2] pinctrl: Simplify with dev_err_probe() Yan Zhen
2024-08-30 8:14 ` Charles Keepax [this message]
2024-09-02 8:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtF/eGlQXPjaeBRa@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).