From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4121811711 for ; Sat, 31 Aug 2024 13:53:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725112440; cv=none; b=L5qTzkzEQcShlTGjCdKXXIhSr8qm5Ynb3YzkgQ2+xy/IjKmbUGENUCRUhVeCznoSpHlUQ8wJwz90HVmgoEuEM1CZK7kI9oSPN7P7mWGWOU2t8bkHcJ6ZuZLYmVeWFVdWaOGI+69ySfoBaw9gLGk9pfUHOLFCQo3hNVM7/O/6Zak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725112440; c=relaxed/simple; bh=wJ4QgFNuqwu/Leb/N4TW45209mZ5WZDv25eNPwvyxO0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HASPJipLgAk6OGP1+nPzynPMJzvf1YV7q0Z/bwUKAvPw1FgTAq1LEWRMp+VouVHHp4MW3XbZF40BauY5xk957nveCL5E1fsOnCfGhMtB5hPE6TH/wNvVRZVSAgTUmUGr9Oj0L+TsIb+T/8fXde5vWS+7jw8MNHE2WPdCyHhUDTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V1jjL5XG; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V1jjL5XG" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42bbf138477so9208795e9.2 for ; Sat, 31 Aug 2024 06:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725112437; x=1725717237; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=36D9CATQ2pvh5CBMOXJIawRjTPDBw45elgFZcq41bNg=; b=V1jjL5XGEq/3FxsxLbbIBYQP1A3m+CNzjc0UwmTIAf8wcRF9bLUw1UYeU5PPWw7Lsf AyStAX/hfsp7xSYO9/1AjXv8qk6jZczpQjGfiuJ3+Ku7CKZfSmm0E404Ai6xqu26E+Mg 5VHoewo6DBbe1s4I+wZ6651TjANCPwP7iwRaRlPMyE5cJXc+EV7r+Lklcbi5HuSNBJex jQzuu/AN23x7KaVxUF5Rcf/rHT4yB7biBUabHEGZxQ0B2aJOfEInlQmWEoEgs/QuqPx/ KTnOJRdUQUfWQPmI8oqdZuvC5tOpDFmvXZGiW3WkGSS7eKCHn0k/rMf3Hl9KFv3LFlEx 4qoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725112437; x=1725717237; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=36D9CATQ2pvh5CBMOXJIawRjTPDBw45elgFZcq41bNg=; b=F0oA1GzAMudTsiiB6OmN6aQe5feggCnkrjNATEkETXBBE5t4pqZ1zlo4U7Sre9G+dY /U4PErY/S0drcrq04jvWJqqPbXvvSqp7dz2uN3rSYDLsWyDIkspLz0FulKDGkN2OXrXN ady5qCJ24gn8OzmliK3WcOlawYx3WrLkShmwiFFCgjYjaV5SiZH1O7UjBCplrhiyYkoE 1cCk/1yOyBRhQ1Vm3hEZHE23zc3u+cjUUOf+wD3e46n9xSph2He1p6A9xluyNsqYOpwS JcIGMOOXAbRLIpH1KoF8GMMrUBzgiX90qEEOCN7g5fsXbrP6whkQYfvjxq2NCBSBJNCT PTiA== X-Forwarded-Encrypted: i=1; AJvYcCXP0oLenEGawg7EN9pJV4PHPS/Zs1iGzPzzz+w/9i+EoArBhY6dBhBdaLTCxK7wddPDSDUsej2a/oKl@vger.kernel.org X-Gm-Message-State: AOJu0YzpmQKxkUwDRsre/Cu43KoKvPYhemLUoxY7M51qRDJWfDm4693S cw94hP8QG2CfUGPyskkyVEeyHwxT70lvMeR6CAoYY/uw0rwpoihf0Ck8POoJQrs= X-Google-Smtp-Source: AGHT+IHX2XVIKii7FuT5487mVz6P9wGbmrCYDRQmGLpqd0rgF3FqG6sdOGhjn9n4TnD5FCIX0Rz0Cg== X-Received: by 2002:a05:600c:3b25:b0:428:d83:eb6b with SMTP id 5b1f17b1804b1-42bb0294357mr77516125e9.15.1725112436454; Sat, 31 Aug 2024 06:53:56 -0700 (PDT) Received: from linaro.org ([82.79.186.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6deb2dcsm77602925e9.1.2024.08.31.06.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Aug 2024 06:53:55 -0700 (PDT) Date: Sat, 31 Aug 2024 16:53:54 +0300 From: Abel Vesa To: Stephan Gerhold Cc: Linus Walleij , Bjorn Andersson , Konrad Dybcio , Rajendra Nayak , Maulik Shah , Sibi Sankar , Johan Hovold , Srinivas Kandagatla , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] pinctrl: qcom: x1e80100: Bypass PDC wakeup parent for now Message-ID: References: <20240830-x1e80100-bypass-pdc-v1-1-d4c00be0c3e3@linaro.org> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830-x1e80100-bypass-pdc-v1-1-d4c00be0c3e3@linaro.org> On 24-08-30 11:09:07, Stephan Gerhold wrote: > On X1E80100, GPIO interrupts for wakeup-capable pins have been broken since > the introduction of the pinctrl driver. This prevents keyboard and touchpad > from working on most of the X1E laptops. So far we have worked around this > by manually building a kernel with the "wakeup-parent" removed from the > pinctrl node in the device tree, but we cannot expect all users to do that. > > Implement a similar workaround in the driver by clearing the wakeirq_map > for X1E80100. This avoids using the PDC wakeup parent for all GPIOs > and handles the interrupts directly in the pinctrl driver instead. > > The PDC driver needs additional changes to support X1E80100 properly. > Adding a workaround separately first allows to land the necessary PDC > changes through the normal release cycle, while still solving the more > critical problem with keyboard and touchpad on the current stable kernel > versions. Bypassing the PDC is enough for now, because we have not yet > enabled the deep idle states where using the PDC becomes necessary. > > Cc: stable@vger.kernel.org > Fixes: 05e4941d97ef ("pinctrl: qcom: Add X1E80100 pinctrl driver") > Signed-off-by: Stephan Gerhold Reviewed-by: Abel Vesa > --- > Commenting out .wakeirq_map as well would give an unused declaration > warning for x1e80100_pdc_map. The map itself is correct, so I just "clear" > it by setting .nwakeirq_map to 0 for now. It's just temporary - this patch > will be reverted after we add X1E80100 support to the PDC driver. > --- > drivers/pinctrl/qcom/pinctrl-x1e80100.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-x1e80100.c b/drivers/pinctrl/qcom/pinctrl-x1e80100.c > index 65ed933f05ce..abfcdd3da9e8 100644 > --- a/drivers/pinctrl/qcom/pinctrl-x1e80100.c > +++ b/drivers/pinctrl/qcom/pinctrl-x1e80100.c > @@ -1839,7 +1839,9 @@ static const struct msm_pinctrl_soc_data x1e80100_pinctrl = { > .ngroups = ARRAY_SIZE(x1e80100_groups), > .ngpios = 239, > .wakeirq_map = x1e80100_pdc_map, > - .nwakeirq_map = ARRAY_SIZE(x1e80100_pdc_map), > + /* TODO: Enabling PDC currently breaks GPIO interrupts */ > + .nwakeirq_map = 0, > + /* .nwakeirq_map = ARRAY_SIZE(x1e80100_pdc_map), */ > .egpio_func = 9, > }; > > > --- > base-commit: 128f71fe014fc91efa1407ce549f94a9a9f1072c > change-id: 20240830-x1e80100-bypass-pdc-39a8c1ae594f > > Best regards, > -- > Stephan Gerhold >