From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ye Zhang <ye.zhang@rock-chips.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, heiko@sntech.de,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
mika.westerberg@linux.intel.com, tao.huang@rock-chips.com,
finley.xiao@rock-chips.com, tim.chen@rock-chips.com,
elaine.zhang@rock-chips.com
Subject: Re: [PATCH v3 11/12] gpio: rockchip: Set input direction when request irq
Date: Tue, 3 Sep 2024 19:08:11 +0300 [thread overview]
Message-ID: <Ztc0a3uSy7HmUWYJ@smile.fi.intel.com> (raw)
In-Reply-To: <20240903073649.237362-12-ye.zhang@rock-chips.com>
On Tue, Sep 03, 2024 at 03:36:48PM +0800, Ye Zhang wrote:
> Since the GPIO can only generate interrupts when its direction is set to
> input, it is set to input before requesting the interrupt resources.
...
> static int rockchip_irq_reqres(struct irq_data *d)
> {
> + irq_hw_number_t hwirq;
> struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
> struct rockchip_pin_bank *bank = gc->private;
>
> - return gpiochip_reqres_irq(&bank->gpio_chip, d->hwirq);
> + hwirq = irqd_to_hwirq(d);
> + rockchip_gpio_direction_input(&bank->gpio_chip, hwirq);
struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
struct rockchip_pin_bank *bank = gc->private;
irq_hw_number_t hwirq = irqd_to_hwirq(d);
rockchip_gpio_direction_input(&bank->gpio_chip, hwirq);
> + return gpiochip_reqres_irq(&bank->gpio_chip, hwirq);
> }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-09-03 16:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 7:36 [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver Ye Zhang
2024-09-03 7:36 ` [PATCH v3 01/12] gpio: rockchip: avoid division by zero Ye Zhang
2024-09-03 15:53 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 02/12] gpio: rockchip: release reference to device node Ye Zhang
2024-09-03 7:36 ` [PATCH v3 03/12] gpio: rockchip: resolve overflow issues Ye Zhang
2024-09-03 7:36 ` [PATCH v3 04/12] gpio: rockchip: resolve underflow issue Ye Zhang
2024-09-03 15:55 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 05/12] gpio: rockchip: fix debounce calculate Ye Zhang
2024-09-03 7:36 ` [PATCH v3 08/12] gpio: rockchip: explan the format of the GPIO version ID Ye Zhang
2024-09-03 16:03 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 09/12] gpio: rockchip: change the GPIO version judgment logic Ye Zhang
2024-09-03 16:05 ` Andy Shevchenko
2024-09-03 7:36 ` [PATCH v3 12/12] gpio: rockchip: replace mutex_lock() with guard() Ye Zhang
2024-09-03 16:10 ` Andy Shevchenko
2024-09-03 16:52 ` Christophe JAILLET
2024-09-03 16:52 ` Christophe JAILLET
[not found] ` <20240903073649.237362-8-ye.zhang@rock-chips.com>
2024-09-03 15:59 ` [PATCH v3 07/12] gpio: rockchip: support 'clock-names' from dt nodes Andy Shevchenko
2024-09-03 16:00 ` [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver Andy Shevchenko
[not found] ` <20240903073649.237362-11-ye.zhang@rock-chips.com>
2024-09-03 16:07 ` [PATCH v3 10/12] gpio: rockchip: support new version gpio Andy Shevchenko
[not found] ` <20240903073649.237362-12-ye.zhang@rock-chips.com>
2024-09-03 16:08 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ztc0a3uSy7HmUWYJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=elaine.zhang@rock-chips.com \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=tao.huang@rock-chips.com \
--cc=tim.chen@rock-chips.com \
--cc=ye.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).