From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Martyn Welch <martyn.welch@collabora.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 2/2] gpio: mpc8xxx: switch to using DEFINE_RUNTIME_DEV_PM_OPS()
Date: Tue, 3 Sep 2024 19:23:31 +0300 [thread overview]
Message-ID: <Ztc4A0rZE3G1oHo7@smile.fi.intel.com> (raw)
In-Reply-To: <20240903154533.101258-2-brgl@bgdev.pl>
On Tue, Sep 03, 2024 at 05:45:33PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Use the preferred API for assigning system sleep pm callbacks in drivers.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Hmm... Maybe I should pay more attention when answering emails.
Please, use my @linux.intel.com address for Linux kernel contributions.
...
> #include <linux/mod_devicetable.h>
> #include <linux/of.h>
> #include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
You need pm.h as macros defined there.
> #include <linux/property.h>
> #include <linux/slab.h>
> #include <linux/spinlock.h>
...
> +static DEFINE_RUNTIME_DEV_PM_OPS(mpc8xx_pm_ops, mpc8xxx_suspend,
> + mpc8xxx_resume, NULL);
I would split logically, i.e.
static DEFINE_RUNTIME_DEV_PM_OPS(mpc8xx_pm_ops,
mpc8xxx_suspend, mpc8xxx_resume, NULL);
OR
static DEFINE_RUNTIME_DEV_PM_OPS(mpc8xx_pm_ops,
mpc8xxx_suspend, mpc8xxx_resume,
NULL);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-03 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 15:45 [PATCH 1/2] gpio: mpc8xxx: order headers alphabetically Bartosz Golaszewski
2024-09-03 15:45 ` [PATCH 2/2] gpio: mpc8xxx: switch to using DEFINE_RUNTIME_DEV_PM_OPS() Bartosz Golaszewski
2024-09-03 16:23 ` Andy Shevchenko [this message]
2024-09-03 16:25 ` Andy Shevchenko
2024-09-03 18:36 ` Bartosz Golaszewski
2024-09-04 11:40 ` Martyn Welch
2024-09-03 16:20 ` [PATCH 1/2] gpio: mpc8xxx: order headers alphabetically Andy Shevchenko
2024-09-03 17:23 ` Martyn Welch
2024-09-04 7:23 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ztc4A0rZE3G1oHo7@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).