From: Andy Shevchenko <andy@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 0/2] pinctrl: intel: platform: fix error path in device_for_each_child_node()
Date: Mon, 30 Sep 2024 14:32:19 +0300 [thread overview]
Message-ID: <ZvqMQ1O5BAmGPMxS@smile.fi.intel.com> (raw)
In-Reply-To: <20240926-intel-pinctrl-platform-scoped-v1-0-5ee4c936eea3@gmail.com>
On Thu, Sep 26, 2024 at 04:11:01PM +0200, Javier Carrasco wrote:
> This series fixes an error path where the reference of a child node is
> not decremented upon early return. When at it, a trivial comma/semicolon
> substitution I found by chance has been added to improve code clarity.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> Javier Carrasco (2):
> pinctrl: intel: platform: fix error path in device_for_each_child_node()
> pinctrl: intel: platform: use semicolon instead of comma in ncommunities assignment
>
> drivers/pinctrl/intel/pinctrl-intel-platform.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> ---
> base-commit: 92fc9636d1471b7f68bfee70c776f7f77e747b97
Try hard to avoid basing your commits on Linux Next. This is a specific
subsystem and you can just use Intel pinctrl tree for that.
No need to resend this time, I fixed the issue manually.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-09-30 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 14:11 [PATCH 0/2] pinctrl: intel: platform: fix error path in device_for_each_child_node() Javier Carrasco
2024-09-26 14:11 ` [PATCH 1/2] " Javier Carrasco
2024-09-26 14:11 ` [PATCH 2/2] pinctrl: intel: platform: use semicolon instead of comma in ncommunities assignment Javier Carrasco
2024-09-27 5:00 ` [PATCH 0/2] pinctrl: intel: platform: fix error path in device_for_each_child_node() Mika Westerberg
2024-09-30 11:32 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvqMQ1O5BAmGPMxS@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).