Re: [PATCH 07/11] pinctrl: rp1: Implement RaspberryPi RP1 gpio support

Andrea della Porta
2024-08-23T17:15:56Z

On 14:27 Wed 21 Aug , Simon Horman wrote:
> On Tue, Aug 20, 2024 at 04:36:09PM +0200, Andrea della Porta wrote:
> > The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl.
> > Add minimum support for the gpio only portion. The driver is in
> > pinctrl folder since upcoming patches will add the pinmux/pinctrl
> > support where the gpio part can be seen as an addition.
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
>
> ...
>
> > diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c
>
> ...
>
> > +const struct rp1_iobank_desc rp1_iobanks[RP1_NUM_BANKS] = {
> > + /* gpio inte ints rio pads */
> > + { 0, 28, 0x0000, 0x011c, 0x0124, 0x0000, 0x0004 },
> > + { 28, 6, 0x4000, 0x411c, 0x4124, 0x4000, 0x4004 },
> > + { 34, 20, 0x8000, 0x811c, 0x8124, 0x8000, 0x8004 },
> > +};
>
> rp1_iobanks seems to only be used in this file.
> If so, it should be static.

Fixed, thanks.

>
> Flagged by Sparse.
>
> ...