From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] gpio: Move and sort Kconfig entries as suggested
Date: Thu, 14 Nov 2024 12:39:40 +0200 [thread overview]
Message-ID: <ZzXTbEcrLigXWpAu@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=MeaDjhxAwmTcNZ+oHniFn4EWVEmfP8MdNWitmD+Rr=scA@mail.gmail.com>
On Thu, Nov 14, 2024 at 09:54:50AM +0100, Bartosz Golaszewski wrote:
> On Wed, Nov 13, 2024 at 6:12 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The Kconfig under drivers/gpio has a specific comment
> >
> > put drivers in the right section, in alphabetical order
> >
> > but in time some of the entries fell unordered there.
> > Put an order again.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> Could you elaborate on why you're moving drivers between categories?
> For instance: you moved Intel LJCA to USB drivers and I'm sure you
> have a reason for it (it's not clear if this actually is a USB driver,
This one is actually clear as you see that it depends on USB_LJCS which
suggests that it's USB based.
> it's not registered as such
Neither one of the existing ones in that category, right?
> ) but please expand on it in the commit message.
Okay, I will do in v2.
Thank you for the review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-14 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 17:12 [PATCH v1 1/1] gpio: Move and sort Kconfig entries as suggested Andy Shevchenko
2024-11-14 7:45 ` Linus Walleij
2024-11-14 8:54 ` Bartosz Golaszewski
2024-11-14 10:39 ` Andy Shevchenko [this message]
2024-11-14 11:15 ` Bartosz Golaszewski
2024-11-14 11:39 ` Andy Shevchenko
2024-11-14 12:59 ` Bartosz Golaszewski
2024-11-14 13:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzXTbEcrLigXWpAu@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox