From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D28013CFA8 for ; Thu, 14 Nov 2024 15:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731597979; cv=none; b=TxbFrfjh9yXrmUGXCa/6N/55XTywb19JESMy0/1KBB4oR4p1aAbJWdWOW60X8tvSIJiTvltIrUnbRwRBe9jslIRn05/68sMf+5vAQiyVbhVWQspwu3/nyX9oizt9q2hSJ8oPHqR1xgcfd9ntHnmICoSAPG0tAqfbEWjvYl+tqOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731597979; c=relaxed/simple; bh=OXm964+HL/oy8I5JgLPsZUm+UieJrQIuj9T2oe/JmoI=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ilLaotwyrS9xyKyTXEK9NOl58xjaIiGeZdhZk0DncTwpjiWZaSYa0DmWtKLltZamMTtFZvnNgybnhxGxpzXUWCWLeEn8zn/ofgESJ7GhREHzGNmN7SPbuS7TfB4di5dJR0dIDs9aYZy6vOAxBcuCigHjCbC9aBUKzaH3D+W1ZjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=T0lJt+QV; arc=none smtp.client-ip=209.85.218.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="T0lJt+QV" Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-a9ed49ec0f1so135416066b.1 for ; Thu, 14 Nov 2024 07:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1731597975; x=1732202775; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=BXfRuwtCQesbb+rpbVIxn9Ia55XQqIa+ED/3SCVnO+4=; b=T0lJt+QVOgMpe98LyY/OQg5CauvRzz5aZotWG53qpiINIQPfuqm94oJDgqqTpxKQpy VyPY7U+5O+0dC4OqfQqxD7ygF8MN4l31p3AAOahmwrJO8Jd/Zp5t1lx1dUKasPaKePKz 5u2zO7f6XsMG7Q/iCIl6hgyDRzi9MNPi/u0NjMCu8GgXrYxT4s+qzsU/tdKaHPLlG1TH VTNCP7uaedHsnu4AIbUmGkCMNKJZTqEaX58qEthYKW73qRLo4BdAvR/OenXR7qAz4bQm Jtb8z+RKl38uYnU4VOuJcnn7WfXWidfo4zsFFj8ZlEIoPZdxRc6NBYqiOkUt4Vg7iFb9 JjhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731597975; x=1732202775; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BXfRuwtCQesbb+rpbVIxn9Ia55XQqIa+ED/3SCVnO+4=; b=Iw6vrral1TkuE1yLMS3MMHeJxr+DkTON62clfoM0O5+laebE8MFEu8YsLD3p6nYBd+ uCAPaO674YUcdjsFYgghFgdckpi8GSCMpUyQdz65RWJ+s/o8aK9quVZRBai0y7n9w8S/ CcnYsa4KGJqBYmlgZ+I7LdrllDQIFHpF2sOmhdnUe/9x3UtujuOadBSZr2/uhnkLF/BQ rbsWOHcmxIEK56PaL5jO0YWk4z006jKhg4s3mj/RzKZUP/BvdqldMmA4kpoZoZhIGW71 uMaVIXsKNbFIZxV8FB2PIS96DEFYVMdsbJOkW0m89rMs6BX/1mm+9oDE2+6xfKiHMPOT rd+Q== X-Forwarded-Encrypted: i=1; AJvYcCUYHWtsme+S5slObZorcNxEiuggR4LuUyXp40s3mwvJ/s6FWDZ74UZSgoRSmb1x0tlJVgIGU9qdvvXf@vger.kernel.org X-Gm-Message-State: AOJu0Yy8Xy5fqYUwHj40+uRQXrl9xunm+EGijvW+uTf5GXQXTdkA6kKZ F0Q9xQMrAoNH1Jt/fOw3ILd6nQ+isDzQ9HQTrSTWw0PyuFgcf0Qbh2GJiLJpzMU= X-Google-Smtp-Source: AGHT+IGhM6/BPmoBjuRiiI1ewZRW9R+eE3BQ4H3+p/OJfSdyeRMIoasVpFD+sR2v6s9C5C6vSshsww== X-Received: by 2002:a17:907:7b95:b0:a9a:c691:dcbc with SMTP id a640c23a62f3a-aa1b1024b29mr1127309766b.12.1731597974922; Thu, 14 Nov 2024 07:26:14 -0800 (PST) Received: from localhost (host-79-19-144-50.retail.telecomitalia.it. [79.19.144.50]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20e086ad4sm73543066b.199.2024.11.14.07.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 07:26:14 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 14 Nov 2024 16:26:42 +0100 To: Andrea della Porta Cc: Herve Codina , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , stable@vger.kernel.org Subject: Re: [PATCH] PCI: of_property: Assign PCI instead of CPU bus address to dynamic PCI nodes Message-ID: References: <20241108094256.28933-1-andrea.porta@suse.com> <20241108110938.622014f5@bootlin.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi, On 11:14 Fri 08 Nov , Andrea della Porta wrote: > Hi herve, > > On 11:09 Fri 08 Nov , Herve Codina wrote: > > Hi Andrea, > > > > On Fri, 8 Nov 2024 10:42:56 +0100 > > Andrea della Porta wrote: > > > > > When populating "ranges" property for a PCI bridge or endpoint, > > > of_pci_prop_ranges() incorrectly use the CPU bus address of the resource. > > > In such PCI nodes, the window should instead be in PCI address space. Call > > > pci_bus_address() on the resource in order to obtain the PCI bus > > > address. > > > > > > Fixes: 407d1a51921e ("PCI: Create device tree node for bridge") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Andrea della Porta > > > Acked-by: Bjorn Helgaas > > > Tested-by: Herve Codina > > > --- > > > This patch, originally preparatory for a bigger patchset (see [1]), has > > > been splitted in a standalone one for better management and because it > > > contains a bugfix which is probably of interest to stable branch. > > > > Nothing to say for the patch itself. > > > > Just here, you mentioned "see [1]" but you didn't provide the link. > > > > IMHO, this is not blocking for applying the patch but, just for other people > > looking at this email in the mailing list, can you reply providing the link? > > Thanks for pointing that out, sorry about that. Here it is: > > [1] - https://lore.kernel.org/all/f6b445b764312fd8ab96745fe4e97fb22f91ae4c.1730123575.git.andrea.porta@suse.com/ Do I have to resubmit the patch with the referenced url fixed or is it ok as it is? Thanks, Andrea > > Many thanks, > Andrea > > > > > Best regards, > > Hervé