From: Philipp Zabel <p.zabel@pengutronix.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Cc: "seanga2@gmail.com" <seanga2@gmail.com>
Subject: Re: [PATCH v5 12/21] riscv: Add Canaan Kendryte K210 reset controller
Date: Wed, 09 Dec 2020 12:29:45 +0100 [thread overview]
Message-ID: <a168ae4fdf17e2f9e422354f5dadc62bcad3e4d8.camel@pengutronix.de> (raw)
In-Reply-To: <57d4ae6e06551a56e41a4d50078ef51cbad67083.camel@wdc.com>
Hi Damien,
On Wed, 2020-12-09 at 05:26 +0000, Damien Le Moal wrote:
[...]
> I added COMPILE_TEST. I also removed the RISCV dependency since SOC_CANAAN
> already depend on it (due to the SOC_EARLY_INIT_DECLARE() use in the sysctl
> driver). Stricktly speaking, I think we could also remove the SOC_CANAAN
> dependency for the reset driver, but I do not really see the point since it is
> cannot be used for any other SoC.
Thank you, this is fine. Depending on SOC_CANAAN is nice for users of
other SoCs, as they aren't shown this option to enable a kernel driver
that we know they don't need.
regards
Philipp
next prev parent reply other threads:[~2020-12-09 11:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 7:33 [PATCH v5 00/21] RISC-V Kendryte K210 support improvements Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 01/21] riscv: Fix kernel time_init() Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 02/21] riscv: Fix sifive serial driver Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 03/21] riscv: Enable interrupts during syscalls with M-Mode Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 04/21] riscv: Fix builtin DTB handling Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 05/21] riscv: Use vendor name for K210 SoC support Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 06/21] dt-bindings: Add Canaan vendor prefix Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 07/21] dt-binding: clock: Document canaan,k210-clk bindings Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 08/21] dt-bindings: reset: Document canaan,k210-rst bindings Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 09/21] dt-bindings: pinctrl: Document canaan,k210-fpioa bindings Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 10/21] dt-binding: mfd: Document canaan,k210-sysctl bindings Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 11/21] riscv: Add Canaan Kendryte K210 clock driver Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 12/21] riscv: Add Canaan Kendryte K210 reset controller Damien Le Moal
2020-12-08 11:44 ` Philipp Zabel
2020-12-09 5:26 ` Damien Le Moal
2020-12-09 11:29 ` Philipp Zabel [this message]
2020-12-08 7:33 ` [PATCH v5 13/21] riscv: Add Canaan Kendryte K210 FPIOA driver Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 14/21] riscv: Update Canaan Kendryte K210 device tree Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 15/21] riscv: Add SiPeed MAIX BiT board " Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 16/21] riscv: Add SiPeed MAIX DOCK " Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 17/21] riscv: Add SiPeed MAIX GO " Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 18/21] riscv: Add SiPeed MAIXDUINO " Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 19/21] riscv: Add Kendryte KD233 " Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 20/21] riscv: Update Canaan Kendryte K210 defconfig Damien Le Moal
2020-12-08 7:33 ` [PATCH v5 21/21] riscv: Add Canaan Kendryte K210 SD card defconfig Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a168ae4fdf17e2f9e422354f5dadc62bcad3e4d8.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Damien.LeMoal@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=seanga2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).