From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the absence of ACPI enumeration
Date: Thu, 5 Oct 2023 09:53:51 +0200 [thread overview]
Message-ID: <a244d004-e354-4917-b83d-d51158ba896d@kernel.org> (raw)
In-Reply-To: <CAHp75VeNG3cE5XmnhPyVQmR4Ppfk7CarSahU8-5Kpgg7TwLMjg@mail.gmail.com>
On 04/10/2023 21:42, Andy Shevchenko wrote:
> On Wed, Oct 4, 2023 at 4:20 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 04/10/2023 15:09, Andy Shevchenko wrote:
>>> On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>> On 26/09/2023 21:08, Andy Shevchenko wrote:
>
> ...
>
>>>>> +MODULE_ALIAS("platform:denverton-pinctrl");
>>>>
>>>> Why do you need the alias? It's the same as ID table. You most likely
>>>> miss MODULE_DEVICE_TABLE() or your table is just wrong.
>>>
>>> This is cargo cult from pinctrl-broxton.c. If we want to fix, we need
>>> to fix both.
>>> Care to send patches?
>>
>> I don't understand how some other file affects this. Why do you exactly
>> need module alias here? Which use-case does not work without it (after
>> adding proper MODULE_DEVICE_TABLE())?
>
> We try to keep these drivers uniform. So, if something should be done
> differently, it should be done for all affected drivers.
> Since patch is applied, now we have two drivers to improve.
Awesome reason. So if you add accidentally bug to one driver, it should
be copied to other file as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-05 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 19:08 [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the absence of ACPI enumeration Andy Shevchenko
2023-09-27 7:43 ` Mika Westerberg
2023-09-27 12:19 ` Andy Shevchenko
2023-10-04 8:18 ` Krzysztof Kozlowski
2023-10-04 13:09 ` Andy Shevchenko
2023-10-04 13:20 ` Krzysztof Kozlowski
2023-10-04 19:42 ` Andy Shevchenko
2023-10-05 7:53 ` Krzysztof Kozlowski [this message]
2023-10-05 8:38 ` Andy Shevchenko
2023-10-05 8:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a244d004-e354-4917-b83d-d51158ba896d@kernel.org \
--to=krzk@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).