From: Florian Fainelli <f.fainelli@gmail.com>
To: Xiang wangx <wangxiang@cdjrlc.com>, linus.walleij@linaro.org
Cc: rjui@broadcom.com, brgl@bgdev.pl, f.fainelli@gmail.com,
sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: bcm-kona:add const to of_device_id
Date: Thu, 9 Dec 2021 08:59:23 -0800 [thread overview]
Message-ID: <a3057939-25a2-5d4e-1b38-54436db6560c@gmail.com> (raw)
In-Reply-To: <20211209131245.23172-1-wangxiang@cdjrlc.com>
On 12/9/21 5:12 AM, Xiang wangx wrote:
> struct of_device_id should normally be const.
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Would be nice to add a space in the subject and do:
gpio: bcm-kona: add const to of_device_id
While applying if not asking too much from maintainers ;)
--
Florian
prev parent reply other threads:[~2021-12-09 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 13:12 [PATCH] gpio: bcm-kona:add const to of_device_id Xiang wangx
2021-12-09 16:59 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3057939-25a2-5d4e-1b38-54436db6560c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wangxiang@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).