* [PATCH] gpio: bcm-kona:add const to of_device_id
@ 2021-12-09 13:12 Xiang wangx
2021-12-09 16:59 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Xiang wangx @ 2021-12-09 13:12 UTC (permalink / raw)
To: linus.walleij
Cc: rjui, brgl, f.fainelli, sbranden, bcm-kernel-feedback-list,
linux-gpio, linux-kernel, Xiang wangx
struct of_device_id should normally be const.
Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
---
drivers/gpio/gpio-bcm-kona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index d329a143f5ec..9cb3587d1441 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -505,7 +505,7 @@ static struct irq_chip bcm_gpio_irq_chip = {
.irq_release_resources = bcm_kona_gpio_irq_relres,
};
-static struct of_device_id const bcm_kona_gpio_of_match[] = {
+static const struct of_device_id const bcm_kona_gpio_of_match[] = {
{ .compatible = "brcm,kona-gpio" },
{}
};
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: bcm-kona:add const to of_device_id
2021-12-09 13:12 [PATCH] gpio: bcm-kona:add const to of_device_id Xiang wangx
@ 2021-12-09 16:59 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2021-12-09 16:59 UTC (permalink / raw)
To: Xiang wangx, linus.walleij
Cc: rjui, brgl, f.fainelli, sbranden, bcm-kernel-feedback-list,
linux-gpio, linux-kernel
On 12/9/21 5:12 AM, Xiang wangx wrote:
> struct of_device_id should normally be const.
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Would be nice to add a space in the subject and do:
gpio: bcm-kona: add const to of_device_id
While applying if not asking too much from maintainers ;)
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-09 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-09 13:12 [PATCH] gpio: bcm-kona:add const to of_device_id Xiang wangx
2021-12-09 16:59 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).