From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: gpio: gpio-vf610: Add parsing of hogs
Date: Fri, 9 Jun 2023 15:12:16 +0200 [thread overview]
Message-ID: <a305a727-e1e1-00a5-5e1c-a04592ad45dd@linaro.org> (raw)
In-Reply-To: <2442502.irdbgypaU6@steina-w>
On 09/06/2023 14:27, Alexander Stein wrote:
> Am Freitag, 9. Juni 2023, 14:15:53 CEST schrieb Krzysztof Kozlowski:
>> On 09/06/2023 14:10, Alexander Stein wrote:
>>> Allow parsing GPIO controller children nodes with GPIO hogs.
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>> This implements the same as commit dfb49cc231a48 ("dt-bindings: gpio:
>>> fsl-imx-gpio: Add parsing of hogs") and reuses the commit message as
>>> well.
>>
>> But it was suboptimal. Do it like in commit 6c19974d1e83 ("dt-bindings:
>> gpio: Convert STMPE GPIO to YAML schema"), including also narrower pattern.
>
> Ah, thanks. I wasn't aware it is part of generic dt-schema.
> Regarding the narrower pattern: dt-schema still uses the wider one. Is this
> still correct or something which needs to be fixed?
dtschema must have wider pattern as it covers everything, all boards.
If existing DTS fits narrower pattern, make it narrower. It helps
keeping code consistent thus easier to read.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-09 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 12:10 [PATCH 1/1] dt-bindings: gpio: gpio-vf610: Add parsing of hogs Alexander Stein
2023-06-09 12:15 ` Krzysztof Kozlowski
2023-06-09 12:27 ` Alexander Stein
2023-06-09 13:12 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a305a727-e1e1-00a5-5e1c-a04592ad45dd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).