[PATCH 0/3] gpio: idio-16: Fix regmap initialization errors

[PATCH 0/3] gpio: idio-16: Fix regmap initialization errors

[William Breathitt Gray]

The migration of IDIO-16 GPIO drivers to the regmap API resulted in some
regressions to the gpio-104-idio-16, gpio-pci-idio-16, and gpio-idio-16
modules. Specifically, the 104-idio-16 and pci-idio-16 GPIO drivers
utilize regmap caching and thus must set max_register for their
regmap_config, while gpio-idio-16 requires fixed_direction_output to
represent the fixed direction of the IDIO-16 GPIO lines. Fixes for these
regressions are provided by this series.

Link: https://lore.kernel.org/r/cover.1680618405.git.william.gray@linaro.org
Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
---
William Breathitt Gray (3):
      gpio: 104-idio-16: Define maximum valid register address offset
      gpio: pci-idio-16: Define maximum valid register address offset
      gpio: idio-16: Define fixed direction of the GPIO lines

 drivers/gpio/gpio-104-idio-16.c | 1 +
 drivers/gpio/gpio-idio-16.c     | 5 +++++
 drivers/gpio/gpio-pci-idio-16.c | 1 +
 3 files changed, 7 insertions(+)
---
base-commit: eba11116f39533d2e38cc5898014f2c95f32d23a
change-id: 20251017-fix-gpio-idio-16-regmap-1282cdc56a19

Best regards,
-- 
William Breathitt Gray <wbg@kernel.org>

[PATCH 1/3] gpio: 104-idio-16: Define maximum valid register address offset

[William Breathitt Gray]

Attempting to load the 104-idio-16 module fails during regmap
initialization with a return error -EINVAL. This is a result of the
regmap cache failing initialization. Set the idio_16_regmap_config
max_register member to fix this failure.

Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
Suggested-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Cc: stable@vger.kernel.org
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
---
 drivers/gpio/gpio-104-idio-16.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c
index ffe7e1cb6b238856b9d13b2a278fe6c44b9cc8d3..fe5c10cd5c327ace1b715e9a27590211dce06fb0 100644
--- a/drivers/gpio/gpio-104-idio-16.c
+++ b/drivers/gpio/gpio-104-idio-16.c
@@ -59,6 +59,7 @@ static const struct regmap_config idio_16_regmap_config = {
 	.reg_stride = 1,
 	.val_bits = 8,
 	.io_port = true,
+	.max_register = 0x5,
 	.wr_table = &idio_16_wr_table,
 	.rd_table = &idio_16_rd_table,
 	.volatile_table = &idio_16_rd_table,

-- 
2.51.0

[PATCH 2/3] gpio: pci-idio-16: Define maximum valid register address offset

[William Breathitt Gray]

Attempting to load the pci-idio-16 module fails during regmap
initialization with a return error -EINVAL. This is a result of the
regmap cache failing initialization. Set the idio_16_regmap_config
max_register member to fix this failure.

Fixes: 73d8f3efc5c2 ("gpio: pci-idio-16: Migrate to the regmap API")
Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
Suggested-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Cc: stable@vger.kernel.org
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
---
 drivers/gpio/gpio-pci-idio-16.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-pci-idio-16.c b/drivers/gpio/gpio-pci-idio-16.c
index 476cea1b5ed774d18511aaf71d8ca2d71bcc9ff0..9d28ca8e1d6fac4bdc105b850583607b5e5a87ea 100644
--- a/drivers/gpio/gpio-pci-idio-16.c
+++ b/drivers/gpio/gpio-pci-idio-16.c
@@ -41,6 +41,7 @@ static const struct regmap_config idio_16_regmap_config = {
 	.reg_stride = 1,
 	.val_bits = 8,
 	.io_port = true,
+	.max_register = 0x7,
 	.wr_table = &idio_16_wr_table,
 	.rd_table = &idio_16_rd_table,
 	.volatile_table = &idio_16_rd_table,

-- 
2.51.0

[PATCH 3/3] gpio: idio-16: Define fixed direction of the GPIO lines

[William Breathitt Gray]

The direction of the IDIO-16 GPIO lines is fixed with the first 16 lines
as output and the remaining 16 lines as input. Set the gpio_config
fixed_direction_output member to represent the fixed direction of the
GPIO lines.

Fixes: db02247827ef ("gpio: idio-16: Migrate to the regmap API")
Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
Suggested-by: Michael Walle <mwalle@kernel.org>
Cc: stable@vger.kernel.org # ae495810cffe: gpio: regmap: add the .fixed_direction_output configuration parameter
Cc: stable@vger.kernel.org
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
---
 drivers/gpio/gpio-idio-16.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpio/gpio-idio-16.c b/drivers/gpio/gpio-idio-16.c
index 0103be977c66bb8d165c1c92123368be6832d120..4fbae6f6a49727df40f2793b42ca207d78ec272b 100644
--- a/drivers/gpio/gpio-idio-16.c
+++ b/drivers/gpio/gpio-idio-16.c
@@ -6,6 +6,7 @@
 
 #define DEFAULT_SYMBOL_NAMESPACE "GPIO_IDIO_16"
 
+#include <linux/bitmap.h>
 #include <linux/bits.h>
 #include <linux/device.h>
 #include <linux/err.h>
@@ -107,6 +108,7 @@ int devm_idio_16_regmap_register(struct device *const dev,
 	struct idio_16_data *data;
 	struct regmap_irq_chip *chip;
 	struct regmap_irq_chip_data *chip_data;
+	DECLARE_BITMAP(fixed_direction_output, IDIO_16_NGPIO);
 
 	if (!config->parent)
 		return -EINVAL;
@@ -164,6 +166,9 @@ int devm_idio_16_regmap_register(struct device *const dev,
 	gpio_config.irq_domain = regmap_irq_get_domain(chip_data);
 	gpio_config.reg_mask_xlate = idio_16_reg_mask_xlate;
 
+	bitmap_from_u64(fixed_direction_output, GENMASK_U64(15, 0));
+	gpio_config.fixed_direction_output = fixed_direction_output;
+
 	return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(dev, &gpio_config));
 }
 EXPORT_SYMBOL_GPL(devm_idio_16_regmap_register);

-- 
2.51.0

Re: [PATCH 0/3] gpio: idio-16: Fix regmap initialization errors

[Bartosz Golaszewski]

On Fri, Oct 17, 2025 at 2:58 AM William Breathitt Gray <wbg@kernel.org> wrote:
>
> The migration of IDIO-16 GPIO drivers to the regmap API resulted in some
> regressions to the gpio-104-idio-16, gpio-pci-idio-16, and gpio-idio-16
> modules. Specifically, the 104-idio-16 and pci-idio-16 GPIO drivers
> utilize regmap caching and thus must set max_register for their
> regmap_config, while gpio-idio-16 requires fixed_direction_output to
> represent the fixed direction of the IDIO-16 GPIO lines. Fixes for these
> regressions are provided by this series.
>
> Link: https://lore.kernel.org/r/cover.1680618405.git.william.gray@linaro.org
> Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
> Signed-off-by: William Breathitt Gray <wbg@kernel.org>
> ---
> William Breathitt Gray (3):
>       gpio: 104-idio-16: Define maximum valid register address offset
>       gpio: pci-idio-16: Define maximum valid register address offset
>       gpio: idio-16: Define fixed direction of the GPIO lines
>
>  drivers/gpio/gpio-104-idio-16.c | 1 +
>  drivers/gpio/gpio-idio-16.c     | 5 +++++
>  drivers/gpio/gpio-pci-idio-16.c | 1 +
>  3 files changed, 7 insertions(+)
> ---
> base-commit: eba11116f39533d2e38cc5898014f2c95f32d23a
> change-id: 20251017-fix-gpio-idio-16-regmap-1282cdc56a19
>
> Best regards,
> --
> William Breathitt Gray <wbg@kernel.org>
>
>

Please use get_maintainer.pl or b4 --auto-to-cc. This is the address
I'm using for reviews.

Bartosz

Re: [PATCH 1/3] gpio: 104-idio-16: Define maximum valid register address offset

[Andy Shevchenko]

On Fri, Oct 17, 2025 at 09:58:01AM +0900, William Breathitt Gray wrote:
> Attempting to load the 104-idio-16 module fails during regmap
> initialization with a return error -EINVAL. This is a result of the
> regmap cache failing initialization. Set the idio_16_regmap_config
> max_register member to fix this failure.

> Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
> Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com

Link --> Closes ?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/3] gpio: 104-idio-16: Define maximum valid register address offset

[Andy Shevchenko]

On Sat, Oct 18, 2025 at 10:00:44PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 17, 2025 at 09:58:01AM +0900, William Breathitt Gray wrote:
> > Attempting to load the 104-idio-16 module fails during regmap
> > initialization with a return error -EINVAL. This is a result of the
> > regmap cache failing initialization. Set the idio_16_regmap_config
> > max_register member to fix this failure.
> 
> > Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
> > Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> > Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
> 
> Link --> Closes ?

Seems for all patches in the series :-)

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/3] gpio: idio-16: Fix regmap initialization errors

[Andy Shevchenko]

On Fri, Oct 17, 2025 at 09:58:00AM +0900, William Breathitt Gray wrote:
> The migration of IDIO-16 GPIO drivers to the regmap API resulted in some
> regressions to the gpio-104-idio-16, gpio-pci-idio-16, and gpio-idio-16
> modules. Specifically, the 104-idio-16 and pci-idio-16 GPIO drivers
> utilize regmap caching and thus must set max_register for their
> regmap_config, while gpio-idio-16 requires fixed_direction_output to
> represent the fixed direction of the IDIO-16 GPIO lines. Fixes for these
> regressions are provided by this series.

With commit message amendment and Cc list (as per Bart's message),
feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/3] gpio: 104-idio-16: Define maximum valid register address offset

[William Breathitt Gray]

On Sat, Oct 18, 2025 at 10:00:43PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 17, 2025 at 09:58:01AM +0900, William Breathitt Gray wrote:
> > Attempting to load the 104-idio-16 module fails during regmap
> > initialization with a return error -EINVAL. This is a result of the
> > regmap cache failing initialization. Set the idio_16_regmap_config
> > max_register member to fix this failure.
> 
> > Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
> > Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> > Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
> 
> Link --> Closes ?

So that link points to a report detailing multiple bugs, but this patch
only fixes one of those bugs. Is it still appropriate to use Closes in
this case?

William Breathitt Gray

Re: [PATCH 1/3] gpio: 104-idio-16: Define maximum valid register address offset

[Andy Shevchenko]

On Sun, Oct 19, 2025 at 08:44:09AM +0900, William Breathitt Gray wrote:
> On Sat, Oct 18, 2025 at 10:00:43PM +0300, Andy Shevchenko wrote:
> > On Fri, Oct 17, 2025 at 09:58:01AM +0900, William Breathitt Gray wrote:
> > > Attempting to load the 104-idio-16 module fails during regmap
> > > initialization with a return error -EINVAL. This is a result of the
> > > regmap cache failing initialization. Set the idio_16_regmap_config
> > > max_register member to fix this failure.
> > 
> > > Fixes: 2c210c9a34a3 ("gpio: 104-idio-16: Migrate to the regmap API")
> > > Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> > > Link: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
> > 
> > Link --> Closes ?
> 
> So that link points to a report detailing multiple bugs, but this patch
> only fixes one of those bugs. Is it still appropriate to use Closes in
> this case?

I believe it works in m:n cases, at least I saw in practice several patches
(was a series) were closing the same report.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/3] gpio: idio-16: Fix regmap initialization errors

[Mark Cave-Ayland]

On 17/10/2025 01:58, William Breathitt Gray wrote:

> The migration of IDIO-16 GPIO drivers to the regmap API resulted in some
> regressions to the gpio-104-idio-16, gpio-pci-idio-16, and gpio-idio-16
> modules. Specifically, the 104-idio-16 and pci-idio-16 GPIO drivers
> utilize regmap caching and thus must set max_register for their
> regmap_config, while gpio-idio-16 requires fixed_direction_output to
> represent the fixed direction of the IDIO-16 GPIO lines. Fixes for these
> regressions are provided by this series.
> 
> Link: https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_r_cover.1680618405.git.william.gray-40linaro.org&d=DwICaQ&c=s883GpUCOChKOHiocYtGcg&r=c23RpsaH4D2MKyD3EPJTDa0BAxz6tV8aUJqVSoytEiY&m=jPr0Xfn4RnLqz8K-AnYL3uVFBDeN1vNtIrFMqrmT_BE2JM3DrvRhmVaaWZ_FAMEI&s=gNMoDpPUYhiozXkA1xYUBX5tmpjg0fiDQC90QRkvRXA&e=
> Link: https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_r_9b0375fd-2D235f-2D4ee1-2Da7fa-2Ddaca296ef6bf-40nutanix.com&d=DwICaQ&c=s883GpUCOChKOHiocYtGcg&r=c23RpsaH4D2MKyD3EPJTDa0BAxz6tV8aUJqVSoytEiY&m=jPr0Xfn4RnLqz8K-AnYL3uVFBDeN1vNtIrFMqrmT_BE2JM3DrvRhmVaaWZ_FAMEI&s=HEyyhsUTLo9USpHvPuhCvAdAykzqkrkRNay7bNDtPaY&e=
> Signed-off-by: William Breathitt Gray <wbg@kernel.org>
> ---
> William Breathitt Gray (3):
>        gpio: 104-idio-16: Define maximum valid register address offset
>        gpio: pci-idio-16: Define maximum valid register address offset
>        gpio: idio-16: Define fixed direction of the GPIO lines
> 
>   drivers/gpio/gpio-104-idio-16.c | 1 +
>   drivers/gpio/gpio-idio-16.c     | 5 +++++
>   drivers/gpio/gpio-pci-idio-16.c | 1 +
>   3 files changed, 7 insertions(+)
> ---
> base-commit: eba11116f39533d2e38cc5898014f2c95f32d23a
> change-id: 20251017-fix-gpio-idio-16-regmap-1282cdc56a19
> 
> Best regards,

Hi William,

Thanks for the patches! I've given them a test here, and everything now 
appears to be working as it should in our test environment:

root@debian12:~# gpioinfo
gpiochip0 - 32 lines:
	line   0:       "OUT0"       unused  output  active-high
	line   1:       "OUT1"       unused  output  active-high
	line   2:       "OUT2"       unused  output  active-high
	line   3:       "OUT3"       unused  output  active-high
	line   4:       "OUT4"       unused  output  active-high
	line   5:       "OUT5"       unused  output  active-high
	line   6:       "OUT6"       unused  output  active-high
	line   7:       "OUT7"       unused  output  active-high
	line   8:       "OUT8"       unused  output  active-high
	line   9:       "OUT9"       unused  output  active-high
	line  10:      "OUT10"       unused  output  active-high
	line  11:      "OUT11"       unused  output  active-high
	line  12:      "OUT12"       unused  output  active-high
	line  13:      "OUT13"       unused  output  active-high
	line  14:      "OUT14"       unused  output  active-high
	line  15:      "OUT15"       unused  output  active-high
	line  16:       "IIN0"       unused   input  active-high
	line  17:       "IIN1"       unused   input  active-high
	line  18:       "IIN2"       unused   input  active-high
	line  19:       "IIN3"       unused   input  active-high
	line  20:       "IIN4"       unused   input  active-high
	line  21:       "IIN5"       unused   input  active-high
	line  22:       "IIN6"       unused   input  active-high
	line  23:       "IIN7"       unused   input  active-high
	line  24:       "IIN8"       unused   input  active-high
	line  25:       "IIN9"       unused   input  active-high
	line  26:      "IIN10"       unused   input  active-high
	line  27:      "IIN11"       unused   input  active-high
	line  28:      "IIN12"       unused   input  active-high
	line  29:      "IIN13"       unused   input  active-high
	line  30:      "IIN14"       unused   input  active-high
	line  31:      "IIN15"       unused   input  active-high

The line directions are correct and I've confirmed that I can set and 
clear outputs and read the corresponding inputs, so from my viewpoint:

Tested-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>


ATB,

Mark.