From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.io Subject: Re: [linux-sunxi] Re: [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Date: Fri, 07 Jul 2017 07:21:19 +0800 Message-ID: References: <20170706142822.20296-1-icenowy@aosc.io> <20170706142822.20296-2-icenowy@aosc.io> <20170706204646.3akr57fo6c2ok4wn@flea> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from hermes.aosc.io ([199.195.250.187]:53063 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbdGFXVV (ORCPT ); Thu, 6 Jul 2017 19:21:21 -0400 In-Reply-To: <20170706204646.3akr57fo6c2ok4wn@flea> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: maxime.ripard@free-electrons.com Cc: Linus Walleij , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com 在 2017-07-07 04:46，Maxime Ripard 写道： > Hi, > > On Thu, Jul 06, 2017 at 10:28:21PM +0800, Icenowy Zheng wrote: >> The PH16 pin has a function with mux id 0x5, which is the DET pin of >> the >> "sim" (smart card reader) IP block. >> >> This function is missing both in the old A10 and A20 drivers, so it's >> not found during the merge of these two drivers. >> >> Add it to the driver. As we now merged A20 pinctrl driver to the A10 >> one, we need to only fix the A10 driver now. >> >> Signed-off-by: Icenowy Zheng > > I'm not sure what you mean there. It's not mentionned in the A10 > datasheet, and neither in the A20. Where did you get that info from? It's mentioned in all newest datasheets: "A10 Datasheet V1.70.pdf" and "A20 Datasheet V1.41 20131230.pdf". > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com