From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sricharan Ramabadhran <quic_srichara@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, linus.walleij@linaro.org,
quic_varada@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH] pinctrl: qcom: Remove the unused _groups variable build warning
Date: Mon, 24 Jul 2023 21:09:57 +0200 [thread overview]
Message-ID: <a9f20ae3-74a3-fe3a-7de5-a57eb2d5aa81@kernel.org> (raw)
In-Reply-To: <1689934361-32642-1-git-send-email-quic_srichara@quicinc.com>
On 21/07/2023 12:12, Sricharan Ramabadhran wrote:
> When building with clang toolchain and arm64-randconfig-r015-20230712
> kernel test robot reports the below warning.
>
> drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable]
> static const char * const _groups[] = {
> ^
> 1 warning generated.
>
> static const char * const _groups[] = {
> "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
> "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
> "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
> "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
> "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
> "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
> "gpio43", "gpio44", "gpio45", "gpio46",
> };
>
> Fixing it by removing the variable.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307120814.vWPY6URk-lkp@intel.com/
> Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver")
> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
This seems to be a duplicate of gpio_groups, so:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-24 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 10:12 [PATCH] pinctrl: qcom: Remove the unused _groups variable build warning Sricharan Ramabadhran
2023-07-21 20:27 ` Nick Desaulniers
2023-07-24 19:09 ` Krzysztof Kozlowski [this message]
2023-08-07 9:02 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9f20ae3-74a3-fe3a-7de5-a57eb2d5aa81@kernel.org \
--to=krzk@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).