From: Jonathan Santos <jonath4nns@gmail.com>
To: David Lechner <dlechner@baylibre.com>
Cc: 1aff0f813bb3fee55c5483be860b6885abdb81e5.1747175187.git.Jonathan.Santos@analog.com,
Jonathan Santos <Jonathan.Santos@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
andy@kernel.org, nuno.sa@analog.com,
Michael.Hennerich@analog.com, marcelo.schmitt@analog.com,
jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, marcelo.schmitt1@gmail.com,
linus.walleij@linaro.org, brgl@bgdev.pl, lgirdwood@gmail.com,
broonie@kernel.org, Pop Paul <paul.pop@analog.com>
Subject: Re: [PATCH v8 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes
Date: Mon, 19 May 2025 19:31:30 -0300 [thread overview]
Message-ID: <aCuxQgCPgeFAqwWh@JSANTO12-L01.ad.analog.com> (raw)
In-Reply-To: <4843ec52-57e2-418a-b640-8e05ba60959e@baylibre.com>
On 05/19, David Lechner wrote:
> On 5/19/25 12:13 PM, Jonathan Santos wrote:
> > On 05/15, Jonathan Santos wrote:
>
> ...
> >> +
> >> +/* Decimation Rate range for each filter type */
> >> +static const int ad7768_dec_rate_range[][3] = {
> >> + [AD7768_FILTER_SINC5] = { 8, 8, 1024 },
> >> + [AD7768_FILTER_SINC3] = { 32, 32, 163840 },
> >> + [AD7768_FILTER_WIDEBAND] = { 32, 32, 1024 },
> >> + [AD7768_FILTER_SINC3_REJ60] = { 32, 32, 163840 },
> >> +};
> >> +
> >
> > Since we're still discussing some points — is the `step` in
> > `[min step max]` for the IIO range additive or multiplicative? It is not
> > clear on documentation, maybe on purpose or I have missed something.
> >
> > Here, decimation/OSR doubles from 8 or 32 for SINC5/WIDEBAND, and is a
> > multiple of 32 for SINC3. So I'm still unsure how to represent this to be
> > clear to the user.
>
> Sounds to me like sinc5/wideband should be lists instead of ranges.
> It is only 6 values.
So can we mix lists and ranges for the same attribute? I see that this
is not usual.
>
>
next prev parent reply other threads:[~2025-05-19 22:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 21:11 [PATCH v8 00/11] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-05-15 21:12 ` [PATCH v8 01/11] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-05-15 21:12 ` [PATCH v8 02/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-05-15 21:12 ` [PATCH v8 03/11] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 04/11] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 05/11] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 06/11] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 07/11] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-05-16 9:24 ` Andy Shevchenko
2025-05-15 21:13 ` [PATCH v8 08/11] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-05-15 22:46 ` David Lechner
2025-05-16 9:29 ` Andy Shevchenko
2025-05-18 16:58 ` Jonathan Cameron
2025-05-24 0:00 ` Jonathan Santos
2025-05-25 9:41 ` Jonathan Cameron
2025-05-15 21:14 ` [PATCH v8 09/11] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-05-15 21:14 ` [PATCH v8 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-05-16 9:34 ` Andy Shevchenko
2025-05-18 17:03 ` Jonathan Cameron
2025-05-19 17:13 ` Jonathan Santos
2025-05-19 20:15 ` David Lechner
2025-05-19 22:31 ` Jonathan Santos [this message]
2025-05-25 9:44 ` Jonathan Cameron
2025-05-15 21:14 ` [PATCH v8 11/11] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-05-16 9:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCuxQgCPgeFAqwWh@JSANTO12-L01.ad.analog.com \
--to=jonath4nns@gmail.com \
--cc=1aff0f813bb3fee55c5483be860b6885abdb81e5.1747175187.git.Jonathan.Santos@analog.com \
--cc=4843ec52-57e2-418a-b640-8e05ba60959e@baylibre.com \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=paul.pop@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).