From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C10B17C224 for ; Sat, 14 Jun 2025 11:17:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749899842; cv=none; b=shUEinmXwxS9mivLyCxt4ZGykg/MaZiBDwW4Bo/yH79JwfGjQwcZk8mW0/96vIAfUBRaHdbRvdHSbDvuKveQbdf7Coah8Ab7huTEzbRq9Rk0rPWHeQpvhV0rNw8Ezos7Vha9JG0Uog50OmRHdsMDg2dCRJZJNM/SgMjcce2RGxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749899842; c=relaxed/simple; bh=d4gNp/0M9SMRUX5Vo9jyFaZjMh959oqzUg9NU3r341s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PP4cIfsjw8KwKIkyJN3LeZR02mb7oR49vfVwk3QlGJ2LM5ioll/J1mcSeugBircR5g8xwRxLwzNANjLjgsFPK6b1xCtsFArIZGCldQZUcQrLtbD+HYwp8ooFIw7qZDjJe1Yo1MQp0xQy06O4bwsL+yTobBPWTwO9Pk2NBg7Nsvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net; spf=pass smtp.mailfrom=posteo.net; dkim=pass (3072-bit key) header.d=posteo.net header.i=@posteo.net header.b=Lca7QKh6; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (3072-bit key) header.d=posteo.net header.i=@posteo.net header.b="Lca7QKh6" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 170DB24002B for ; Sat, 14 Jun 2025 13:17:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=1984.ea087b; t=1749899832; bh=d4gNp/0M9SMRUX5Vo9jyFaZjMh959oqzUg9NU3r341s=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=Lca7QKh6j957WM9z2uGhxtJ0SvljdRqwb2jlCuWb67exWTonQombxmqnjTCtYsFh5 6wowc8OD7y1uR6Sw0DHc7nc4rp52t+Rbn3jb8JHD0rUjXbYpYuHB6gfPsHghCVQg1k eoJ2CP6AwhUzFU59QB2uLKmOd0CwOSpJvr0YtHsIyquoZKeJuhyOZNpWCPA4H4ipdP KEYfc6osVgjdgmG7N53P3rDmLbHF3QmOvxWttVVH1aYepo6ts9ge+t/1ITkpW3xiIE OHDYljxwR+Lhl8ZCW+tPbDXSFrQr2DSLCWhJX3lyb+i+/pdDQS+Ax41Ro/PF3TLz9K y2dTiXxYmjplrVYGQDEaSFRCtGqFFCT9vExXL/7K/c1Y2Z6bK2+IJ6VSkVp5GvKZjh Bn/uUwVyKxJfvKsYREBojzFDxPlooV9wHrXo+vNfSvVFZ3+IvmSSjjFfG6mUDw76eY lsDFOq2AlyLTUZ+oeOO8HjF1lzN2TVUesC7UWC4oFZB9vL+7jLv Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4bKDHh1hfPz6tsf; Sat, 14 Jun 2025 13:17:04 +0200 (CEST) Date: Sat, 14 Jun 2025 11:17:03 +0000 From: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= To: Krzysztof Kozlowski Cc: Linus Walleij , Basavaraj Natikar , Shyam Sundar S K , Andrew Jeffery , Joel Stanley , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , Ray Jui , Scott Branden , Geert Uytterhoeven , David Rhodes , Richard Fitzgerald , Charles Keepax , Lorenzo Bianconi , Sean Wang , Jesper Nilsson , Lars Persson , Damien Le Moal , Vladimir Zapolskiy , Michal Simek , Emil Renner Berthing , Jianlong Huang , Hal Feng , Matthias Brugger , AngeloGioacchino Del Regno , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Manivannan Sadhasivam , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@axis.com, linux-riscv@lists.infradead.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 06/17] pinctrl: nuvoton: Constify static 'pinctrl_desc' Message-ID: References: <20250611-pinctrl-const-desc-v2-0-b11c1d650384@linaro.org> <20250611-pinctrl-const-desc-v2-6-b11c1d650384@linaro.org> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250611-pinctrl-const-desc-v2-6-b11c1d650384@linaro.org> On Wed, Jun 11, 2025 at 08:13:38AM +0200, Krzysztof Kozlowski wrote: > The local static 'struct pinctrl_desc' is not modified, so can be made > const for code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: J. Neuschäfer Thanks! > --- > drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 +- > drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 2 +- > drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c > index dfd32feb34286b7a4d807e9033a11f507e277dce..b8872d8f5930ad931dad208afec4e08a23c3d653 100644 > --- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c > +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c > @@ -1817,7 +1817,7 @@ static const struct pinconf_ops npcm7xx_pinconf_ops = { > }; > > /* pinctrl_desc */ > -static struct pinctrl_desc npcm7xx_pinctrl_desc = { > +static const struct pinctrl_desc npcm7xx_pinctrl_desc = { > .name = "npcm7xx-pinctrl", > .pins = npcm7xx_pins, > .npins = ARRAY_SIZE(npcm7xx_pins), > diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c > index be3db8ab406c416f0709d06eb864e33e3208541a..3c3b9d8d3681c64c21927615e1bb49f157f156b5 100644 > --- a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c > +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c > @@ -2299,7 +2299,7 @@ static const struct pinconf_ops npcm8xx_pinconf_ops = { > }; > > /* pinctrl_desc */ > -static struct pinctrl_desc npcm8xx_pinctrl_desc = { > +static const struct pinctrl_desc npcm8xx_pinctrl_desc = { > .name = "npcm8xx-pinctrl", > .pins = npcm8xx_pins, > .npins = ARRAY_SIZE(npcm8xx_pins), > diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c > index 4264ca749175a2ce0f3603c1d7aa271d98e6cd89..8d8314ba0e4cb55db2b1d3adf2de07e6fb93c279 100644 > --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c > +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c > @@ -989,7 +989,7 @@ static const struct pinconf_ops wpcm450_pinconf_ops = { > .pin_config_set = wpcm450_config_set, > }; > > -static struct pinctrl_desc wpcm450_pinctrl_desc = { > +static const struct pinctrl_desc wpcm450_pinctrl_desc = { > .name = "wpcm450-pinctrl", > .pins = wpcm450_pins, > .npins = ARRAY_SIZE(wpcm450_pins), > > -- > 2.45.2 >