From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Magnus Damm <magnus.damm@gmail.com>,
linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] gpio: rcar: Use new line value setter callbacks
Date: Fri, 13 Jun 2025 11:00:38 +0200 [thread overview]
Message-ID: <aEvotoVqitiHxgYA@shikoro> (raw)
In-Reply-To: <b648ffcfe6268d3886b134a98908b2f91dbece56.1749801865.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
> bankmask = mask[0] & GENMASK(chip->ngpio - 1, 0);
> if (!bankmask)
> - return;
> + return 0;
Doesn't that mean that the mask is invalid and we could return an error
here? Or is '!bankmask' an expected use-case?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-06-13 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 8:09 [PATCH] gpio: rcar: Use new line value setter callbacks Geert Uytterhoeven
2025-06-13 9:00 ` Wolfram Sang [this message]
2025-06-13 12:02 ` Geert Uytterhoeven
2025-06-17 9:06 ` Bartosz Golaszewski
2025-06-17 9:12 ` Geert Uytterhoeven
2025-06-17 9:13 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEvotoVqitiHxgYA@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=brgl@bgdev.pl \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox