From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH 2/2] gpio: make gpiod_is_equal() arguments stricter
Date: Sat, 21 Jun 2025 22:12:41 +0300 [thread overview]
Message-ID: <aFcEKWZvRKQRA6dl@surfacebook.localdomain> (raw)
In-Reply-To: <20250620-gpiod-is-equal-improv-v1-2-a75060505d2c@linaro.org>
Fri, Jun 20, 2025 at 02:58:02PM +0200, Bartosz Golaszewski kirjoitti:
>
> It makes no sense for a GPIO descriptor comparator to return true when
> the arguments passed to it are NULL or IS_ERR(). Let's validate both and
> return false unless both are valid GPIO descriptors.
Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-21 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 12:58 [PATCH 0/2] gpio: improve gpiod_is_equal() Bartosz Golaszewski
2025-06-20 12:58 ` [PATCH 1/2] gpio: constify arguments of gpiod_is_equal() Bartosz Golaszewski
2025-06-20 12:58 ` [PATCH 2/2] gpio: make gpiod_is_equal() arguments stricter Bartosz Golaszewski
2025-06-21 19:12 ` Andy Shevchenko [this message]
2025-06-24 19:25 ` Linus Walleij
2025-06-30 6:58 ` [PATCH 0/2] gpio: improve gpiod_is_equal() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFcEKWZvRKQRA6dl@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox