From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Magnus Damm <magnus.damm@gmail.com>,
linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] gpio: rcar: Remove checks for empty bankmasks
Date: Wed, 25 Jun 2025 11:06:23 +0200 [thread overview]
Message-ID: <aFu8D43qSu6ZtTXs@shikoro> (raw)
In-Reply-To: <29fb200d3f92e79cdd5ce4048d2847c265f337b4.1750838486.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
On Wed, Jun 25, 2025 at 10:05:46AM +0200, Geert Uytterhoeven wrote:
> The GPIO core never passes empty bankmasks to the callbacks for handling
> multiple signals at once. Remove the superfluous checks, and refactor
> the code.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Nice cleanup!
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-06-25 9:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 8:05 [PATCH v2 0/2] gpio: rcar: Use new line value setter callbacks Geert Uytterhoeven
2025-06-25 8:05 ` [PATCH v2 1/2] gpio: rcar: Remove checks for empty bankmasks Geert Uytterhoeven
2025-06-25 9:06 ` Wolfram Sang [this message]
2025-06-25 8:05 ` [PATCH v2 2/2] gpio: rcar: Use new line value setter callbacks Geert Uytterhoeven
2025-06-25 9:08 ` Wolfram Sang
2025-06-26 8:53 ` [PATCH v2 0/2] " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFu8D43qSu6ZtTXs@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=brgl@bgdev.pl \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox