From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FEE525F973; Tue, 15 Jul 2025 08:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752567753; cv=none; b=pUHODSe04ujh1tmAZNiu32i8ctHE/vAKHPFbSasMdsIhQOgxFJk+RUo/IaFjpdGyCHINh/JxeP39k77pUTrCQcANWc0uz2N5y1vlWIheDpxV/2UNlKPKuT6mlF39MAaq7gdxlZ2N1xHUuAa1eFwoZLD9T8EAKOrhRwVW+E1rpw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752567753; c=relaxed/simple; bh=a/QsrXQn2Q+8kG4obINj/xiE+3HXSCctW3/j44bjJvA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pKu+kGzkxGfqqsDvEUpLNl63a8Sg2GpseyfAPYv0zU/XiWoSc/GwI/YBGUMfmokWvOo775DtpmZ/bm7o8425Bgx7hHqbsrEOWxDaTXviT3K5Sl2P/BS+QPXBCucX0HXJnBg1vr7DdcyOc0CFHKjEtmNDMC/aASk7SGXABnMFUAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CuBVObZz; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CuBVObZz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752567753; x=1784103753; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=a/QsrXQn2Q+8kG4obINj/xiE+3HXSCctW3/j44bjJvA=; b=CuBVObZzIIWqjbZehViJd+NfcfXqC2PzWS5AnWm0bv45ltQtcRdejKEt 1iOg76bygFLYPPZ0znhuom+/tjIvxBwH8f0QuknzD5yHEw6yfyQoh+nMf R2o/UkYmPDkqmkgHxSFBMy6HS/kry/DNKNlVYsnRadlIUrCisyqmQqU+v BczfAwGFO2B1Ji8KB+6SQDZV4k28gxvrC7OMm6TH0JMPM99LXncfgdYKo YOsUwQJh/Ou83OSWFrt4JW3WgThLpvnmmn5kkEHscgSDX/+xuuKBQUyFJ ucZY/BqH0DcJJBjq8dy8j8tDBmyE3KGs2M2CnP+6AVe664AUAKt2saR68 w==; X-CSE-ConnectionGUID: Ak+qCFB4TT+96rd9KjQQsQ== X-CSE-MsgGUID: 0FtRcuq+TxKhBSpRZyjnKw== X-IronPort-AV: E=McAfee;i="6800,10657,11491"; a="54649109" X-IronPort-AV: E=Sophos;i="6.16,313,1744095600"; d="scan'208";a="54649109" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2025 01:22:32 -0700 X-CSE-ConnectionGUID: RV8tVbiwSt+C/N3N9A6KLQ== X-CSE-MsgGUID: l841zr9kQlyZeWDn3U8ydQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,313,1744095600"; d="scan'208";a="180864523" Received: from smile.fi.intel.com ([10.237.72.52]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2025 01:22:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1ubavh-0000000Fawi-3Sud; Tue, 15 Jul 2025 11:22:25 +0300 Date: Tue, 15 Jul 2025 11:22:25 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH v2 1/2] gpio: wcove: use regmap_assign_bits() in .set() Message-ID: References: <20250715-gpiochip-set-rv-gpio-remaining-v2-0-072b4cf06330@linaro.org> <20250715-gpiochip-set-rv-gpio-remaining-v2-1-072b4cf06330@linaro.org> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Jul 15, 2025 at 11:21:53AM +0300, Andy Shevchenko wrote: > On Tue, Jul 15, 2025 at 10:19:44AM +0200, Bartosz Golaszewski wrote: > > Replace the if-else with a direct call to the regmap_assign_bits() > > helper and save a couple lines of code. '...a couple of lines of code.' > Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko