linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paulk@sys-base.io>
To: Parthiban Nallathambi <parthiban@linumiz.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Maxime Ripard <mripard@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	iommu@lists.linux.dev, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH 09/22] iommu: sun50i: make reset control optional
Date: Thu, 7 Aug 2025 17:29:35 +0200	[thread overview]
Message-ID: <aJTGX7z5QaneVAVs@shepard> (raw)
In-Reply-To: <20241227-a133-display-support-v1-9-13b52f71fb14@linumiz.com>

[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]

Hi,

On Fri 27 Dec 24, 16:37, Parthiban Nallathambi wrote:
> A133/A100 SoC doesn't have reset control from the CCU. Get reset
> control line optionally.

With the dt bindings fixed, this:
Reviewed-by: Paul Kocialkowski <paulk@sys-base.io>

Although feel free to use a first uppercase later in the title after sun50i!

Cheers,

Paul

> Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>
> ---
>  drivers/iommu/sun50i-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/sun50i-iommu.c b/drivers/iommu/sun50i-iommu.c
> index 8d8f11854676..2ba804d682dc 100644
> --- a/drivers/iommu/sun50i-iommu.c
> +++ b/drivers/iommu/sun50i-iommu.c
> @@ -1030,7 +1030,7 @@ static int sun50i_iommu_probe(struct platform_device *pdev)
>  		goto err_free_cache;
>  	}
>  
> -	iommu->reset = devm_reset_control_get(&pdev->dev, NULL);
> +	iommu->reset = devm_reset_control_get_optional(&pdev->dev, NULL);
>  	if (IS_ERR(iommu->reset)) {
>  		dev_err(&pdev->dev, "Couldn't get our reset line.\n");
>  		ret = PTR_ERR(iommu->reset);
> 
> -- 
> 2.39.5
> 
> 

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2025-08-07 15:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-27 11:07 [PATCH 00/22] Add support for A100/A133 display Parthiban Nallathambi
2024-12-27 11:07 ` [PATCH 01/22] dt-bindings: iommu: sun50i: remove resets from required property Parthiban Nallathambi
2025-08-07 15:27   ` Paul Kocialkowski
2024-12-27 11:07 ` [PATCH 02/22] dt-bindings: display: sunxi: Add a100/a133 display engine compatibles Parthiban Nallathambi
2024-12-27 11:07 ` [PATCH 03/22] dt-bindings: clock: sun8i de2 clock: Add PLL com clock Parthiban Nallathambi
2024-12-27 13:16   ` Rob Herring (Arm)
2024-12-27 11:07 ` [PATCH 04/22] dt-bindings: clock: sun8i de2 clock: Add a100/a133 compatible Parthiban Nallathambi
2024-12-27 11:07 ` [PATCH 05/22] dt-bindings: display: sun4i: add phy property Parthiban Nallathambi
2024-12-27 11:07 ` [PATCH 06/22] dt-bindings: display: sun4i: add a100/a133 tcon lcd Parthiban Nallathambi
2024-12-27 11:07 ` [PATCH 07/22] dt-bindings: vendor-prefixes: Shenzhen Baijie Technology Parthiban Nallathambi
2025-08-07 15:24   ` Paul Kocialkowski
2024-12-27 11:07 ` [PATCH 08/22] dt-bindings: arm: sunxi: document Szbaijie A133 helper board Parthiban Nallathambi
2024-12-27 11:07 ` [PATCH 09/22] iommu: sun50i: make reset control optional Parthiban Nallathambi
2025-01-06 11:24   ` Joerg Roedel
2025-08-07 15:29   ` Paul Kocialkowski [this message]
2024-12-27 11:07 ` [PATCH 10/22] pinctrl: sunxi: add missed lvds pins for a100/a133 Parthiban Nallathambi
2025-01-13 14:30   ` Linus Walleij
2025-01-14 15:46     ` Andre Przywara
2025-06-25  8:46   ` Paul Kocialkowski
2025-06-25  9:36     ` Parthiban
2025-06-25 10:11       ` Paul Kocialkowski
2025-06-25 10:46         ` Parthiban
2024-12-27 11:07 ` [PATCH 11/22] drm/sun4i: Add support for a100/a133 display engine Parthiban Nallathambi
2024-12-27 11:07 ` [PATCH 12/22] drm/sun4i: Add support for a100/a133 mixer Parthiban Nallathambi
2024-12-27 11:08 ` [PATCH 13/22] drm/sun4i: make tcon top tv0 optional Parthiban Nallathambi
2024-12-27 11:08 ` [PATCH 14/22] drm/sun4i: add a100/a133 tcon top quirks Parthiban Nallathambi
2024-12-27 11:08 ` [PATCH 15/22] clk: sunxi-ng: sun8i-de2: add pll-com clock support Parthiban Nallathambi
2024-12-27 11:08 ` [PATCH 16/22] clk: sunxi-ng: sun8i-de2: Add support for a100/a133 Parthiban Nallathambi
     [not found] ` <20241227-a133-display-support-v1-17-13b52f71fb14@linumiz.com>
2025-06-25  8:41   ` [PATCH 17/22] phy: allwinner: phy-sun6i-mipi-dphy: add LVDS support Paul Kocialkowski
2025-06-25  9:38     ` Parthiban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJTGX7z5QaneVAVs@shepard \
    --to=paulk@sys-base.io \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=iommu@lists.linux.dev \
    --cc=jernej.skrabec@gmail.com \
    --cc=joro@8bytes.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=parthiban@linumiz.com \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=samuel@sholland.org \
    --cc=sboyd@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vkoul@kernel.org \
    --cc=wens@csie.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).