From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE05521ABBB for ; Tue, 19 Aug 2025 08:38:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755592741; cv=none; b=Qqz5W+g4KzDpYnOeAiylPrQjJkplKBH59fJqf49RcrbfxXoQd3JWEXiT+agYFxZJZaIb4JVivQDFV+60RE98vf2w5gou7QLa8i8lJ6wdjiFfEPGjLn6QyQynNxsPeqbffub8crFSgNPeBVXekjh25uQod7SXGqoWqO3iqrmtU4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755592741; c=relaxed/simple; bh=3F4UrOhZZTYKHnFTlZsPxTLZ7XhoY/GR8gZkd6VKDcI=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xmm7qBHhulRpn6NN9vM2JVPFNX8EkYz9E//0Om2hDeUmTY7FX8q0F/IV/UEuzpla/+QJHWYuB421h8+FrAsyctWglttuVlQ4Wdk6b1Pus0Kq/6UWT7RzBT0SYi5FroRagjymAJA97gG9oy5suN6q864AxxwX9PDO8TpvfzqDFiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=YeMFEOjJ; arc=none smtp.client-ip=209.85.218.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="YeMFEOjJ" Received: by mail-ej1-f68.google.com with SMTP id a640c23a62f3a-afcb7a7bad8so669871166b.3 for ; Tue, 19 Aug 2025 01:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1755592737; x=1756197537; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=awT1Pc5QFdF5D/Wxu+LjKDgk6d6Ud6beDyAqqEU7AUY=; b=YeMFEOjJcH2ldPA6DfSAWX7sOZQHG4JxrBn89K3zGXwTWDpK2s4712fDm9la4Tjcue SzjZJ/tGOOGaGQVSOPda2rvvSPkYy6NTeaTEAgpN8KnW7E7QxNAqyjlewb1kZyVDSdWn J656yg+L3Y1xU94hWR6DWM25z9mSHQYRSRkaoT82kG50yPErNS+tB2aA0Ky7IpvKIKj9 2twU6dheyWpc4Do/+pp1o5uGlPQRum1JWKWVypCyV6g+88Uzfy1HAOQSi6bYkY+YtElt K+v/85eQijEaYudInTnFALFQg9N3RbLdD6UA5oSSdvzKWsgITTzIbIOEyQZxj0roDrHi Z4yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755592737; x=1756197537; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=awT1Pc5QFdF5D/Wxu+LjKDgk6d6Ud6beDyAqqEU7AUY=; b=fzGUbL3vOy1P7T+3whFH0wox+EkrzR0kOOTXLe7KAX7Zd7DDp+6weiKyNKMoKK9V6h Ud2qPOkxeF8N28WNKj+kpClKQl2TBN3JXkkDvZw2t9iTpHY86AJVn0tIZj2TtG3zu6BL R2d5VIpSsBDSfKQONG8wNCjz6Q4CqLMatiQ7+OMoUQU+oo+R7/np2pCmIBXU+7W9W8fE ZRrGCnToU2DjOn1keuXT6bXx2InY52kClQvMOdyuEHmUnYEuS27QHgDjOjO7+iAQHRBr vpMCN8Z/i/Pt7fm0OlsPQ9RNkAAj/88C9ikZ0lMta5F7SQ4N9CBOcGQ7T0mT7MlvRLmB /qJw== X-Forwarded-Encrypted: i=1; AJvYcCVta0qc8BMW746h9GyEYNuXk1QDKhixWtCsqX1vPzSHNbcrTB/bEyHNcrDwCaTgSJtsKzYtIi4MwQzp@vger.kernel.org X-Gm-Message-State: AOJu0YyRUWMgZCr7YM/yLujAfK6vknOKtZxa/rsg2VR1B/WtvDb4iBp4 NYSipvsP12biXlFfpu2mqQTPBbo90KLSsclgBAB8SU34p4uV649KRZIbPfDaXqtv16E= X-Gm-Gg: ASbGncuI98Q2K8xdFmynkoDqu4vazguS32DeC/YLkeVUn7OzFs20/r6SpcdlgPXijgV rCKhsKPJSf85rM3bA1WfGXWLH+OBRtPCaYiRyzbaTxHz8almj0iYQMnruFH+kez6GJhyzI5DxQd DsENaonhfERZhN+LSiQBjgGP61ytinvLZBqeOBFg1SFojNs9XydV8te4ou12evj3Rs21bT8DGZp PnLNdVSSU0ulHxV/+24LpxlM5YL+7mZxChQGuGG6SXTvB2wagtzIuPnqy7o4Y2SUgfmsOCQLFjz tfInVG9dFibwQm7kXjAHkg1VaUTg6o3O1xmu+3LdyD2cWY3F/FSqooBP4+8ju7t9c9T2Sac/K5O jCD322uj9cxLQrFQUIAc/M3YU77svcbdpcL7fg7vgAYFvXAmmpcGeQ0NKx4er X-Google-Smtp-Source: AGHT+IHonInmdTYMCRZte9li+YjdpP7iMaUqqny3PYj+jU1US9Z78L5CzsZFHXynIpZWrj7rqyAw1g== X-Received: by 2002:a17:906:730d:b0:af3:7645:43e1 with SMTP id a640c23a62f3a-afddcb7f393mr178888166b.17.1755592737043; Tue, 19 Aug 2025 01:38:57 -0700 (PDT) Received: from localhost (host-79-36-0-44.retail.telecomitalia.it. [79.36.0.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afcdcea0ebdsm967968366b.56.2025.08.19.01.38.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 01:38:56 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 19 Aug 2025 10:40:48 +0200 To: Stanimir Varbanov Cc: Andrea della Porta , linus.walleij@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, florian.fainelli@broadcom.com, wahrenst@gmx.net, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , iivanov@suse.de, mbrugger@suse.com, Jonathan Bell , Phil Elwell Subject: Re: [PATCH v3 2/3] pinctrl: bcm: Add STB family pin controller driver Message-ID: References: <9af1eb5b-7eb1-4686-869d-eda597145819@suse.de> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9af1eb5b-7eb1-4686-869d-eda597145819@suse.de> Hi Stanmir, On 11:19 Tue 19 Aug , Stanimir Varbanov wrote: > > > On 8/19/25 11:14 AM, Andrea della Porta wrote: > > Hi Stanimir, > > > > On 10:40 Tue 19 Aug , Stanimir Varbanov wrote: > >> Hi Andrea, > >> > >> On 8/11/25 5:46 PM, Andrea della Porta wrote: > >>> From: "Ivan T. Ivanov" > >>> > >>> This driver provide pin muxing and configuration functionality > >>> for BCM2712 SoC used by RPi5. According to [1] this chip is an > >>> instance of the one used in Broadcom STB product line. > >>> > >>> [1] https://lore.kernel.org/lkml/f6601f73-cb22-4ba3-88c5-241be8421fc3@broadcom.com/ > >>> > >>> Cc: Jonathan Bell > >>> Cc: Phil Elwell > >>> Signed-off-by: Ivan T. Ivanov > >>> Reviewed-by: Phil Elwell > >>> Signed-off-by: Andrea della Porta > >>> --- > >>> drivers/pinctrl/bcm/Kconfig | 13 + > >>> drivers/pinctrl/bcm/Makefile | 1 + > >>> drivers/pinctrl/bcm/pinctrl-brcmstb.c | 1197 +++++++++++++++++++++++++ > >>> 3 files changed, 1211 insertions(+) > >>> create mode 100644 drivers/pinctrl/bcm/pinctrl-brcmstb.c > >>> > >> > >> > >> > >>> +static int brcmstb_pinctrl_probe(struct platform_device *pdev) > >>> +{ > >>> + struct device *dev = &pdev->dev; > >>> + struct device_node *np = dev->of_node; > >>> + const struct brcmstb_pdata *pdata; > >>> + const struct of_device_id *match; > >>> + struct brcmstb_pinctrl *pc; > >>> + const char **names; > >>> + int num_pins, i; > >>> + > >>> + match = of_match_node(brcmstb_pinctrl_match, np); > >> > >> The 'match' variable is needless, you can drop it. > > > > you mean something like this? > > > > pdata = of_match_node(brcmstb_pinctrl_match, np)->data; > > > > No, I meant: > > pdata = of_device_get_match_data(dev) > > Also as a bonus you could move brcmstb_pinctrl_match[] array after .probe.a Right. Thanks! Andrea > > ~Stan