From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6093F2FE058 for ; Thu, 4 Sep 2025 11:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756985532; cv=none; b=kUxFKpFMkDby9x7cnOY5OcWF0Pv8ygpITxblb7WtAhZ+72juNT/83I9M7bm5WSFxnc8ikK1Vz2rS7dboUbVcoOYHJzatc+Ny75YyF8CZ4SBN1HRZbX//EwG5yVPm09GMZT3oOBPtR25P/NQy8Vmqqdq5iufHKCwfMedjAWJ6dRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756985532; c=relaxed/simple; bh=Q2qBJPDf2nMSdqr38T/UuOwrbPDS9xsdvLR7qAJBjW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dJJBu+x5vWZyAjAFYDjTXzb8SUNrar1NTxrsU8N+8NAa8/8aZ1zzOi60GHnTAeoug1jUc+fgTJdBxREppdPBsTaGYed6mlJUmxovrhFTtnFDmZd0puAyTf5QBo84XKV34XOfSuyjJj8KxI68U9AGmjTF0n6bL2+vghIgvMdNhDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uu8Bz-0005GV-Pu; Thu, 04 Sep 2025 13:31:51 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uu8Bz-003iZT-1g; Thu, 04 Sep 2025 13:31:51 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uu8Bz-0029s9-1E; Thu, 04 Sep 2025 13:31:51 +0200 Date: Thu, 4 Sep 2025 13:31:51 +0200 From: Sascha Hauer To: Krzysztof Kozlowski Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Linus Walleij , linux-gpio@vger.kernel.org, Alvin =?iso-8859-15?Q?=A6ipraga?= Subject: Re: [PATCH v6 1/2] dt-bindings: clock: add TI CDCE6214 binding Message-ID: References: <20250903-clk-cdce6214-v6-0-b2cc0a6f282b@pengutronix.de> <20250903-clk-cdce6214-v6-1-b2cc0a6f282b@pengutronix.de> <20250904-arboreal-upbeat-iguana-aebba6@kuoka> <2c7fefb2-9a0c-451f-84f6-dc5a19707699@kernel.org> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c7fefb2-9a0c-451f-84f6-dc5a19707699@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-gpio@vger.kernel.org On Thu, Sep 04, 2025 at 11:43:53AM +0200, Krzysztof Kozlowski wrote: > On 04/09/2025 09:34, Sascha Hauer wrote: > > On Thu, Sep 04, 2025 at 09:18:13AM +0200, Krzysztof Kozlowski wrote: > >> On Wed, Sep 03, 2025 at 03:55:45PM +0200, Sascha Hauer wrote: > >>> Add device tree binding for the CDCE6214, an Ultra-Low Power Clock > >>> Generator With One PLL, Four Differential Outputs, Two Inputs, and > >>> Internal EEPROM. > >>> > >>> Signed-off-by: Sascha Hauer > >>> --- > >>> .../devicetree/bindings/clock/ti,cdce6214.yaml | 198 +++++++++++++++++++++ > >>> include/dt-bindings/clock/ti,cdce6214.h | 24 +++ > >>> 2 files changed, 222 insertions(+) > >>> > >> > >> I don't understand what is happening here. > >> > >> Patch changed in weird and unexplained way - nothing in the changelog > >> explains dropping SPDX - and does not pass even checkpatch. > > > > I removed the SPDX by accident, will add it back of course. > > > > Other than that, what's weird? Changelog says I now use the pinctrl > > subsystem to configure pins. OK, that also changes the binding, I could > > have mentioned that explicitly, sorry for that. > > There were four patches before, now there are two and changelog says > only about pinctrl to configure pins. That's very vague and you expect > me to decipher what changed in the bindings. In v5 I tried splitting the driver/bindings up into a basic part which and a part which added the pin config stuff in the hope that the first two patches could be applied first. This was not very well received, so I merged it back. I am aware that the binding looks quite different now, but this really goes down to using the pinctrl bindings now. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |