From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52E50329C54 for ; Thu, 16 Oct 2025 16:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760632652; cv=none; b=EShOyc29OvfHP0ZndshGaNPygZhY4wtiXfmMxUUGL6Wjy15Z3Y+Q/NevwrUyTOO+YfrwrUoeGJ/C/rBrfXWg0aExbUqg/GsZXTkVQ5v07TCBLaposTWJS1M4qXeIgy7Fhxd2BvtpAN0WkbETVLLSgO7ZqcTRJo8eoSr4YYY3qV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760632652; c=relaxed/simple; bh=KEHq5Zv6SKODtoWAUUZ02QfgtCU6kZ9QOgSNgl9kgnU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R6r/zPvV36w5KvYQauQIWAeN5A1yFtCzrIQKyTIn0TwzUY71zFNsE6UCxFObWY72ZIoK/ukGMkTNgIy7nwrYQfxALu37gm3I7TxxYdP51cy2lb/uUStRhsYORXnTlcKXMNiyGtMrs4jc3CDtmIPi49UPoVDTD3VrGDMy8jdVPBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GNJjygoQ; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GNJjygoQ" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-46e6a689bd0so9176665e9.1 for ; Thu, 16 Oct 2025 09:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760632649; x=1761237449; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=45+w+j3wKKDN4yoFkSENhMTwEvEfIBVYuwOyTN6K8LA=; b=GNJjygoQs0rQ9GY3K7lzK50fODSxRs9worjuVD/nlH5XnwWltDIaQmIm9EN+8ZeHDl rBJPRpIDc2oCaOf4mN7uY4N319+gfJ3EPeGT0FtSGmXKpY3LyG6QRuRU4eG85AA1gJA3 zHCQB9rjfKmyJ/6RzIvp3zp1l0ki8VBkCubkJSxlY2zWrxB4vB2pof864K7nTf4HSI0M vHIiuDJvmMH0DOefu/EhTznDH9JlkZpIorYS8Df7jIXHTwF2ySgf9g1yhtOh4MqfIbVu A5dSjBvdwxFr/HumMqWmTltarN5TTYh8u9FGZsWf+SPIzmytIyZ1MD3ThhVMez1yObUH u6zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760632649; x=1761237449; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=45+w+j3wKKDN4yoFkSENhMTwEvEfIBVYuwOyTN6K8LA=; b=tQOcM3scGuO2ctcign/77weKAgg4xcgJQFY+yHi5f74wHn/ECKZHxr391g3Ap/U6gm ONiLAT/BLYLH4IS5tfpn13GhH4Pc//cSQmWFQdZ9tcU2p7pt8703aGmXX/18tT2suCTm EaosAAbXCpTfLWRn2VhGhpBxWkOO9GAcocEwjhNpjz2H9w3ttuqJnPiIFjy+7UspV4iU xy1l5Pdlpg8p5xlFA2HwH/yptvL6+IToBQdl1SZIfJwd3Z977WAwd5Rfp1g6136SGzjV oDT8gj5xZu7ev5Fwfcq1cGTeorFZHOJzHwB1IDz9d3cMU5YdHrC7DEmYjSXqWJabGzB/ 5YuQ== X-Forwarded-Encrypted: i=1; AJvYcCXPzCYPGYweLpFtHEcjAhTq/Ztp8ayAveR+RaovXP0Rt6NygCNwYK7sBJVyoy9aOjPhXL7YPEaQW1aQ@vger.kernel.org X-Gm-Message-State: AOJu0YyTatIICNLbUnPaLE1KCmH0MwM2JoG6DWMNXtjVqlqZRZOXTl1k iYhm7YxCdi8sa9V64rjG6DVsWOnt7+O85uutQuC0zi56evnxOTUUslt7Qy9Y7Q== X-Gm-Gg: ASbGncvtGKlLdadg20DFAAPQmalklMP8vy92UN425oeGDNdaUPXWfyQeUgVWJq7jOQ2 rffpTmb5DvNxuYAtWHYfTv8lqZuV9TQa9YTlOBbog10ZRCznP79v+wgYIDxoE5CRkGYGluWsVky b/tFlCRdw4bjqkbNhqg8Na2FBuePdfGfjrkU0qeCXABFNnM2spURpbWmZDJbJsdg4WpV8MhLs3z 8lL7IiaVxTesxvR4NWRrG9z0Und1peDJ3147Uz77NTYK/EryahE3pIBTwt2+/viq0Ar8U1gV17y z2FIlbRggSwl/8o9KaSCQjCvngdd5NHdft2FH7hxqQJAL5mCuHz2PLfztR5loZPS1247Ctt0CfE bz/qnY6GKwqFcxGhR1mG5HUIe0g32Xk4FAg8KWyJrcK4evJsI3wst5N8d1ItABWSOrBkpSPn/Xr 3GbPyJ4CH/chZ66w== X-Google-Smtp-Source: AGHT+IGEOTfVqWnJFYOk2GGMnHDO9Q9MSJhfGr6/3jWO6A4puL9KoGNizC6MjPxWvVhvNa+GQ/HzbQ== X-Received: by 2002:a05:600c:458b:b0:46e:39da:1195 with SMTP id 5b1f17b1804b1-471178784d9mr5114965e9.3.1760632648448; Thu, 16 Oct 2025 09:37:28 -0700 (PDT) Received: from gmail.com ([51.154.248.208]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4710ed4b47fsm25518655e9.4.2025.10.16.09.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 09:37:28 -0700 (PDT) Date: Thu, 16 Oct 2025 16:37:27 +0000 From: Vaibhav Gupta To: Bjorn Helgaas Cc: Michael Buesch , Bartosz Golaszewski , Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] gpio: bt8xx: use generic PCI PM Message-ID: References: <20251013155303.1103235-1-vaibhavgupta40@gmail.com> <20251013174319.GA847155@bhelgaas> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251013174319.GA847155@bhelgaas> On Mon, Oct 13, 2025 at 12:43:19PM -0500, Bjorn Helgaas wrote: > On Mon, Oct 13, 2025 at 03:52:59PM +0000, Vaibhav Gupta wrote: > > Switch to the new generic PCI power management framework and remove legacy > > callbacks like .suspend() and .resume(). With the generic framework, the > > standard PCI related work like: > > - pci_save/restore_state() > > - pci_enable/disable_device() > > - pci_set_power_state() > > is handled by the PCI core and this driver should implement only gpio-bt8xx > > specific operations in its respective callback functions. > > Tiny nits: > > s/use generic PCI PM/use generic power management/ # subject; not PCI > s/new generic PCI power/generic power management/ # no longer "new" :) > > > Signed-off-by: Vaibhav Gupta > > --- > > drivers/gpio/gpio-bt8xx.c | 29 +++++++---------------------- > > 1 file changed, 7 insertions(+), 22 deletions(-) > > > > diff --git a/drivers/gpio/gpio-bt8xx.c b/drivers/gpio/gpio-bt8xx.c > > index 05401da03ca3..70b49c385b43 100644 > > --- a/drivers/gpio/gpio-bt8xx.c > > +++ b/drivers/gpio/gpio-bt8xx.c > > @@ -52,10 +52,8 @@ struct bt8xxgpio { > > struct pci_dev *pdev; > > struct gpio_chip gpio; > > > > -#ifdef CONFIG_PM > > u32 saved_outen; > > u32 saved_data; > > -#endif > > }; > > > > #define bgwrite(dat, adr) writel((dat), bg->mmio+(adr)) > > @@ -224,9 +222,9 @@ static void bt8xxgpio_remove(struct pci_dev *pdev) > > pci_disable_device(pdev); > > } > > > > -#ifdef CONFIG_PM > > -static int bt8xxgpio_suspend(struct pci_dev *pdev, pm_message_t state) > > +static int __maybe_unused bt8xxgpio_suspend(struct device *dev) > > I think __maybe_unused is unnecessary because of this path: > > DEFINE_SIMPLE_DEV_PM_OPS > _DEFINE_DEV_PM_OPS > SYSTEM_SLEEP_PM_OPS > pm_sleep_ptr > PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr)) > > Detailed explanation here: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/util_macros.h?id=v6.17#n86 > Fixed them in v6. > > { > > + struct pci_dev *pdev = to_pci_dev(dev); > > struct bt8xxgpio *bg = pci_get_drvdata(pdev); > > > > scoped_guard(spinlock_irqsave, &bg->lock) { > > Unrelated to this patch, but it's not clear to me why bg->lock is > needed here (or maybe anywhere). > > $ git grep -l "static int.*_suspend" drivers/gpio | wc -l > 26 > $ git grep -W "static int.*_suspend" drivers/gpio | grep lock | grep -v unlock | wc -l > > It looks like only about 8 of the 26 gpio drivers that implement > .suspend() protect it with a lock. I would expect a lock to be needed > in all of them or none of them. > I can have a look at them. regards, Vaibhav > > @@ -238,23 +236,13 @@ static int bt8xxgpio_suspend(struct pci_dev *pdev, pm_message_t state) > > bgwrite(0x0, BT848_GPIO_OUT_EN); > > } > > > > - pci_save_state(pdev); > > - pci_disable_device(pdev); > > - pci_set_power_state(pdev, pci_choose_state(pdev, state)); > > - > > return 0; > > } > > > > -static int bt8xxgpio_resume(struct pci_dev *pdev) > > +static int __maybe_unused bt8xxgpio_resume(struct device *dev) > > { > > + struct pci_dev *pdev = to_pci_dev(dev); > > struct bt8xxgpio *bg = pci_get_drvdata(pdev); > > - int err; > > - > > - pci_set_power_state(pdev, PCI_D0); > > - err = pci_enable_device(pdev); > > - if (err) > > - return err; > > - pci_restore_state(pdev); > > > > guard(spinlock_irqsave)(&bg->lock); > > > > @@ -267,10 +255,8 @@ static int bt8xxgpio_resume(struct pci_dev *pdev) > > > > return 0; > > } > > -#else > > -#define bt8xxgpio_suspend NULL > > -#define bt8xxgpio_resume NULL > > -#endif /* CONFIG_PM */ > > + > > +static DEFINE_SIMPLE_DEV_PM_OPS(bt8xxgpio_pm_ops, bt8xxgpio_suspend, bt8xxgpio_resume); > > > > static const struct pci_device_id bt8xxgpio_pci_tbl[] = { > > { PCI_DEVICE(PCI_VENDOR_ID_BROOKTREE, PCI_DEVICE_ID_BT848) }, > > @@ -286,8 +272,7 @@ static struct pci_driver bt8xxgpio_pci_driver = { > > .id_table = bt8xxgpio_pci_tbl, > > .probe = bt8xxgpio_probe, > > .remove = bt8xxgpio_remove, > > - .suspend = bt8xxgpio_suspend, > > - .resume = bt8xxgpio_resume, > > + .driver.pm = &bt8xxgpio_pm_ops, > > }; > > > > module_pci_driver(bt8xxgpio_pci_driver); > > -- > > 2.51.0 > >