From: Jisheng Zhang <jszhang@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hoan Tran <hoan@os.amperecomputing.com>,
Andy Shevchenko <andy@kernel.org>,
Daniel Palmer <daniel@thingy.jp>,
Romain Perier <romain.perier@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 02/15] gpio: brcmstb: Use modern PM macros
Date: Thu, 20 Nov 2025 08:28:22 +0800 [thread overview]
Message-ID: <aR5gpsbw_r-y4JdS@xhacker> (raw)
In-Reply-To: <aR4CLQ_2-kUM-e2F@smile.fi.intel.com>
On Wed, Nov 19, 2025 at 07:45:17PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 20, 2025 at 12:33:14AM +0800, Jisheng Zhang wrote:
> > Use the modern PM macros for the suspend and resume functions to be
> > automatically dropped by the compiler when CONFIG_PM or
> > CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
> >
> > This has the advantage of always compiling these functions in,
> > independently of any Kconfig option. Thanks to that, bugs and other
> > regressions are subsequently easier to catch.
>
> ...
>
> > static const struct dev_pm_ops brcmstb_gpio_pm_ops = {
> > - .suspend_noirq = brcmstb_gpio_suspend,
> > - .resume_noirq = brcmstb_gpio_resume,
> > + .suspend_noirq = pm_sleep_ptr(brcmstb_gpio_suspend),
> > + .resume_noirq = pm_sleep_ptr(brcmstb_gpio_resume),
>
> Can it be DEFINE_NOIRQ_DEV_PM_OPS() / NOIRQ_SYSTEM_SLEEP_PM_OPS()?
Yep I agree with you. But IMHO, it's better to make the
DEFINE_NOIRQ_DEV_PM_OPS() switching as a seperate patch and merge this
series which wants to clean up various #ifdef #endif usages
next prev parent reply other threads:[~2025-11-20 0:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 16:33 [PATCH v4 00/15] gpio: Use modern PM macros Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 01/15] gpio: dwapb: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 02/15] gpio: brcmstb: " Jisheng Zhang
2025-11-19 17:45 ` Andy Shevchenko
2025-11-20 0:28 ` Jisheng Zhang [this message]
2025-11-20 7:02 ` Andy Shevchenko
2025-11-19 16:33 ` [PATCH v4 03/15] gpio: htc-egpio: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 04/15] gpio: pl061: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 05/15] gpio: pxa: " Jisheng Zhang
2025-11-19 17:41 ` Andy Shevchenko
2025-11-20 0:24 ` Jisheng Zhang
2025-11-20 7:01 ` Andy Shevchenko
2025-11-19 16:33 ` [PATCH v4 06/15] gpio: ml-ioh: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 07/15] gpio: mlxbf2: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 08/15] gpio: msc313: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 09/15] gpio: omap: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 10/15] gpio: pch: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 11/15] gpio: tqmx86: " Jisheng Zhang
2025-11-19 17:19 ` Andy Shevchenko
2025-11-20 0:10 ` Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 12/15] gpio: uniphier: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 13/15] gpio: xgene: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 14/15] gpio: xilinx: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 15/15] gpio: zynq: " Jisheng Zhang
2025-11-19 16:52 ` [PATCH v4 00/15] gpio: " Bartosz Golaszewski
2025-11-19 17:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR5gpsbw_r-y4JdS@xhacker \
--to=jszhang@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=florian.fainelli@broadcom.com \
--cc=grygorii.strashko@ti.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hoan@os.amperecomputing.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=michal.simek@amd.com \
--cc=opendmb@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=romain.perier@gmail.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).