From: Peter Chen <peter.chen@cixtech.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Fugang Duan <fugang.duan@cixtech.com>,
CIX Linux Kernel Upstream Group <cix-kernel-upstream@cixtech.com>,
Gary Yang <gary.yang@cixtech.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: cix: Fix obscure dependency
Date: Tue, 25 Nov 2025 09:10:20 +0800 [thread overview]
Message-ID: <aSUB_C5H2sXxVXXo@nchen-desktop> (raw)
In-Reply-To: <20251124-cix-deps-v1-1-fe603dfe86ef@linaro.org>
On 25-11-24 15:35:16, Linus Walleij wrote:
> EXTERNAL EMAIL
>
> When compile-testing for UM-Linux the build fails because
> we don't have IOMEM.
>
> Add an explicit dependency.
>
> Fixes: 920500c5fe66 ("pinctrl: cix: Add pin-controller support for sky1")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Peter Chen <peter.chen@cixtech.com>
Peter
> ---
> drivers/pinctrl/cix/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/cix/Kconfig b/drivers/pinctrl/cix/Kconfig
> index 455120dd7318..1529b1af6388 100644
> --- a/drivers/pinctrl/cix/Kconfig
> +++ b/drivers/pinctrl/cix/Kconfig
> @@ -9,6 +9,7 @@ config PINCTRL_SKY1_BASE
> config PINCTRL_SKY1
> tristate "Cix Sky1 pinctrl driver"
> depends on ARCH_CIX || COMPILE_TEST
> + depends on HAS_IOMEM
> select PINCTRL_SKY1_BASE
> help
> Say Y here to enable the sky1 pinctrl driver
>
> ---
> base-commit: da53dcd54cc35efa7a8236846bb39d40deeee034
> change-id: 20251124-cix-deps-6f942ccd16e3
>
> Best regards,
> --
> Linus Walleij <linus.walleij@linaro.org>
>
--
Best regards,
Peter
prev parent reply other threads:[~2025-11-25 1:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 14:35 [PATCH] pinctrl: cix: Fix obscure dependency Linus Walleij
2025-11-25 1:10 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSUB_C5H2sXxVXXo@nchen-desktop \
--to=peter.chen@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=fugang.duan@cixtech.com \
--cc=gary.yang@cixtech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).