linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: cix: Fix obscure dependency
@ 2025-11-24 14:35 Linus Walleij
  2025-11-25  1:10 ` Peter Chen
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2025-11-24 14:35 UTC (permalink / raw)
  To: Peter Chen, Fugang Duan, CIX Linux Kernel Upstream Group,
	Gary Yang
  Cc: linux-gpio, Linus Walleij

When compile-testing for UM-Linux the build fails because
we don't have IOMEM.

Add an explicit dependency.

Fixes: 920500c5fe66 ("pinctrl: cix: Add pin-controller support for sky1")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/cix/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/cix/Kconfig b/drivers/pinctrl/cix/Kconfig
index 455120dd7318..1529b1af6388 100644
--- a/drivers/pinctrl/cix/Kconfig
+++ b/drivers/pinctrl/cix/Kconfig
@@ -9,6 +9,7 @@ config PINCTRL_SKY1_BASE
 config PINCTRL_SKY1
 	tristate "Cix Sky1 pinctrl driver"
 	depends on ARCH_CIX || COMPILE_TEST
+	depends on HAS_IOMEM
 	select PINCTRL_SKY1_BASE
 	help
 	  Say Y here to enable the sky1 pinctrl driver

---
base-commit: da53dcd54cc35efa7a8236846bb39d40deeee034
change-id: 20251124-cix-deps-6f942ccd16e3

Best regards,
-- 
Linus Walleij <linus.walleij@linaro.org>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pinctrl: cix: Fix obscure dependency
  2025-11-24 14:35 [PATCH] pinctrl: cix: Fix obscure dependency Linus Walleij
@ 2025-11-25  1:10 ` Peter Chen
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2025-11-25  1:10 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Fugang Duan, CIX Linux Kernel Upstream Group, Gary Yang,
	linux-gpio

On 25-11-24 15:35:16, Linus Walleij wrote:
> EXTERNAL EMAIL
> 
> When compile-testing for UM-Linux the build fails because
> we don't have IOMEM.
> 
> Add an explicit dependency.
> 
> Fixes: 920500c5fe66 ("pinctrl: cix: Add pin-controller support for sky1")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Peter Chen <peter.chen@cixtech.com>

Peter
> ---
>  drivers/pinctrl/cix/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/cix/Kconfig b/drivers/pinctrl/cix/Kconfig
> index 455120dd7318..1529b1af6388 100644
> --- a/drivers/pinctrl/cix/Kconfig
> +++ b/drivers/pinctrl/cix/Kconfig
> @@ -9,6 +9,7 @@ config PINCTRL_SKY1_BASE
>  config PINCTRL_SKY1
>         tristate "Cix Sky1 pinctrl driver"
>         depends on ARCH_CIX || COMPILE_TEST
> +       depends on HAS_IOMEM
>         select PINCTRL_SKY1_BASE
>         help
>           Say Y here to enable the sky1 pinctrl driver
> 
> ---
> base-commit: da53dcd54cc35efa7a8236846bb39d40deeee034
> change-id: 20251124-cix-deps-6f942ccd16e3
> 
> Best regards,
> --
> Linus Walleij <linus.walleij@linaro.org>
> 

-- 

Best regards,
Peter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-25  1:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-24 14:35 [PATCH] pinctrl: cix: Fix obscure dependency Linus Walleij
2025-11-25  1:10 ` Peter Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).