From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linus.walleij@linaro.org, brgl@kernel.org, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
morbidrsa@gmail.com, jth@kernel.org, wim@linux-watchdog.org,
linux@roeck-us.net, nathan@kernel.org, nsc@kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, linux-serial@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 0/2] mcb: Add modpost support for processing MODULE_DEVICE_TABLE
Date: Fri, 28 Nov 2025 11:46:04 +0100 [thread overview]
Message-ID: <aSl9bN2Yv5rib_-O@MNI-190> (raw)
In-Reply-To: <CAHp75VdvJUFwFBRKT+iqwQXiK-toah3gZq6pX9Omcp6d2R7g+A@mail.gmail.com>
On Thu, Nov 27, 2025 at 06:16:03PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 27, 2025 at 5:56 PM Jose Javier Rodriguez Barbarin
> <dev-josejavier.rodriguez@duagon.com> wrote:
> >
> > During the process of update of one of the device drivers that are part of
> > mcb bus (gpio-menz127.c),
>
> > one maintainer of the GPIO subsystem
>
> Krzysztof? Did I miss something and he is now a (co)maintainer here?
>
I'm sorry, it's my fault, I confused the person who answered me the first time
with one of the maintainers. Krzysztof and Linus both answered me.
> > asked me
> > why I was adding new MODULE_ALIAS when I also added the same new
> > information on MODULE_DEVICE_TABLE.
> >
> > You can find the messages here:
> >
> > https://lore.kernel.org/linux-gpio/80a20b13-7c6a-4483-9741-568424f957ef@kernel.org/
> >
> > After a deeper analysis, I came across that the mcb_table_id defined inside
> > MODULE_DEVICE_TABLE on all device drivers was being ignored as modpost was
> > not processing the mcb MODULE_DEVICE_TABLE entries. For this reason, former
> > contributors were using MODULE_ALIAS for enabling mcb to autoload the
> > device drivers.
> >
> > My proposal with these changes is to complete the mcb bus by adding
> > modpost support for processing mcb MODULE_DEVICE_TABLE and removing
> > MODULE_ALIAS from all device drivers as they are no longer needed.
> >
> > Jose Javier Rodriguez Barbarin (2):
> > mcb: Add missing modpost build support
> > mcb: Remove MODULE_ALIAS from all mcb client drivers
> >
> > drivers/gpio/gpio-menz127.c | 1 -
> > drivers/iio/adc/men_z188_adc.c | 1 -
> > drivers/tty/serial/8250/8250_men_mcb.c | 3 ---
> > drivers/tty/serial/men_z135_uart.c | 1 -
> > drivers/watchdog/menz69_wdt.c | 1 -
> > scripts/mod/devicetable-offsets.c | 3 +++
> > scripts/mod/file2alias.c | 9 +++++++++
> > 7 files changed, 12 insertions(+), 7 deletions(-)
> >
> > --
> > 2.51.1
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
Thanks for you review, I will send a V2 following your suggestions.
Regards,
Javier Rodriguez.
prev parent reply other threads:[~2025-11-28 10:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 15:54 [PATCH 0/2] mcb: Add modpost support for processing MODULE_DEVICE_TABLE Jose Javier Rodriguez Barbarin
2025-11-27 15:54 ` [PATCH 1/2] mcb: Add missing modpost build support Jose Javier Rodriguez Barbarin
2025-11-27 16:10 ` Andy Shevchenko
2025-11-28 7:54 ` Jiri Slaby
2025-11-28 9:02 ` Andy Shevchenko
2025-11-28 10:35 ` Jose Javier Rodriguez Barbarin
2025-11-27 15:54 ` [PATCH 2/2] mcb: Remove MODULE_ALIAS from all mcb client drivers Jose Javier Rodriguez Barbarin
2025-11-27 16:12 ` Andy Shevchenko
2025-11-28 10:38 ` Jose Javier Rodriguez Barbarin
2025-11-27 16:16 ` [PATCH 0/2] mcb: Add modpost support for processing MODULE_DEVICE_TABLE Andy Shevchenko
2025-11-28 10:46 ` Jose Javier Rodriguez Barbarin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSl9bN2Yv5rib_-O@MNI-190 \
--to=dev-josejavier.rodriguez@duagon.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=jirislaby@kernel.org \
--cc=jth@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=morbidrsa@gmail.com \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=nuno.sa@analog.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).